add is_connected api for expansion \w @Willy-JL

This commit is contained in:
HaxSam
2024-03-01 09:49:39 +01:00
parent ab8264a52c
commit 25d686fdfb
4 changed files with 56 additions and 9 deletions

View File

@@ -18,6 +18,7 @@ typedef enum {
ExpansionStateDisabled, ExpansionStateDisabled,
ExpansionStateEnabled, ExpansionStateEnabled,
ExpansionStateRunning, ExpansionStateRunning,
ExpansionStateConnectionEstablished,
} ExpansionState; } ExpansionState;
typedef enum { typedef enum {
@@ -26,6 +27,7 @@ typedef enum {
ExpansionMessageTypeSetListenSerial, ExpansionMessageTypeSetListenSerial,
ExpansionMessageTypeModuleConnected, ExpansionMessageTypeModuleConnected,
ExpansionMessageTypeModuleDisconnected, ExpansionMessageTypeModuleDisconnected,
ExpansionMessageTypeConnectionEstablished,
} ExpansionMessageType; } ExpansionMessageType;
typedef union { typedef union {
@@ -68,13 +70,21 @@ static void expansion_detect_callback(void* context) {
UNUSED(status); UNUSED(status);
} }
static void expansion_worker_callback(void* context) { static void expansion_worker_callback(void* context, ExpansionWorkerCallbackReason reason) {
furi_assert(context); furi_assert(context);
Expansion* instance = context; Expansion* instance = context;
ExpansionMessage message = { ExpansionMessage message;
.type = ExpansionMessageTypeModuleDisconnected, switch(reason) {
.api_lock = NULL, // Not locking the API here to avoid a deadlock case ExpansionWorkerCallbackReasonExit:
message.type = ExpansionMessageTypeModuleDisconnected;
message.api_lock = NULL; // Not locking the API here to avoid a deadlock
break;
case ExpansionWorkerCallbackReasonConnected:
message.type = ExpansionMessageTypeConnectionEstablished;
message.api_lock = api_lock_alloc_locked();
break;
}; };
const FuriStatus status = furi_message_queue_put(instance->queue, &message, FuriWaitForever); const FuriStatus status = furi_message_queue_put(instance->queue, &message, FuriWaitForever);
@@ -105,7 +115,9 @@ static void
if(instance->state == ExpansionStateDisabled) { if(instance->state == ExpansionStateDisabled) {
return; return;
} else if(instance->state == ExpansionStateRunning) { } else if(
instance->state == ExpansionStateRunning ||
instance->state == ExpansionStateConnectionEstablished) {
expansion_worker_stop(instance->worker); expansion_worker_stop(instance->worker);
expansion_worker_free(instance->worker); expansion_worker_free(instance->worker);
} else { } else {
@@ -122,7 +134,8 @@ static void expansion_control_handler_set_listen_serial(
const ExpansionMessageData* data) { const ExpansionMessageData* data) {
furi_check(data->serial_id < FuriHalSerialIdMax); furi_check(data->serial_id < FuriHalSerialIdMax);
if(instance->state == ExpansionStateRunning) { if(instance->state == ExpansionStateRunning ||
instance->state == ExpansionStateConnectionEstablished) {
expansion_worker_stop(instance->worker); expansion_worker_stop(instance->worker);
expansion_worker_free(instance->worker); expansion_worker_free(instance->worker);
@@ -160,7 +173,8 @@ static void expansion_control_handler_module_disconnected(
Expansion* instance, Expansion* instance,
const ExpansionMessageData* data) { const ExpansionMessageData* data) {
UNUSED(data); UNUSED(data);
if(instance->state != ExpansionStateRunning) { if(instance->state != ExpansionStateRunning &&
instance->state != ExpansionStateConnectionEstablished) {
return; return;
} }
@@ -170,6 +184,18 @@ static void expansion_control_handler_module_disconnected(
instance->serial_id, expansion_detect_callback, instance); instance->serial_id, expansion_detect_callback, instance);
} }
static void expansion_control_handler_module_connection_established(
Expansion* instance,
const ExpansionMessageData* data) {
UNUSED(data);
if(instance->state != ExpansionStateRunning &&
instance->state != ExpansionStateConnectionEstablished) {
return;
}
instance->state = ExpansionStateConnectionEstablished;
}
typedef void (*ExpansionControlHandler)(Expansion*, const ExpansionMessageData*); typedef void (*ExpansionControlHandler)(Expansion*, const ExpansionMessageData*);
static const ExpansionControlHandler expansion_control_handlers[] = { static const ExpansionControlHandler expansion_control_handlers[] = {
@@ -178,6 +204,8 @@ static const ExpansionControlHandler expansion_control_handlers[] = {
[ExpansionMessageTypeSetListenSerial] = expansion_control_handler_set_listen_serial, [ExpansionMessageTypeSetListenSerial] = expansion_control_handler_set_listen_serial,
[ExpansionMessageTypeModuleConnected] = expansion_control_handler_module_connected, [ExpansionMessageTypeModuleConnected] = expansion_control_handler_module_connected,
[ExpansionMessageTypeModuleDisconnected] = expansion_control_handler_module_disconnected, [ExpansionMessageTypeModuleDisconnected] = expansion_control_handler_module_disconnected,
[ExpansionMessageTypeConnectionEstablished] =
expansion_control_handler_module_connection_established,
}; };
static int32_t expansion_control(void* context) { static int32_t expansion_control(void* context) {
@@ -249,6 +277,11 @@ void expansion_disable(Expansion* instance) {
api_lock_wait_unlock_and_free(message.api_lock); api_lock_wait_unlock_and_free(message.api_lock);
} }
bool expansion_is_connected(Expansion* instance) {
furi_check(instance);
return instance->state == ExpansionStateConnectionEstablished;
}
void expansion_set_listen_serial(Expansion* instance, FuriHalSerialId serial_id) { void expansion_set_listen_serial(Expansion* instance, FuriHalSerialId serial_id) {
furi_check(instance); furi_check(instance);
furi_check(serial_id < FuriHalSerialIdMax); furi_check(serial_id < FuriHalSerialIdMax);

View File

@@ -50,6 +50,14 @@ void expansion_enable(Expansion* instance);
*/ */
void expansion_disable(Expansion* instance); void expansion_disable(Expansion* instance);
/**
* @brief Check support for expansion modules if its currently connected.
*
* @param[in,out] instance pointer to the Expansion instance.
*
*/
bool expansion_is_connected(Expansion* instance);
/** /**
* @brief Enable support for expansion modules on designated serial port. * @brief Enable support for expansion modules on designated serial port.
* *

View File

@@ -223,6 +223,7 @@ static bool expansion_worker_handle_state_handshake(
if(furi_hal_serial_is_baud_rate_supported(instance->serial_handle, baud_rate)) { if(furi_hal_serial_is_baud_rate_supported(instance->serial_handle, baud_rate)) {
instance->state = ExpansionWorkerStateConnected; instance->state = ExpansionWorkerStateConnected;
instance->callback(instance->cb_context, ExpansionWorkerCallbackReasonConnected);
// Send response at previous baud rate // Send response at previous baud rate
if(!expansion_worker_send_status_response(instance, ExpansionFrameErrorNone)) break; if(!expansion_worker_send_status_response(instance, ExpansionFrameErrorNone)) break;
furi_hal_serial_set_br(instance->serial_handle, baud_rate); furi_hal_serial_set_br(instance->serial_handle, baud_rate);
@@ -351,7 +352,7 @@ static int32_t expansion_worker(void* context) {
// Do not invoke worker callback on user-requested exit // Do not invoke worker callback on user-requested exit
if((instance->exit_reason != ExpansionWorkerExitReasonUser) && (instance->callback != NULL)) { if((instance->exit_reason != ExpansionWorkerExitReasonUser) && (instance->callback != NULL)) {
instance->callback(instance->cb_context); instance->callback(instance->cb_context, ExpansionWorkerCallbackReasonExit);
} }
return 0; return 0;

View File

@@ -17,6 +17,11 @@
*/ */
typedef struct ExpansionWorker ExpansionWorker; typedef struct ExpansionWorker ExpansionWorker;
typedef enum {
ExpansionWorkerCallbackReasonExit,
ExpansionWorkerCallbackReasonConnected,
} ExpansionWorkerCallbackReason;
/** /**
* @brief Worker callback type. * @brief Worker callback type.
* *
@@ -24,7 +29,7 @@ typedef struct ExpansionWorker ExpansionWorker;
* *
* @param[in,out] context pointer to a user-defined object. * @param[in,out] context pointer to a user-defined object.
*/ */
typedef void (*ExpansionWorkerCallback)(void* context); typedef void (*ExpansionWorkerCallback)(void* context, ExpansionWorkerCallbackReason reason);
/** /**
* @brief Create an expansion worker instance. * @brief Create an expansion worker instance.