totp upd

applications/plugins/totp/scenes/add_new_token/totp_scene_add_new_token.c

@@ -62,7 +62,9 @@ static void on_token_secret_user_comitted(InputTextSceneCallbackResult* result)
     free(result);
 }
 
-void totp_scene_add_new_token_activate(PluginState* plugin_state, const TokenAddEditSceneContext* context) {
+void totp_scene_add_new_token_activate(
+    PluginState* plugin_state,
+    const TokenAddEditSceneContext* context) {
     SceneState* scene_state = malloc(sizeof(SceneState));
     plugin_state->current_scene_state = scene_state;
     scene_state->token_name = "Name";
@@ -98,11 +100,38 @@ void totp_scene_add_new_token_render(Canvas* const canvas, PluginState* plugin_s
         return;
     }
 
-    ui_control_text_box_render(canvas, 10 - scene_state->screen_y_offset, scene_state->token_name, scene_state->selected_control == TokenNameTextBox);
+    ui_control_text_box_render(
-    ui_control_text_box_render(canvas, 27 - scene_state->screen_y_offset, scene_state->token_secret, scene_state->selected_control == TokenSecretTextBox);
+        canvas,
-    ui_control_select_render(canvas, 0, 44 - scene_state->screen_y_offset, SCREEN_WIDTH, TOKEN_ALGO_LIST[scene_state->algo], scene_state->selected_control == TokenAlgoSelect);
+        10 - scene_state->screen_y_offset,
-    ui_control_select_render(canvas, 0, 63 - scene_state->screen_y_offset, SCREEN_WIDTH, TOKEN_DIGITS_LIST[scene_state->digits_count], scene_state->selected_control == TokenLengthSelect);
+        scene_state->token_name,
-    ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 24, 85 - scene_state->screen_y_offset, 48, 13, "Confirm", scene_state->selected_control == ConfirmButton);
+        scene_state->selected_control == TokenNameTextBox);
+    ui_control_text_box_render(
+        canvas,
+        27 - scene_state->screen_y_offset,
+        scene_state->token_secret,
+        scene_state->selected_control == TokenSecretTextBox);
+    ui_control_select_render(
+        canvas,
+        0,
+        44 - scene_state->screen_y_offset,
+        SCREEN_WIDTH,
+        TOKEN_ALGO_LIST[scene_state->algo],
+        scene_state->selected_control == TokenAlgoSelect);
+    ui_control_select_render(
+        canvas,
+        0,
+        63 - scene_state->screen_y_offset,
+        SCREEN_WIDTH,
+        TOKEN_DIGITS_LIST[scene_state->digits_count],
+        scene_state->selected_control == TokenLengthSelect);
+    ui_control_button_render(
+        canvas,
+        SCREEN_WIDTH_CENTER - 24,
+        85 - scene_state->screen_y_offset,
+        48,
+        13,
+        "Confirm",
+        scene_state->selected_control == ConfirmButton);
 
     canvas_set_color(canvas, ColorWhite);
     canvas_draw_box(canvas, 0, 0, SCREEN_WIDTH, 10);
@@ -123,7 +152,8 @@ void update_screen_y_offset(SceneState* scene_state) {
 bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState* plugin_state) {
     if(event->type == EventTypeKey) {
         SceneState* scene_state = (SceneState*)plugin_state->current_scene_state;
-        if (scene_state->input_started_at > 0 && furi_get_tick() - scene_state->input_started_at > 300) {
+        if(scene_state->input_started_at > 0 &&
+           furi_get_tick() - scene_state->input_started_at > 300) {
             return totp_input_text_handle_event(event, scene_state->input_state);
         }
 
@@ -150,8 +180,7 @@ bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState
                     } else {
                         scene_state->algo = SHA1;
                     }
-                    }
+                } else if(scene_state->selected_control == TokenLengthSelect) {
-                    else if (scene_state->selected_control == TokenLengthSelect) {
                     if(scene_state->digits_count < TOTP_8_DIGITS) {
                         scene_state->digits_count++;
                     } else {
@@ -166,8 +195,7 @@ bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState
                     } else {
                         scene_state->algo = SHA512;
                     }
-                    }
+                } else if(scene_state->selected_control == TokenLengthSelect) {
-                    else if (scene_state->selected_control == TokenLengthSelect) {
                     if(scene_state->digits_count > TOTP_6_DIGITS) {
                         scene_state->digits_count--;
                     } else {
@@ -181,14 +209,16 @@ bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState
                     if(scene_state->input_state != NULL) {
                         totp_input_text_free(scene_state->input_state);
                     }
-                            scene_state->input_state = totp_input_text_activate(scene_state->token_name_input_context);
+                    scene_state->input_state =
+                        totp_input_text_activate(scene_state->token_name_input_context);
                     scene_state->input_started_at = furi_get_tick();
                     break;
                 case TokenSecretTextBox:
                     if(scene_state->input_state != NULL) {
                         totp_input_text_free(scene_state->input_state);
                     }
-                            scene_state->input_state = totp_input_text_activate(scene_state->token_secret_input_context);
+                    scene_state->input_state =
+                        totp_input_text_activate(scene_state->token_secret_input_context);
                     scene_state->input_started_at = furi_get_tick();
                     break;
                 case TokenAlgoSelect:
@@ -200,7 +230,11 @@ bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState
                     tokenInfo->name = malloc(scene_state->token_name_length + 1);
                     strcpy(tokenInfo->name, scene_state->token_name);
 
-                            token_info_set_secret(tokenInfo, scene_state->token_secret, scene_state->token_secret_length, &plugin_state->iv[0]);
+                    token_info_set_secret(
+                        tokenInfo,
+                        scene_state->token_secret,
+                        scene_state->token_secret_length,
+                        &plugin_state->iv[0]);
 
                     tokenInfo->algo = scene_state->algo;
                     tokenInfo->digits = scene_state->digits_count;
@@ -214,16 +248,20 @@ bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState
 
                     totp_config_file_save_new_token(tokenInfo);
 
-                            GenerateTokenSceneContext generate_scene_context = { .current_token_index = plugin_state->tokens_count - 1 };
+                    GenerateTokenSceneContext generate_scene_context = {
-                            totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, &generate_scene_context);
+                        .current_token_index = plugin_state->tokens_count - 1};
+                    totp_scene_director_activate_scene(
+                        plugin_state, TotpSceneGenerateToken, &generate_scene_context);
                     break;
                 }
                 }
                 break;
             case InputKeyBack:
                 if(scene_state->current_token_index >= 0) {
-                        GenerateTokenSceneContext generate_scene_context = { .current_token_index = scene_state->current_token_index };
+                    GenerateTokenSceneContext generate_scene_context = {
-                        totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, &generate_scene_context);
+                        .current_token_index = scene_state->current_token_index};
+                    totp_scene_director_activate_scene(
+                        plugin_state, TotpSceneGenerateToken, &generate_scene_context);
                 } else {
                     totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, NULL);
                 }

applications/plugins/totp/scenes/add_new_token/totp_scene_add_new_token.h

@@ -11,7 +11,9 @@ typedef struct {
 } TokenAddEditSceneContext;
 
 void totp_scene_add_new_token_init(PluginState* plugin_state);
-void totp_scene_add_new_token_activate(PluginState* plugin_state, const TokenAddEditSceneContext* context);
+void totp_scene_add_new_token_activate(
+    PluginState* plugin_state,
+    const TokenAddEditSceneContext* context);
 void totp_scene_add_new_token_render(Canvas* const canvas, PluginState* plugin_state);
 bool totp_scene_add_new_token_handle_event(PluginEvent* const event, PluginState* plugin_state);
 void totp_scene_add_new_token_deactivate(PluginState* plugin_state);

applications/plugins/totp/scenes/app_settings/totp_app_settings.c

@@ -7,11 +7,7 @@
 
 #define DIGIT_TO_CHAR(digit) ((digit) + '0')
 
-typedef enum {
+typedef enum { HoursInput, MinutesInput, ConfirmButton } Control;
-    HoursInput,
-    MinutesInput,
-    ConfirmButton
-} Control;
 
 typedef struct {
     int8_t tz_offset_hours;
@@ -24,7 +20,9 @@ void totp_scene_app_settings_init(PluginState* plugin_state) {
     UNUSED(plugin_state);
 }
 
-void totp_scene_app_settings_activate(PluginState* plugin_state, const AppSettingsSceneContext* context) {
+void totp_scene_app_settings_activate(
+    PluginState* plugin_state,
+    const AppSettingsSceneContext* context) {
     SceneState* scene_state = malloc(sizeof(SceneState));
     plugin_state->current_scene_state = scene_state;
     if(context != NULL) {
@@ -64,13 +62,32 @@ void totp_scene_app_settings_render(Canvas* const canvas, PluginState* plugin_st
     char tmp_str[4];
     two_digit_to_str(scene_state->tz_offset_hours, &tmp_str[0]);
     canvas_draw_str_aligned(canvas, 0, 16, AlignLeft, AlignTop, "Hours:");
-    ui_control_select_render(canvas, 36, 10, SCREEN_WIDTH - 36, &tmp_str[0], scene_state->selected_control == HoursInput);
+    ui_control_select_render(
+        canvas,
+        36,
+        10,
+        SCREEN_WIDTH - 36,
+        &tmp_str[0],
+        scene_state->selected_control == HoursInput);
 
     two_digit_to_str(scene_state->tz_offset_minutes, &tmp_str[0]);
     canvas_draw_str_aligned(canvas, 0, 34, AlignLeft, AlignTop, "Minutes:");
-    ui_control_select_render(canvas, 36, 28, SCREEN_WIDTH - 36, &tmp_str[0], scene_state->selected_control == MinutesInput);
+    ui_control_select_render(
+        canvas,
+        36,
+        28,
+        SCREEN_WIDTH - 36,
+        &tmp_str[0],
+        scene_state->selected_control == MinutesInput);
 
-    ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 24, 50, 48, 13, "Confirm", scene_state->selected_control == ConfirmButton);
+    ui_control_button_render(
+        canvas,
+        SCREEN_WIDTH_CENTER - 24,
+        50,
+        48,
+        13,
+        "Confirm",
+        scene_state->selected_control == ConfirmButton);
 }
 
 bool totp_scene_app_settings_handle_event(PluginEvent* const event, PluginState* plugin_state) {
@@ -116,12 +133,15 @@ bool totp_scene_app_settings_handle_event(PluginEvent* const event, PluginState*
                 break;
             case InputKeyOk:
                 if(scene_state->selected_control == ConfirmButton) {
-                        plugin_state->timezone_offset = (float)scene_state->tz_offset_hours + (float)scene_state->tz_offset_minutes / 60.0f;
+                    plugin_state->timezone_offset = (float)scene_state->tz_offset_hours +
+                                                    (float)scene_state->tz_offset_minutes / 60.0f;
                     totp_config_file_update_timezone_offset(plugin_state->timezone_offset);
 
                     if(scene_state->current_token_index >= 0) {
-                            TokenMenuSceneContext generate_scene_context = { .current_token_index = scene_state->current_token_index };
+                        TokenMenuSceneContext generate_scene_context = {
-                            totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, &generate_scene_context);
+                            .current_token_index = scene_state->current_token_index};
+                        totp_scene_director_activate_scene(
+                            plugin_state, TotpSceneTokenMenu, &generate_scene_context);
                     } else {
                         totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, NULL);
                     }
@@ -129,8 +149,10 @@ bool totp_scene_app_settings_handle_event(PluginEvent* const event, PluginState*
                 break;
             case InputKeyBack: {
                 if(scene_state->current_token_index >= 0) {
-                        TokenMenuSceneContext generate_scene_context = { .current_token_index = scene_state->current_token_index };
+                    TokenMenuSceneContext generate_scene_context = {
-                        totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, &generate_scene_context);
+                        .current_token_index = scene_state->current_token_index};
+                    totp_scene_director_activate_scene(
+                        plugin_state, TotpSceneTokenMenu, &generate_scene_context);
                 } else {
                     totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, NULL);
                 }

applications/plugins/totp/scenes/app_settings/totp_app_settings.h

@@ -11,7 +11,9 @@ typedef struct {
 } AppSettingsSceneContext;
 
 void totp_scene_app_settings_init(PluginState* plugin_state);
-void totp_scene_app_settings_activate(PluginState* plugin_state, const AppSettingsSceneContext* context);
+void totp_scene_app_settings_activate(
+    PluginState* plugin_state,
+    const AppSettingsSceneContext* context);
 void totp_scene_app_settings_render(Canvas* const canvas, PluginState* plugin_state);
 bool totp_scene_app_settings_handle_event(PluginEvent* const event, PluginState* plugin_state);
 void totp_scene_app_settings_deactivate(PluginState* plugin_state);

applications/plugins/totp/scenes/authenticate/totp_scene_authenticate.c

@@ -35,10 +35,28 @@ void totp_scene_authenticate_render(Canvas* const canvas, PluginState* plugin_st
     }
 
     if(plugin_state->crypto_verify_data == NULL) {
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER - 10 + v_shift, AlignCenter, AlignCenter, "Use arrow keys");
+        canvas_draw_str_aligned(
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER + 5 + v_shift, AlignCenter, AlignCenter, "to setup new PIN");
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER - 10 + v_shift,
+            AlignCenter,
+            AlignCenter,
+            "Use arrow keys");
+        canvas_draw_str_aligned(
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER + 5 + v_shift,
+            AlignCenter,
+            AlignCenter,
+            "to setup new PIN");
     } else {
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER + v_shift, AlignCenter, AlignCenter, "Use arrow keys to enter PIN");
+        canvas_draw_str_aligned(
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER + v_shift,
+            AlignCenter,
+            AlignCenter,
+            "Use arrow keys to enter PIN");
     }
     const uint8_t PIN_ASTERISK_RADIUS = 3;
     const uint8_t PIN_ASTERISK_STEP = (PIN_ASTERISK_RADIUS << 1) + 2;
@@ -92,7 +110,8 @@ bool totp_scene_authenticate_handle_event(PluginEvent* const event, PluginState*
                 }
                 break;
             case InputKeyOk:
-                    totp_crypto_seed_iv(plugin_state, &scene_state->code_input[0], scene_state->code_length);
+                totp_crypto_seed_iv(
+                    plugin_state, &scene_state->code_input[0], scene_state->code_length);
 
                 if(totp_crypto_verify_key(plugin_state)) {
                     FURI_LOG_D(LOGGING_TAG, "PIN is valid");
@@ -105,7 +124,13 @@ bool totp_scene_authenticate_handle_event(PluginEvent* const event, PluginState*
 
                     DialogMessage* message = dialog_message_alloc();
                     dialog_message_set_buttons(message, "Try again", NULL, NULL);
-                        dialog_message_set_header(message, "You entered\ninvalid PIN", SCREEN_WIDTH_CENTER - 25, SCREEN_HEIGHT_CENTER - 5, AlignCenter, AlignCenter);
+                    dialog_message_set_header(
+                        message,
+                        "You entered\ninvalid PIN",
+                        SCREEN_WIDTH_CENTER - 25,
+                        SCREEN_HEIGHT_CENTER - 5,
+                        AlignCenter,
+                        AlignCenter);
                     dialog_message_set_icon(message, &I_DolphinCommon_56x48, 72, 17);
                     dialog_message_show(plugin_state->dialogs, message);
                     dialog_message_free(message);

applications/plugins/totp/scenes/generate_token/totp_scene_generate_token.c

@@ -72,9 +72,12 @@ static void i_token_to_str(uint32_t i_token_code, char* str, TokenDigitsCount le
 
 TOTP_ALGO get_totp_algo_impl(TokenHashAlgo algo) {
     switch(algo) {
-        case SHA1: return TOTP_ALGO_SHA1;
+    case SHA1:
-        case SHA256: return TOTP_ALGO_SHA256;
+        return TOTP_ALGO_SHA1;
-        case SHA512: return TOTP_ALGO_SHA512;
+    case SHA256:
+        return TOTP_ALGO_SHA256;
+    case SHA512:
+        return TOTP_ALGO_SHA512;
     }
 
     return NULL;
@@ -84,7 +87,10 @@ void update_totp_params(PluginState* const plugin_state) {
     SceneState* scene_state = (SceneState*)plugin_state->current_scene_state;
 
     if(scene_state->current_token_index < plugin_state->tokens_count) {
-        TokenInfo* tokenInfo = (TokenInfo *)(list_element_at(plugin_state->tokens_list, scene_state->current_token_index)->data);
+        TokenInfo* tokenInfo =
+            (TokenInfo*)(list_element_at(
+                             plugin_state->tokens_list, scene_state->current_token_index)
+                             ->data);
 
         scene_state->need_token_update = true;
         scene_state->last_code_name = tokenInfo->name;
@@ -95,7 +101,9 @@ void totp_scene_generate_token_init(PluginState* plugin_state) {
     UNUSED(plugin_state);
 }
 
-void totp_scene_generate_token_activate(PluginState* plugin_state, const GenerateTokenSceneContext* context) {
+void totp_scene_generate_token_activate(
+    PluginState* plugin_state,
+    const GenerateTokenSceneContext* context) {
     if(!plugin_state->token_list_loaded) {
         totp_config_file_load_tokens(plugin_state);
     }
@@ -113,8 +121,20 @@ void totp_scene_generate_token_activate(PluginState* plugin_state, const Generat
 
 void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_state) {
     if(plugin_state->tokens_count == 0) {
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER - 10, AlignCenter, AlignCenter, "Token list is empty");
+        canvas_draw_str_aligned(
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER + 10, AlignCenter, AlignCenter, "Press OK button to add");
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER - 10,
+            AlignCenter,
+            AlignCenter,
+            "Token list is empty");
+        canvas_draw_str_aligned(
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER + 10,
+            AlignCenter,
+            AlignCenter,
+            "Press OK button to add");
         return;
     }
 
@@ -132,12 +152,26 @@ void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_
         scene_state->need_token_update = false;
         scene_state->last_token_gen_time = curr_ts;
 
-        TokenInfo* tokenInfo = (TokenInfo*)(list_element_at(plugin_state->tokens_list, scene_state->current_token_index)->data);
+        TokenInfo* tokenInfo =
+            (TokenInfo*)(list_element_at(
+                             plugin_state->tokens_list, scene_state->current_token_index)
+                             ->data);
 
         uint8_t key_length;
-        uint8_t* key = totp_crypto_decrypt(tokenInfo->token, tokenInfo->token_length, &plugin_state->iv[0], &key_length);
+        uint8_t* key = totp_crypto_decrypt(
+            tokenInfo->token, tokenInfo->token_length, &plugin_state->iv[0], &key_length);
 
-        i_token_to_str(totp_at(get_totp_algo_impl(tokenInfo->algo), token_info_get_digits_count(tokenInfo), key, key_length, curr_ts, plugin_state->timezone_offset, TOKEN_LIFETIME), scene_state->last_code, tokenInfo->digits);
+        i_token_to_str(
+            totp_at(
+                get_totp_algo_impl(tokenInfo->algo),
+                token_info_get_digits_count(tokenInfo),
+                key,
+                key_length,
+                curr_ts,
+                plugin_state->timezone_offset,
+                TOKEN_LIFETIME),
+            scene_state->last_code,
+            tokenInfo->digits);
         memset(key, 0, key_length);
         free(key);
 
@@ -149,9 +183,21 @@ void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_
     canvas_set_font(canvas, FontPrimary);
     uint16_t token_name_width = canvas_string_width(canvas, scene_state->last_code_name);
     if(SCREEN_WIDTH - token_name_width > 18) {
-        canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER - 20, AlignCenter, AlignCenter, scene_state->last_code_name);
+        canvas_draw_str_aligned(
+            canvas,
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER - 20,
+            AlignCenter,
+            AlignCenter,
+            scene_state->last_code_name);
     } else {
-        canvas_draw_str_aligned(canvas, 9, SCREEN_HEIGHT_CENTER - 20, AlignLeft, AlignCenter, scene_state->last_code_name);
+        canvas_draw_str_aligned(
+            canvas,
+            9,
+            SCREEN_HEIGHT_CENTER - 20,
+            AlignLeft,
+            AlignCenter,
+            scene_state->last_code_name);
         canvas_set_color(canvas, ColorWhite);
         canvas_draw_box(canvas, 0, SCREEN_HEIGHT_CENTER - 24, 9, 9);
         canvas_draw_box(canvas, SCREEN_WIDTH - 10, SCREEN_HEIGHT_CENTER - 24, 9, 9);
@@ -159,7 +205,13 @@ void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_
     }
 
     canvas_set_font(canvas, FontBigNumbers);
-    canvas_draw_str_aligned(canvas, SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER, AlignCenter, AlignCenter, scene_state->last_code);
+    canvas_draw_str_aligned(
+        canvas,
+        SCREEN_WIDTH_CENTER,
+        SCREEN_HEIGHT_CENTER,
+        AlignCenter,
+        AlignCenter,
+        scene_state->last_code);
 
     const uint8_t BAR_MARGIN = 3;
     const uint8_t BAR_HEIGHT = 4;
@@ -167,16 +219,23 @@ void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_
     uint8_t barWidth = (uint8_t)((float)(SCREEN_WIDTH - (BAR_MARGIN << 1)) * percentDone);
     uint8_t barX = ((SCREEN_WIDTH - (BAR_MARGIN << 1) - barWidth) >> 1) + BAR_MARGIN;
 
-    canvas_draw_box(
+    canvas_draw_box(canvas, barX, SCREEN_HEIGHT - BAR_MARGIN - BAR_HEIGHT, barWidth, BAR_HEIGHT);
-        canvas, 
-        barX, 
-        SCREEN_HEIGHT - BAR_MARGIN - BAR_HEIGHT, 
-        barWidth, 
-        BAR_HEIGHT);
 
     if(plugin_state->tokens_count > 1) {
-        canvas_draw_xbm(canvas, 0, SCREEN_HEIGHT_CENTER - 24, ICON_ARROW_LEFT_8x9_WIDTH, ICON_ARROW_LEFT_8x9_HEIGHT, &ICON_ARROW_LEFT_8x9[0]);
+        canvas_draw_xbm(
-        canvas_draw_xbm(canvas, SCREEN_WIDTH - 9, SCREEN_HEIGHT_CENTER - 24, ICON_ARROW_RIGHT_8x9_WIDTH, ICON_ARROW_RIGHT_8x9_HEIGHT, &ICON_ARROW_RIGHT_8x9[0]);
+            canvas,
+            0,
+            SCREEN_HEIGHT_CENTER - 24,
+            ICON_ARROW_LEFT_8x9_WIDTH,
+            ICON_ARROW_LEFT_8x9_HEIGHT,
+            &ICON_ARROW_LEFT_8x9[0]);
+        canvas_draw_xbm(
+            canvas,
+            SCREEN_WIDTH - 9,
+            SCREEN_HEIGHT_CENTER - 24,
+            ICON_ARROW_RIGHT_8x9_WIDTH,
+            ICON_ARROW_RIGHT_8x9_HEIGHT,
+            &ICON_ARROW_RIGHT_8x9[0]);
     }
 }
 
@@ -211,7 +270,8 @@ bool totp_scene_generate_token_handle_event(PluginEvent* const event, PluginStat
                 if(plugin_state->tokens_count == 0) {
                     totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, NULL);
                 } else {
-                        TokenMenuSceneContext ctx = { .current_token_index = scene_state->current_token_index };
+                    TokenMenuSceneContext ctx = {
+                        .current_token_index = scene_state->current_token_index};
                     totp_scene_director_activate_scene(plugin_state, TotpSceneTokenMenu, &ctx);
                 }
                 break;

applications/plugins/totp/scenes/generate_token/totp_scene_generate_token.h

@@ -11,7 +11,9 @@ typedef struct {
 } GenerateTokenSceneContext;
 
 void totp_scene_generate_token_init(PluginState* plugin_state);
-void totp_scene_generate_token_activate(PluginState* plugin_state, const GenerateTokenSceneContext* context);
+void totp_scene_generate_token_activate(
+    PluginState* plugin_state,
+    const GenerateTokenSceneContext* context);
 void totp_scene_generate_token_render(Canvas* const canvas, PluginState* plugin_state);
 bool totp_scene_generate_token_handle_event(PluginEvent* const event, PluginState* plugin_state);
 void totp_scene_generate_token_deactivate(PluginState* plugin_state);

applications/plugins/totp/scenes/scene_director.c

@@ -6,7 +6,10 @@
 #include "token_menu/totp_scene_token_menu.h"
 #include "app_settings/totp_app_settings.h"
 
-void totp_scene_director_activate_scene(PluginState* const plugin_state, Scene scene, const void* context) {   
+void totp_scene_director_activate_scene(
+    PluginState* const plugin_state,
+    Scene scene,
+    const void* context) {
     plugin_state->changing_scene = true;
     totp_scene_director_deactivate_active_scene(plugin_state);
     switch(scene) {

applications/plugins/totp/scenes/scene_director.h

@@ -5,7 +5,10 @@
 #include "../types/plugin_event.h"
 #include "totp_scenes_enum.h"
 
-void totp_scene_director_activate_scene(PluginState* const plugin_state, Scene scene, const void* context);
+void totp_scene_director_activate_scene(
+    PluginState* const plugin_state,
+    Scene scene,
+    const void* context);
 void totp_scene_director_deactivate_active_scene(PluginState* const plugin_state);
 void totp_scene_director_init_scenes(PluginState* const plugin_state);
 void totp_scene_director_render(Canvas* const canvas, PluginState* const plugin_state);

applications/plugins/totp/scenes/token_menu/totp_scene_token_menu.c

@@ -14,11 +14,7 @@
 #define SCREEN_HEIGHT_THIRD (SCREEN_HEIGHT / 3)
 #define SCREEN_HEIGHT_THIRD_CENTER (SCREEN_HEIGHT_THIRD >> 1)
 
-typedef enum {
+typedef enum { AddNewToken, DeleteToken, AppSettings } Control;
-    AddNewToken,
-    DeleteToken,
-    AppSettings
-} Control;
 
 typedef struct {
     Control selected_control;
@@ -29,7 +25,9 @@ void totp_scene_token_menu_init(PluginState* plugin_state) {
     UNUSED(plugin_state);
 }
 
-void totp_scene_token_menu_activate(PluginState* plugin_state, const TokenMenuSceneContext* context) {
+void totp_scene_token_menu_activate(
+    PluginState* plugin_state,
+    const TokenMenuSceneContext* context) {
     SceneState* scene_state = malloc(sizeof(SceneState));
     plugin_state->current_scene_state = scene_state;
     if(context != NULL) {
@@ -42,12 +40,47 @@ void totp_scene_token_menu_activate(PluginState* plugin_state, const TokenMenuSc
 void totp_scene_token_menu_render(Canvas* const canvas, PluginState* plugin_state) {
     SceneState* scene_state = (SceneState*)plugin_state->current_scene_state;
     if(scene_state->current_token_index < 0) {
-        ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 36, 5, 72, 21, "Add new token", scene_state->selected_control == AddNewToken);
+        ui_control_button_render(
-        ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 36, 39, 72, 21, "Settings", scene_state->selected_control == AppSettings);
+            canvas,
+            SCREEN_WIDTH_CENTER - 36,
+            5,
+            72,
+            21,
+            "Add new token",
+            scene_state->selected_control == AddNewToken);
+        ui_control_button_render(
+            canvas,
+            SCREEN_WIDTH_CENTER - 36,
+            39,
+            72,
+            21,
+            "Settings",
+            scene_state->selected_control == AppSettings);
     } else {
-        ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 36, SCREEN_HEIGHT_THIRD_CENTER - 8, 72, 16, "Add new token", scene_state->selected_control == AddNewToken);
+        ui_control_button_render(
-        ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 36, SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD_CENTER - 8, 72, 16, "Delete token", scene_state->selected_control == DeleteToken);
+            canvas,
-        ui_control_button_render(canvas, SCREEN_WIDTH_CENTER - 36, SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD_CENTER - 8, 72, 16, "Settings", scene_state->selected_control == AppSettings);
+            SCREEN_WIDTH_CENTER - 36,
+            SCREEN_HEIGHT_THIRD_CENTER - 8,
+            72,
+            16,
+            "Add new token",
+            scene_state->selected_control == AddNewToken);
+        ui_control_button_render(
+            canvas,
+            SCREEN_WIDTH_CENTER - 36,
+            SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD_CENTER - 8,
+            72,
+            16,
+            "Delete token",
+            scene_state->selected_control == DeleteToken);
+        ui_control_button_render(
+            canvas,
+            SCREEN_WIDTH_CENTER - 36,
+            SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD + SCREEN_HEIGHT_THIRD_CENTER - 8,
+            72,
+            16,
+            "Settings",
+            scene_state->selected_control == AppSettings);
     }
 }
 
@@ -59,7 +92,8 @@ bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* p
             case InputKeyUp:
                 if(scene_state->selected_control > AddNewToken) {
                     scene_state->selected_control--;
-                        if (scene_state->selected_control == DeleteToken && scene_state->current_token_index < 0) {
+                    if(scene_state->selected_control == DeleteToken &&
+                       scene_state->current_token_index < 0) {
                         scene_state->selected_control--;
                     }
                 } else {
@@ -69,7 +103,8 @@ bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* p
             case InputKeyDown:
                 if(scene_state->selected_control < AppSettings) {
                     scene_state->selected_control++;
-                        if (scene_state->selected_control == DeleteToken && scene_state->current_token_index < 0) {
+                    if(scene_state->selected_control == DeleteToken &&
+                       scene_state->current_token_index < 0) {
                         scene_state->selected_control++;
                     }
                 } else {
@@ -83,16 +118,25 @@ bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* p
             case InputKeyOk:
                 switch(scene_state->selected_control) {
                 case AddNewToken: {
-                            TokenAddEditSceneContext add_new_token_scene_context = { .current_token_index = scene_state->current_token_index };
+                    TokenAddEditSceneContext add_new_token_scene_context = {
-                            totp_scene_director_activate_scene(plugin_state, TotpSceneAddNewToken, &add_new_token_scene_context);
+                        .current_token_index = scene_state->current_token_index};
+                    totp_scene_director_activate_scene(
+                        plugin_state, TotpSceneAddNewToken, &add_new_token_scene_context);
                     break;
                 }
                 case DeleteToken: {
                     DialogMessage* message = dialog_message_alloc();
                     dialog_message_set_buttons(message, "No", NULL, "Yes");
                     dialog_message_set_header(message, "Confirmation", 0, 0, AlignLeft, AlignTop);
-                            dialog_message_set_text(message, "Are you sure want to delete?", SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER, AlignCenter, AlignCenter);
+                    dialog_message_set_text(
-                            DialogMessageButton dialog_result = dialog_message_show(plugin_state->dialogs, message);
+                        message,
+                        "Are you sure want to delete?",
+                        SCREEN_WIDTH_CENTER,
+                        SCREEN_HEIGHT_CENTER,
+                        AlignCenter,
+                        AlignCenter);
+                    DialogMessageButton dialog_result =
+                        dialog_message_show(plugin_state->dialogs, message);
                     dialog_message_free(message);
                     if(dialog_result == DialogMessageButtonRight) {
                         uint8_t i = 0;
@@ -105,20 +149,25 @@ bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* p
 
                         TokenInfo* tokenInfo = list_node->data;
                         token_info_free(tokenInfo);
-                                plugin_state->tokens_list = list_remove(plugin_state->tokens_list, list_node);
+                        plugin_state->tokens_list =
+                            list_remove(plugin_state->tokens_list, list_node);
                         plugin_state->tokens_count--;
 
                         totp_full_save_config_file(plugin_state);
-                                totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, NULL);
+                        totp_scene_director_activate_scene(
+                            plugin_state, TotpSceneGenerateToken, NULL);
                     }
                     break;
                 }
                 case AppSettings: {
                     if(scene_state->current_token_index >= 0) {
-                                AppSettingsSceneContext app_settings_context = { .current_token_index = scene_state->current_token_index };
+                        AppSettingsSceneContext app_settings_context = {
-                                totp_scene_director_activate_scene(plugin_state, TotpSceneAppSettings, &app_settings_context);
+                            .current_token_index = scene_state->current_token_index};
+                        totp_scene_director_activate_scene(
+                            plugin_state, TotpSceneAppSettings, &app_settings_context);
                     } else {
-                                totp_scene_director_activate_scene(plugin_state, TotpSceneAppSettings, NULL);
+                        totp_scene_director_activate_scene(
+                            plugin_state, TotpSceneAppSettings, NULL);
                     }
                     break;
                 }
@@ -126,8 +175,10 @@ bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* p
                 break;
             case InputKeyBack: {
                 if(scene_state->current_token_index >= 0) {
-                        GenerateTokenSceneContext generate_scene_context = { .current_token_index = scene_state->current_token_index };
+                    GenerateTokenSceneContext generate_scene_context = {
-                        totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, &generate_scene_context);
+                        .current_token_index = scene_state->current_token_index};
+                    totp_scene_director_activate_scene(
+                        plugin_state, TotpSceneGenerateToken, &generate_scene_context);
                 } else {
                     totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, NULL);
                 }

applications/plugins/totp/scenes/token_menu/totp_scene_token_menu.h

@@ -11,7 +11,9 @@ typedef struct {
 } TokenMenuSceneContext;
 
 void totp_scene_token_menu_init(PluginState* plugin_state);
-void totp_scene_token_menu_activate(PluginState* plugin_state, const TokenMenuSceneContext* context);
+void totp_scene_token_menu_activate(
+    PluginState* plugin_state,
+    const TokenMenuSceneContext* context);
 void totp_scene_token_menu_render(Canvas* const canvas, PluginState* plugin_state);
 bool totp_scene_token_menu_handle_event(PluginEvent* const event, PluginState* plugin_state);
 void totp_scene_token_menu_deactivate(PluginState* plugin_state);

applications/plugins/totp/services/base32/base32.c

@@ -61,8 +61,7 @@ int base32_decode(const uint8_t *encoded, uint8_t *result, int bufSize) {
     return count;
 }
 
-int base32_encode(const uint8_t *data, int length, uint8_t *result,
+int base32_encode(const uint8_t* data, int length, uint8_t* result, int bufSize) {
-                  int bufSize) {
     if(length < 0 || length > (1 << 28)) {
         return -1;
     }

applications/plugins/totp/services/base32/base32.h

@@ -31,6 +31,5 @@
 
 int base32_decode(const uint8_t* encoded, uint8_t* result, int bufSize)
     __attribute__((visibility("hidden")));
-int base32_encode(const uint8_t *data, int length, uint8_t *result,
+int base32_encode(const uint8_t* data, int length, uint8_t* result, int bufSize)
-                  int bufSize)
     __attribute__((visibility("hidden")));

applications/plugins/totp/services/config/config.c

@@ -12,8 +12,10 @@
 
 uint8_t token_info_get_digits_as_int(TokenInfo* token_info) {
     switch(token_info->digits) {
-        case TOTP_6_DIGITS: return 6;
+    case TOTP_6_DIGITS:
-        case TOTP_8_DIGITS: return 8;
+        return 6;
+    case TOTP_8_DIGITS:
+        return 8;
     }
 
     return 6;
@@ -32,9 +34,12 @@ void token_info_set_digits_from_int(TokenInfo* token_info, uint8_t digits) {
 
 char* token_info_get_algo_as_cstr(TokenInfo* token_info) {
     switch(token_info->algo) {
-        case SHA1: return TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME;
+    case SHA1:
-        case SHA256: return TOTP_CONFIG_TOKEN_ALGO_SHA256_NAME;
+        return TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME;
-        case SHA512: return TOTP_CONFIG_TOKEN_ALGO_SHA512_NAME;
+    case SHA256:
+        return TOTP_CONFIG_TOKEN_ALGO_SHA256_NAME;
+    case SHA512:
+        return TOTP_CONFIG_TOKEN_ALGO_SHA512_NAME;
     }
 
     return NULL;
@@ -71,7 +76,10 @@ FlipperFormat* totp_open_config_file(Storage* storage) {
     } else {
         FURI_LOG_D(LOGGING_TAG, "Config file %s is not found. Will create new.", CONFIG_FILE_PATH);
         if(storage_common_stat(storage, CONFIG_FILE_DIRECTORY_PATH, NULL) == FSE_NOT_EXIST) {
-            FURI_LOG_D(LOGGING_TAG, "Directory %s doesn't exist. Will create new.", CONFIG_FILE_DIRECTORY_PATH);
+            FURI_LOG_D(
+                LOGGING_TAG,
+                "Directory %s doesn't exist. Will create new.",
+                CONFIG_FILE_DIRECTORY_PATH);
             if(!storage_simply_mkdir(storage, CONFIG_FILE_DIRECTORY_PATH)) {
                 FURI_LOG_E(LOGGING_TAG, "Error creating directory %s", CONFIG_FILE_DIRECTORY_PATH);
                 return NULL;
@@ -84,33 +92,48 @@ FlipperFormat* totp_open_config_file(Storage* storage) {
             return NULL;
         }
 
-        flipper_format_write_header_cstr(fff_data_file, CONFIG_FILE_HEADER, CONFIG_FILE_ACTUAL_VERSION);
+        flipper_format_write_header_cstr(
+            fff_data_file, CONFIG_FILE_HEADER, CONFIG_FILE_ACTUAL_VERSION);
         float tmp_tz = 0;
         flipper_format_write_comment_cstr(fff_data_file, " ");
-        flipper_format_write_comment_cstr(fff_data_file, "Timezone offset in hours. Important note: do not put '+' sign for positive values");
+        flipper_format_write_comment_cstr(
+            fff_data_file,
+            "Timezone offset in hours. Important note: do not put '+' sign for positive values");
         flipper_format_write_float(fff_data_file, TOTP_CONFIG_KEY_TIMEZONE, &tmp_tz, 1);
         FuriString* temp_str = furi_string_alloc();
 
         flipper_format_write_comment_cstr(fff_data_file, " ");
         flipper_format_write_comment_cstr(fff_data_file, "=== TOKEN SAMPLE BEGIN ===");
         flipper_format_write_comment_cstr(fff_data_file, " ");
-        flipper_format_write_comment_cstr(fff_data_file, "# Token name which will be visible in the UI.");
+        flipper_format_write_comment_cstr(
+            fff_data_file, "# Token name which will be visible in the UI.");
         furi_string_printf(temp_str, "%s: Sample token name", TOTP_CONFIG_KEY_TOKEN_NAME);
         flipper_format_write_comment(fff_data_file, temp_str);
         flipper_format_write_comment_cstr(fff_data_file, " ");
 
-        flipper_format_write_comment_cstr(fff_data_file, "# Plain token secret without spaces, dashes and etc, just pure alpha-numeric characters. Important note: plain token will be encrypted and replaced by TOTP app");
+        flipper_format_write_comment_cstr(
+            fff_data_file,
+            "# Plain token secret without spaces, dashes and etc, just pure alpha-numeric characters. Important note: plain token will be encrypted and replaced by TOTP app");
         furi_string_printf(temp_str, "%s: plaintokensecret", TOTP_CONFIG_KEY_TOKEN_SECRET);
         flipper_format_write_comment(fff_data_file, temp_str);
         flipper_format_write_comment_cstr(fff_data_file, " ");
 
-        furi_string_printf(temp_str, " # Token hashing algorithm to use during code generation. Supported options are %s, %s and %s. If you are not use which one to use - use %s", TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME, TOTP_CONFIG_TOKEN_ALGO_SHA256_NAME, TOTP_CONFIG_TOKEN_ALGO_SHA512_NAME, TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
+        furi_string_printf(
+            temp_str,
+            " # Token hashing algorithm to use during code generation. Supported options are %s, %s and %s. If you are not use which one to use - use %s",
+            TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME,
+            TOTP_CONFIG_TOKEN_ALGO_SHA256_NAME,
+            TOTP_CONFIG_TOKEN_ALGO_SHA512_NAME,
+            TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
         flipper_format_write_comment(fff_data_file, temp_str);
-        furi_string_printf(temp_str, "%s: %s", TOTP_CONFIG_KEY_TOKEN_ALGO, TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
+        furi_string_printf(
+            temp_str, "%s: %s", TOTP_CONFIG_KEY_TOKEN_ALGO, TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
         flipper_format_write_comment(fff_data_file, temp_str);
         flipper_format_write_comment_cstr(fff_data_file, " ");
 
-        flipper_format_write_comment_cstr(fff_data_file, "# How many digits there should be in generated code. Available options are 6 and 8. Majority websites requires 6 digits code, however some rare websites wants to get 8 digits code. If you are not sure which one to use - use 6");
+        flipper_format_write_comment_cstr(
+            fff_data_file,
+            "# How many digits there should be in generated code. Available options are 6 and 8. Majority websites requires 6 digits code, however some rare websites wants to get 8 digits code. If you are not sure which one to use - use 6");
         furi_string_printf(temp_str, "%s: 6", TOTP_CONFIG_KEY_TOKEN_DIGITS);
         flipper_format_write_comment(fff_data_file, temp_str);
         flipper_format_write_comment_cstr(fff_data_file, " ");
@@ -132,8 +155,10 @@ FlipperFormat* totp_open_config_file(Storage* storage) {
 void totp_config_file_save_new_token_i(FlipperFormat* file, TokenInfo* token_info) {
     flipper_format_seek_to_end(file);
     flipper_format_write_string_cstr(file, TOTP_CONFIG_KEY_TOKEN_NAME, token_info->name);
-    flipper_format_write_hex(file, TOTP_CONFIG_KEY_TOKEN_SECRET, token_info->token, token_info->token_length);
+    flipper_format_write_hex(
-    flipper_format_write_string_cstr(file, TOTP_CONFIG_KEY_TOKEN_ALGO, token_info_get_algo_as_cstr(token_info));
+        file, TOTP_CONFIG_KEY_TOKEN_SECRET, token_info->token, token_info->token_length);
+    flipper_format_write_string_cstr(
+        file, TOTP_CONFIG_KEY_TOKEN_ALGO, token_info_get_algo_as_cstr(token_info));
     uint32_t digits_count_as_uint32 = token_info_get_digits_as_int(token_info);
     flipper_format_write_uint32(file, TOTP_CONFIG_KEY_TOKEN_DIGITS, &digits_count_as_uint32, 1);
 }
@@ -163,10 +188,17 @@ void totp_full_save_config_file(PluginState* const plugin_state) {
     FlipperFormat* fff_data_file = flipper_format_file_alloc(storage);
 
     flipper_format_file_open_always(fff_data_file, CONFIG_FILE_PATH);
-    flipper_format_write_header_cstr(fff_data_file, CONFIG_FILE_HEADER, CONFIG_FILE_ACTUAL_VERSION);
+    flipper_format_write_header_cstr(
-    flipper_format_write_hex(fff_data_file, TOTP_CONFIG_KEY_BASE_IV, &plugin_state->base_iv[0], TOTP_IV_SIZE);
+        fff_data_file, CONFIG_FILE_HEADER, CONFIG_FILE_ACTUAL_VERSION);
-    flipper_format_write_hex(fff_data_file, TOTP_CONFIG_KEY_CRYPTO_VERIFY, plugin_state->crypto_verify_data, plugin_state->crypto_verify_data_length);
+    flipper_format_write_hex(
-    flipper_format_write_float(fff_data_file, TOTP_CONFIG_KEY_TIMEZONE, &plugin_state->timezone_offset, 1);
+        fff_data_file, TOTP_CONFIG_KEY_BASE_IV, &plugin_state->base_iv[0], TOTP_IV_SIZE);
+    flipper_format_write_hex(
+        fff_data_file,
+        TOTP_CONFIG_KEY_CRYPTO_VERIFY,
+        plugin_state->crypto_verify_data,
+        plugin_state->crypto_verify_data_length);
+    flipper_format_write_float(
+        fff_data_file, TOTP_CONFIG_KEY_TIMEZONE, &plugin_state->timezone_offset, 1);
     flipper_format_write_bool(fff_data_file, TOTP_CONFIG_KEY_PINSET, &plugin_state->pin_set, 1);
     ListNode* node = plugin_state->tokens_list;
     while(node != NULL) {
@@ -195,7 +227,12 @@ void totp_config_file_load_base(PluginState* const plugin_state) {
     }
 
     if(file_version < CONFIG_FILE_ACTUAL_VERSION) {
-        FURI_LOG_I(LOGGING_TAG, "Obsolete config file version detected. Current version: %" PRIu32 "; Actual version: %" PRId16, file_version, CONFIG_FILE_ACTUAL_VERSION);
+        FURI_LOG_I(
+            LOGGING_TAG,
+            "Obsolete config file version detected. Current version: %" PRIu32
+            "; Actual version: %" PRId16,
+            file_version,
+            CONFIG_FILE_ACTUAL_VERSION);
         totp_close_config_file(fff_data_file);
 
         if(storage_common_stat(storage, CONFIG_FILE_BACKUP_PATH, NULL) == FSE_OK) {
@@ -220,21 +257,31 @@ void totp_config_file_load_base(PluginState* const plugin_state) {
             flipper_format_free(fff_backup_data_file);
             flipper_format_rewind(fff_data_file);
         } else {
-            FURI_LOG_E(LOGGING_TAG, "An error occurred during taking backup of %s into %s before migration", CONFIG_FILE_PATH, CONFIG_FILE_BACKUP_PATH);
+            FURI_LOG_E(
+                LOGGING_TAG,
+                "An error occurred during taking backup of %s into %s before migration",
+                CONFIG_FILE_PATH,
+                CONFIG_FILE_BACKUP_PATH);
         }
     }
 
-    if (!flipper_format_read_hex(fff_data_file, TOTP_CONFIG_KEY_BASE_IV, &plugin_state->base_iv[0], TOTP_IV_SIZE)) {
+    if(!flipper_format_read_hex(
+           fff_data_file, TOTP_CONFIG_KEY_BASE_IV, &plugin_state->base_iv[0], TOTP_IV_SIZE)) {
         FURI_LOG_D(LOGGING_TAG, "Missing base IV");
     }
 
     flipper_format_rewind(fff_data_file);
 
     uint32_t crypto_size;
-    if (flipper_format_get_value_count(fff_data_file, TOTP_CONFIG_KEY_CRYPTO_VERIFY, &crypto_size) && crypto_size > 0) {
+    if(flipper_format_get_value_count(fff_data_file, TOTP_CONFIG_KEY_CRYPTO_VERIFY, &crypto_size) &&
+       crypto_size > 0) {
         plugin_state->crypto_verify_data = malloc(sizeof(uint8_t) * crypto_size);
         plugin_state->crypto_verify_data_length = crypto_size;
-        if (!flipper_format_read_hex(fff_data_file, TOTP_CONFIG_KEY_CRYPTO_VERIFY, plugin_state->crypto_verify_data, crypto_size)) {
+        if(!flipper_format_read_hex(
+               fff_data_file,
+               TOTP_CONFIG_KEY_CRYPTO_VERIFY,
+               plugin_state->crypto_verify_data,
+               crypto_size)) {
             FURI_LOG_D(LOGGING_TAG, "Missing crypto verify token");
             free(plugin_state->crypto_verify_data);
             plugin_state->crypto_verify_data = NULL;
@@ -247,14 +294,16 @@ void totp_config_file_load_base(PluginState* const plugin_state) {
 
     flipper_format_rewind(fff_data_file);
 
-    if (!flipper_format_read_float(fff_data_file, TOTP_CONFIG_KEY_TIMEZONE, &plugin_state->timezone_offset, 1)) {
+    if(!flipper_format_read_float(
+           fff_data_file, TOTP_CONFIG_KEY_TIMEZONE, &plugin_state->timezone_offset, 1)) {
         plugin_state->timezone_offset = 0;
         FURI_LOG_D(LOGGING_TAG, "Missing timezone offset information, defaulting to 0");
     }
 
     flipper_format_rewind(fff_data_file);
 
-    if (!flipper_format_read_bool(fff_data_file, TOTP_CONFIG_KEY_PINSET, &plugin_state->pin_set, 1)) {
+    if(!flipper_format_read_bool(
+           fff_data_file, TOTP_CONFIG_KEY_PINSET, &plugin_state->pin_set, 1)) {
         plugin_state->pin_set = true;
     }
 
@@ -291,7 +340,8 @@ void totp_config_file_load_tokens(PluginState* const plugin_state) {
         strcpy(tokenInfo->name, temp_cstr);
 
         uint32_t secret_bytes_count;
-        if (!flipper_format_get_value_count(fff_data_file, TOTP_CONFIG_KEY_TOKEN_SECRET, &secret_bytes_count)) {
+        if(!flipper_format_get_value_count(
+               fff_data_file, TOTP_CONFIG_KEY_TOKEN_SECRET, &secret_bytes_count)) {
             token_info_free(tokenInfo);
             continue;
         }
@@ -309,7 +359,11 @@ void totp_config_file_load_tokens(PluginState* const plugin_state) {
         } else { // encrypted
             tokenInfo->token_length = secret_bytes_count;
             tokenInfo->token = malloc(tokenInfo->token_length);
-            if (!flipper_format_read_hex(fff_data_file, TOTP_CONFIG_KEY_TOKEN_SECRET, tokenInfo->token, tokenInfo->token_length)) {
+            if(!flipper_format_read_hex(
+                   fff_data_file,
+                   TOTP_CONFIG_KEY_TOKEN_SECRET,
+                   tokenInfo->token,
+                   tokenInfo->token_length)) {
                 token_info_free(tokenInfo);
                 continue;
             }
@@ -322,7 +376,8 @@ void totp_config_file_load_tokens(PluginState* const plugin_state) {
 
         token_info_set_algo_from_str(tokenInfo, temp_str);
 
-        if (!flipper_format_read_uint32(fff_data_file, TOTP_CONFIG_KEY_TOKEN_DIGITS, &temp_data32, 1)) {
+        if(!flipper_format_read_uint32(
+               fff_data_file, TOTP_CONFIG_KEY_TOKEN_DIGITS, &temp_data32, 1)) {
             token_info_free(tokenInfo);
             continue;
         }

applications/plugins/totp/services/config/migrations/config_migration_v1_to_v2.c

@@ -4,7 +4,9 @@
 
 #define NEW_VERSION 2
 
-bool totp_config_migrate_v1_to_v2(FlipperFormat* fff_data_file, FlipperFormat* fff_backup_data_file) {
+bool totp_config_migrate_v1_to_v2(
+    FlipperFormat* fff_data_file,
+    FlipperFormat* fff_backup_data_file) {
     flipper_format_write_header_cstr(fff_data_file, CONFIG_FILE_HEADER, NEW_VERSION);
 
     FuriString* temp_str = furi_string_alloc();
@@ -22,7 +24,8 @@ bool totp_config_migrate_v1_to_v2(FlipperFormat* fff_data_file, FlipperFormat* f
     }
 
     while(true) {
-        if (!flipper_format_read_string(fff_backup_data_file, TOTP_CONFIG_KEY_TOKEN_NAME, temp_str)) {
+        if(!flipper_format_read_string(
+               fff_backup_data_file, TOTP_CONFIG_KEY_TOKEN_NAME, temp_str)) {
             break;
         }
 
@@ -31,9 +34,11 @@ bool totp_config_migrate_v1_to_v2(FlipperFormat* fff_data_file, FlipperFormat* f
         flipper_format_read_string(fff_backup_data_file, TOTP_CONFIG_KEY_TOKEN_SECRET, temp_str);
         flipper_format_write_string(fff_data_file, TOTP_CONFIG_KEY_TOKEN_SECRET, temp_str);
 
-        flipper_format_write_string_cstr(fff_data_file, TOTP_CONFIG_KEY_TOKEN_ALGO, TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
+        flipper_format_write_string_cstr(
+            fff_data_file, TOTP_CONFIG_KEY_TOKEN_ALGO, TOTP_CONFIG_TOKEN_ALGO_SHA1_NAME);
         uint32_t default_digits = 6;
-        flipper_format_write_uint32(fff_data_file, TOTP_CONFIG_KEY_TOKEN_DIGITS, &default_digits, 1);
+        flipper_format_write_uint32(
+            fff_data_file, TOTP_CONFIG_KEY_TOKEN_DIGITS, &default_digits, 1);
     }
 
     furi_string_free(temp_str);

applications/plugins/totp/services/config/migrations/config_migration_v1_to_v2.h

@@ -2,4 +2,6 @@
 
 #include <flipper_format/flipper_format.h>
 
-bool totp_config_migrate_v1_to_v2(FlipperFormat* fff_data_file, FlipperFormat* fff_backup_data_file);
+bool totp_config_migrate_v1_to_v2(
+    FlipperFormat* fff_data_file,
+    FlipperFormat* fff_backup_data_file);

applications/plugins/totp/services/crypto/crypto.c

@@ -9,7 +9,11 @@
 #define CRYPTO_VERIFY_KEY_LENGTH 16
 #define CRYPTO_ALIGNMENT_FACTOR 16
 
-uint8_t* totp_crypto_encrypt(const uint8_t* plain_data, const uint8_t plain_data_length, const uint8_t* iv, uint8_t* encrypted_data_length) {
+uint8_t* totp_crypto_encrypt(
+    const uint8_t* plain_data,
+    const uint8_t plain_data_length,
+    const uint8_t* iv,
+    uint8_t* encrypted_data_length) {
     uint8_t* encrypted_data;
     size_t remain = plain_data_length % CRYPTO_ALIGNMENT_FACTOR;
     if(remain) {
@@ -39,7 +43,11 @@ uint8_t* totp_crypto_encrypt(const uint8_t* plain_data, const uint8_t plain_data
     return encrypted_data;
 }
 
-uint8_t* totp_crypto_decrypt(const uint8_t* encrypted_data, const uint8_t encrypted_data_length, const uint8_t* iv, uint8_t* decrypted_data_length) {
+uint8_t* totp_crypto_decrypt(
+    const uint8_t* encrypted_data,
+    const uint8_t encrypted_data_length,
+    const uint8_t* iv,
+    uint8_t* decrypted_data_length) {
     *decrypted_data_length = encrypted_data_length;
     uint8_t* decrypted_data = malloc(*decrypted_data_length);
     furi_hal_crypto_store_load_key(CRYPTO_KEY_SLOT, iv);
@@ -88,12 +96,22 @@ void totp_crypto_seed_iv(PluginState* plugin_state, uint8_t* pin, uint8_t pin_le
         Storage* storage = totp_open_storage();
         FlipperFormat* config_file = totp_open_config_file(storage);
 
-        plugin_state->crypto_verify_data = totp_crypto_encrypt((uint8_t* )CRYPTO_VERIFY_KEY, CRYPTO_VERIFY_KEY_LENGTH, &plugin_state->iv[0], &plugin_state->crypto_verify_data_length);
+        plugin_state->crypto_verify_data = totp_crypto_encrypt(
+            (uint8_t*)CRYPTO_VERIFY_KEY,
+            CRYPTO_VERIFY_KEY_LENGTH,
+            &plugin_state->iv[0],
+            &plugin_state->crypto_verify_data_length);
 
-        flipper_format_insert_or_update_hex(config_file, TOTP_CONFIG_KEY_BASE_IV, plugin_state->base_iv, TOTP_IV_SIZE);
+        flipper_format_insert_or_update_hex(
-        flipper_format_insert_or_update_hex(config_file, TOTP_CONFIG_KEY_CRYPTO_VERIFY, plugin_state->crypto_verify_data, CRYPTO_VERIFY_KEY_LENGTH);
+            config_file, TOTP_CONFIG_KEY_BASE_IV, plugin_state->base_iv, TOTP_IV_SIZE);
+        flipper_format_insert_or_update_hex(
+            config_file,
+            TOTP_CONFIG_KEY_CRYPTO_VERIFY,
+            plugin_state->crypto_verify_data,
+            CRYPTO_VERIFY_KEY_LENGTH);
         plugin_state->pin_set = pin != NULL && pin_length > 0;
-        flipper_format_insert_or_update_bool(config_file, TOTP_CONFIG_KEY_PINSET, &plugin_state->pin_set, 1);
+        flipper_format_insert_or_update_bool(
+            config_file, TOTP_CONFIG_KEY_PINSET, &plugin_state->pin_set, 1);
         totp_close_config_file(config_file);
         totp_close_storage();
     }
@@ -101,7 +119,11 @@ void totp_crypto_seed_iv(PluginState* plugin_state, uint8_t* pin, uint8_t pin_le
 
 bool totp_crypto_verify_key(const PluginState* plugin_state) {
     uint8_t decrypted_key_length;
-    uint8_t* decrypted_key = totp_crypto_decrypt(plugin_state->crypto_verify_data, plugin_state->crypto_verify_data_length, &plugin_state->iv[0], &decrypted_key_length);
+    uint8_t* decrypted_key = totp_crypto_decrypt(
+        plugin_state->crypto_verify_data,
+        plugin_state->crypto_verify_data_length,
+        &plugin_state->iv[0],
+        &decrypted_key_length);
 
     bool key_valid = true;
     for(uint8_t i = 0; i < CRYPTO_VERIFY_KEY_LENGTH && key_valid; i++) {

applications/plugins/totp/services/crypto/crypto.h

@@ -2,7 +2,15 @@
 
 #include "../../types/plugin_state.h"
 
-uint8_t* totp_crypto_encrypt(const uint8_t* plain_data, const uint8_t plain_data_length, const uint8_t* iv, uint8_t* encrypted_data_length);
+uint8_t* totp_crypto_encrypt(
-uint8_t* totp_crypto_decrypt(const uint8_t* encrypted_data, const uint8_t encrypted_data_length, const uint8_t* iv, uint8_t* decrypted_data_length);
+    const uint8_t* plain_data,
+    const uint8_t plain_data_length,
+    const uint8_t* iv,
+    uint8_t* encrypted_data_length);
+uint8_t* totp_crypto_decrypt(
+    const uint8_t* encrypted_data,
+    const uint8_t encrypted_data_length,
+    const uint8_t* iv,
+    uint8_t* decrypted_data_length);
 void totp_crypto_seed_iv(PluginState* plugin_state, uint8_t* pin, uint8_t pin_length);
 bool totp_crypto_verify_key(const PluginState* plugin_state);

applications/plugins/totp/services/hmac/byteswap.c

@@ -1,13 +1,11 @@
 #include "byteswap.h"
 
-uint32_t swap_uint32( uint32_t val )
+uint32_t swap_uint32(uint32_t val) {
-{
     val = ((val << 8) & 0xFF00FF00) | ((val >> 8) & 0xFF00FF);
     return (val << 16) | (val >> 16);
 }
 
-uint64_t swap_uint64( uint64_t val )
+uint64_t swap_uint64(uint64_t val) {
-{
     val = ((val << 8) & 0xFF00FF00FF00FF00ULL) | ((val >> 8) & 0x00FF00FF00FF00FFULL);
     val = ((val << 16) & 0xFFFF0000FFFF0000ULL) | ((val >> 16) & 0x0000FFFF0000FFFFULL);
     return (val << 32) | (val >> 32);

applications/plugins/totp/services/hmac/hmac_common.h

@@ -0,0 +1,64 @@
+#include <string.h>
+#include "sha256.h"
+#include "memxor.h"
+
+#define IPAD 0x36
+#define OPAD 0x5c
+
+/* Concatenate two preprocessor tokens.  */
+#define _GLHMAC_CONCAT_(prefix, suffix) prefix##suffix
+#define _GLHMAC_CONCAT(prefix, suffix) _GLHMAC_CONCAT_(prefix, suffix)
+
+#if GL_HMAC_NAME == 5
+#define HMAC_ALG md5
+#else
+#define HMAC_ALG _GLHMAC_CONCAT(sha, GL_HMAC_NAME)
+#endif
+
+#define GL_HMAC_CTX _GLHMAC_CONCAT(HMAC_ALG, _ctx)
+#define GL_HMAC_FN _GLHMAC_CONCAT(hmac_, HMAC_ALG)
+#define GL_HMAC_FN_INIT _GLHMAC_CONCAT(HMAC_ALG, _init_ctx)
+#define GL_HMAC_FN_BLOC _GLHMAC_CONCAT(HMAC_ALG, _process_block)
+#define GL_HMAC_FN_PROC _GLHMAC_CONCAT(HMAC_ALG, _process_bytes)
+#define GL_HMAC_FN_FINI _GLHMAC_CONCAT(HMAC_ALG, _finish_ctx)
+
+static void
+    hmac_hash(const void* key, size_t keylen, const void* in, size_t inlen, int pad, void* resbuf) {
+    struct GL_HMAC_CTX hmac_ctx;
+    char block[GL_HMAC_BLOCKSIZE];
+
+    memset(block, pad, sizeof block);
+    memxor(block, key, keylen);
+
+    GL_HMAC_FN_INIT(&hmac_ctx);
+    GL_HMAC_FN_BLOC(block, sizeof block, &hmac_ctx);
+    GL_HMAC_FN_PROC(in, inlen, &hmac_ctx);
+    GL_HMAC_FN_FINI(&hmac_ctx, resbuf);
+}
+
+int GL_HMAC_FN(const void* key, size_t keylen, const void* in, size_t inlen, void* resbuf) {
+    char optkeybuf[GL_HMAC_HASHSIZE];
+    char innerhash[GL_HMAC_HASHSIZE];
+
+    /* Ensure key size is <= block size.  */
+    if(keylen > GL_HMAC_BLOCKSIZE) {
+        struct GL_HMAC_CTX keyhash;
+
+        GL_HMAC_FN_INIT(&keyhash);
+        GL_HMAC_FN_PROC(key, keylen, &keyhash);
+        GL_HMAC_FN_FINI(&keyhash, optkeybuf);
+
+        key = optkeybuf;
+        /* zero padding of the key to the block size
+         is implicit in the memxor.  */
+        keylen = sizeof optkeybuf;
+    }
+
+    /* Compute INNERHASH from KEY and IN.  */
+    hmac_hash(key, keylen, in, inlen, IPAD, innerhash);
+
+    /* Compute result from KEY and INNERHASH.  */
+    hmac_hash(key, keylen, innerhash, sizeof innerhash, OPAD, resbuf);
+
+    return 0;
+}

applications/plugins/totp/services/hmac/hmac_sha1.c

@@ -0,0 +1,24 @@
+/* hmac_sha1.c -- hashed message authentication codes
+   Copyright (C) 2018-2022 Free Software Foundation, Inc.
+
+   This file is free software: you can redistribute it and/or modify
+   it under the terms of the GNU Lesser General Public License as
+   published by the Free Software Foundation; either version 2.1 of the
+   License, or (at your option) any later version.
+
+   This file is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public License
+   along with this program.  If not, see <https://www.gnu.org/licenses/>.  */
+
+#include "hmac_sha1.h"
+
+#include "sha1.h"
+
+#define GL_HMAC_NAME 1
+#define GL_HMAC_BLOCKSIZE 64
+#define GL_HMAC_HASHSIZE 20
+#include "hmac_common.h"

applications/plugins/totp/services/hmac/hmac_sha1.h

@@ -0,0 +1,11 @@
+#pragma once
+
+#include <stddef.h>
+
+#define HMAC_SHA1_RESULT_SIZE 20
+
+/* Compute Hashed Message Authentication Code with SHA-1, over BUFFER
+   data of BUFLEN bytes using the KEY of KEYLEN bytes, writing the
+   output to pre-allocated 20 byte minimum RESBUF buffer.  Return 0 on
+   success.  */
+int hmac_sha1(const void* key, size_t keylen, const void* in, size_t inlen, void* restrict resbuf);

applications/plugins/totp/services/hmac/hmac_sha256.c

@@ -0,0 +1,23 @@
+/* hmac_sha256.c -- hashed message authentication codes
+   Copyright (C) 2018-2022 Free Software Foundation, Inc.
+
+   This file is free software: you can redistribute it and/or modify
+   it under the terms of the GNU Lesser General Public License as
+   published by the Free Software Foundation; either version 2.1 of the
+   License, or (at your option) any later version.
+
+   This file is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public License
+   along with this program.  If not, see <https://www.gnu.org/licenses/>.  */
+
+#include "hmac_sha256.h"
+
+#define GL_HMAC_NAME 256
+#define GL_HMAC_BLOCKSIZE 64
+#define GL_HMAC_HASHSIZE 32
+
+#include "hmac_common.h"

applications/plugins/totp/services/hmac/hmac_sha256.h

@@ -0,0 +1,11 @@
+#pragma once
+
+#include <stddef.h>
+
+#define HMAC_SHA256_RESULT_SIZE 32
+
+/* Compute Hashed Message Authentication Code with SHA-256, over BUFFER
+   data of BUFLEN bytes using the KEY of KEYLEN bytes, writing the
+   output to pre-allocated 32 byte minimum RESBUF buffer.  Return 0 on
+   success.  */
+int hmac_sha256(const void* key, size_t keylen, const void* in, size_t inlen, void* restrict resbuf);

applications/plugins/totp/services/hmac/hmac_sha512.c

@@ -0,0 +1,24 @@
+/* hmac_sha512.c -- hashed message authentication codes
+   Copyright (C) 2018-2022 Free Software Foundation, Inc.
+
+   This file is free software: you can redistribute it and/or modify
+   it under the terms of the GNU Lesser General Public License as
+   published by the Free Software Foundation; either version 2.1 of the
+   License, or (at your option) any later version.
+
+   This file is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public License
+   along with this program.  If not, see <https://www.gnu.org/licenses/>.  */
+
+#include "hmac_sha512.h"
+
+#include "sha512.h"
+
+#define GL_HMAC_NAME 512
+#define GL_HMAC_BLOCKSIZE 128
+#define GL_HMAC_HASHSIZE 64
+#include "hmac_common.h"

applications/plugins/totp/services/hmac/hmac_sha512.h

@@ -0,0 +1,11 @@
+#pragma once
+
+#include <stddef.h>
+
+#define HMAC_SHA512_RESULT_SIZE 64
+
+/* Compute Hashed Message Authentication Code with SHA-512, over BUFFER
+   data of BUFLEN bytes using the KEY of KEYLEN bytes, writing the
+   output to pre-allocated 64 byte minimum RESBUF buffer.  Return 0 on
+   success.  */
+int hmac_sha512(const void* key, size_t keylen, const void* in, size_t inlen, void* restrict resbuf);

applications/plugins/totp/services/hmac/memxor.c

@@ -22,13 +22,11 @@
 
 #include "memxor.h"
 
-void* memxor (void */*restrict*/ dest, const void */*restrict*/ src, size_t n)
+void* memxor(void* /*restrict*/ dest, const void* /*restrict*/ src, size_t n) {
-{
     char const* s = (char const*)src;
     char* d = (char*)dest;
 
-  for (; n > 0; n--)
+    for(; n > 0; n--) *d++ ^= *s++;
-    *d++ ^= *s++;
 
     return dest;
 }

applications/plugins/totp/services/hmac/sha1.c

@@ -43,13 +43,10 @@
    64-byte boundary.  (RFC 1321, 3.1: Step 1)  */
 static const unsigned char fillbuf[64] = {0x80, 0 /* , 0, 0, ...  */};
 
-
 /* Take a pointer to a 160 bit block of data (five 32 bit ints) and
    initialize it to the start constants of the SHA1 algorithm.  This
    must be called before using hash in the call to sha1_hash.  */
-void
+void sha1_init_ctx(struct sha1_ctx* ctx) {
-sha1_init_ctx (struct sha1_ctx *ctx)
-{
     ctx->A = 0x67452301;
     ctx->B = 0xefcdab89;
     ctx->C = 0x98badcfe;
@@ -63,17 +60,13 @@ sha1_init_ctx (struct sha1_ctx *ctx)
 /* Copy the 4 byte value from v into the memory location pointed to by *cp,
    If your architecture allows unaligned access this is equivalent to
    * (uint32_t *) cp = v  */
-static void
+static void set_uint32(char* cp, uint32_t v) {
-set_uint32 (char *cp, uint32_t v)
-{
     memcpy(cp, &v, sizeof v);
 }
 
 /* Put result from CTX in first 20 bytes following RESBUF.  The result
    must be in little endian byte order.  */
-void *
+void* sha1_read_ctx(const struct sha1_ctx* ctx, void* resbuf) {
-sha1_read_ctx (const struct sha1_ctx *ctx, void *resbuf)
-{
     char* r = resbuf;
     set_uint32(r + 0 * sizeof ctx->A, SWAP(ctx->A));
     set_uint32(r + 1 * sizeof ctx->B, SWAP(ctx->B));
@@ -86,17 +79,14 @@ sha1_read_ctx (const struct sha1_ctx *ctx, void *resbuf)
 
 /* Process the remaining bytes in the internal buffer and the usual
    prolog according to the standard and write the result to RESBUF.  */
-void *
+void* sha1_finish_ctx(struct sha1_ctx* ctx, void* resbuf) {
-sha1_finish_ctx (struct sha1_ctx *ctx, void *resbuf)
-{
     /* Take yet unprocessed bytes into account.  */
     uint32_t bytes = ctx->buflen;
     size_t size = (bytes < 56) ? 64 / 4 : 64 * 2 / 4;
 
     /* Now count remaining bytes.  */
     ctx->total[0] += bytes;
-  if (ctx->total[0] < bytes)
+    if(ctx->total[0] < bytes) ++ctx->total[1];
-    ++ctx->total[1];
 
     /* Put the 64-bit file length in *bits* at the end of the buffer.  */
     ctx->buffer[size - 2] = SWAP((ctx->total[1] << 3) | (ctx->total[0] >> 29));
@@ -114,9 +104,7 @@ sha1_finish_ctx (struct sha1_ctx *ctx, void *resbuf)
    result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-void *
+void* sha1_buffer(const char* buffer, size_t len, void* resblock) {
-sha1_buffer (const char *buffer, size_t len, void *resblock)
-{
     struct sha1_ctx ctx;
 
     /* Initialize the computation context.  */
@@ -129,29 +117,23 @@ sha1_buffer (const char *buffer, size_t len, void *resblock)
     return sha1_finish_ctx(&ctx, resblock);
 }
 
-void
+void sha1_process_bytes(const void* buffer, size_t len, struct sha1_ctx* ctx) {
-sha1_process_bytes (const void *buffer, size_t len, struct sha1_ctx *ctx)
-{
     /* When we already have some bits in our internal buffer concatenate
      both inputs first.  */
-  if (ctx->buflen != 0)
+    if(ctx->buflen != 0) {
-    {
         size_t left_over = ctx->buflen;
         size_t add = 128 - left_over > len ? len : 128 - left_over;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, add);
         ctx->buflen += add;
 
-      if (ctx->buflen > 64)
+        if(ctx->buflen > 64) {
-        {
             sha1_process_block(ctx->buffer, ctx->buflen & ~63, ctx);
 
             ctx->buflen &= 63;
             /* The regions in the following copy operation cannot overlap,
              because ctx->buflen < 64 ≤ (left_over + add) & ~63.  */
-          memcpy (ctx->buffer,
+            memcpy(ctx->buffer, &((char*)ctx->buffer)[(left_over + add) & ~63], ctx->buflen);
-                  &((char *) ctx->buffer)[(left_over + add) & ~63],
-                  ctx->buflen);
         }
 
         buffer = (const char*)buffer + add;
@@ -159,13 +141,11 @@ sha1_process_bytes (const void *buffer, size_t len, struct sha1_ctx *ctx)
     }
 
     /* Process available complete blocks.  */
-  if (len >= 64)
+    if(len >= 64) {
-    {
 #if !(_STRING_ARCH_unaligned || _STRING_INLINE_unaligned)
 #define UNALIGNED_P(p) ((uintptr_t)(p) % sizeof(uint32_t) != 0)
         if(UNALIGNED_P(buffer))
-        while (len > 64)
+            while(len > 64) {
-          {
                 sha1_process_block(memcpy(ctx->buffer, buffer, 64), 64, ctx);
                 buffer = (const char*)buffer + 64;
                 len -= 64;
@@ -180,14 +160,12 @@ sha1_process_bytes (const void *buffer, size_t len, struct sha1_ctx *ctx)
     }
 
     /* Move remaining bytes in internal buffer.  */
-  if (len > 0)
+    if(len > 0) {
-    {
         size_t left_over = ctx->buflen;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, len);
         left_over += len;
-      if (left_over >= 64)
+        if(left_over >= 64) {
-        {
             sha1_process_block(ctx->buffer, 64, ctx);
             left_over -= 64;
             /* The regions in the following copy operation cannot overlap,
@@ -216,9 +194,7 @@ sha1_process_bytes (const void *buffer, size_t len, struct sha1_ctx *ctx)
    It is assumed that LEN % 64 == 0.
    Most of this code comes from GnuPG's cipher/sha1.c.  */
 
-void
+void sha1_process_block(const void* buffer, size_t len, struct sha1_ctx* ctx) {
-sha1_process_block (const void *buffer, size_t len, struct sha1_ctx *ctx)
-{
     const uint32_t* words = buffer;
     size_t nwords = len / sizeof(uint32_t);
     const uint32_t* endp = words + nwords;
@@ -238,23 +214,20 @@ sha1_process_block (const void *buffer, size_t len, struct sha1_ctx *ctx)
 
 #define rol(x, n) (((x) << (n)) | ((uint32_t)(x) >> (32 - (n))))
 
-#define M(I) ( tm =   x[I&0x0f] ^ x[(I-14)&0x0f] \
+#define M(I)                                                                        \
-                    ^ x[(I-8)&0x0f] ^ x[(I-3)&0x0f] \
+    (tm = x[I & 0x0f] ^ x[(I - 14) & 0x0f] ^ x[(I - 8) & 0x0f] ^ x[(I - 3) & 0x0f], \
-               , (x[I&0x0f] = rol(tm, 1)) )
+     (x[I & 0x0f] = rol(tm, 1)))
 
-#define R(A,B,C,D,E,F,K,M)  do { E += rol( A, 5 )     \
+#define R(A, B, C, D, E, F, K, M)            \
-                                      + F( B, C, D )  \
+    do {                                     \
-                                      + K             \
+        E += rol(A, 5) + F(B, C, D) + K + M; \
-                                      + M;            \
         B = rol(B, 30);                      \
     } while(0)
 
-  while (words < endp)
+    while(words < endp) {
-    {
         uint32_t tm;
         int t;
-      for (t = 0; t < 16; t++)
+        for(t = 0; t < 16; t++) {
-        {
             x[t] = SWAP(*words);
             words++;
         }

applications/plugins/totp/services/hmac/sha1.h

@@ -39,8 +39,7 @@ extern "C" {
 #include "gl_openssl.h"
 #else
 /* Structure to save state of computation between the single steps.  */
-struct sha1_ctx
+struct sha1_ctx {
-{
     uint32_t A;
     uint32_t B;
     uint32_t C;
@@ -59,15 +58,13 @@ extern void sha1_init_ctx (struct sha1_ctx *ctx);
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is necessary that LEN is a multiple of 64!!! */
-extern void sha1_process_block (const void *buffer, size_t len,
+extern void sha1_process_block(const void* buffer, size_t len, struct sha1_ctx* ctx);
-                                struct sha1_ctx *ctx);
 
 /* Starting with the result of former calls of this function (or the
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is NOT required that LEN is a multiple of 64.  */
-extern void sha1_process_bytes (const void *buffer, size_t len,
+extern void sha1_process_bytes(const void* buffer, size_t len, struct sha1_ctx* ctx);
-                                struct sha1_ctx *ctx);
 
 /* Process the remaining bytes in the buffer and put result from CTX
    in first 20 bytes following RESBUF.  The result is always in little
@@ -75,19 +72,16 @@ extern void sha1_process_bytes (const void *buffer, size_t len,
    ASCII representation of the message digest.  */
 extern void* sha1_finish_ctx(struct sha1_ctx* ctx, void* restrict resbuf);
 
-
 /* Put result from CTX in first 20 bytes following RESBUF.  The result is
    always in little endian byte order, so that a byte-wise output yields
    to the wanted ASCII representation of the message digest.  */
 extern void* sha1_read_ctx(const struct sha1_ctx* ctx, void* restrict resbuf);
 
-
 /* Compute SHA1 message digest for LEN bytes beginning at BUFFER.  The
    result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-extern void *sha1_buffer (const char *buffer, size_t len,
+extern void* sha1_buffer(const char* buffer, size_t len, void* restrict resblock);
-                          void *restrict resblock);
 
 #endif
 
@@ -99,7 +93,6 @@ extern void *sha1_buffer (const char *buffer, size_t len,
    beginning at RESBLOCK.  */
 extern int sha1_stream(FILE* stream, void* resblock);
 
-
 #ifdef __cplusplus
 }
 #endif

applications/plugins/totp/services/hmac/sha256.c

@@ -42,15 +42,12 @@
    64-byte boundary.  */
 static const unsigned char fillbuf[64] = {0x80, 0 /* , 0, 0, ...  */};
 
-
 /*
   Takes a pointer to a 256 bit block of data (eight 32 bit ints) and
   initializes it to the start constants of the SHA256 algorithm.  This
   must be called before using hash in the call to sha256_hash
 */
-void
+void sha256_init_ctx(struct sha256_ctx* ctx) {
-sha256_init_ctx (struct sha256_ctx *ctx)
-{
     ctx->state[0] = 0x6a09e667UL;
     ctx->state[1] = 0xbb67ae85UL;
     ctx->state[2] = 0x3c6ef372UL;
@@ -64,9 +61,7 @@ sha256_init_ctx (struct sha256_ctx *ctx)
     ctx->buflen = 0;
 }
 
-void
+void sha224_init_ctx(struct sha256_ctx* ctx) {
-sha224_init_ctx (struct sha256_ctx *ctx)
-{
     ctx->state[0] = 0xc1059ed8UL;
     ctx->state[1] = 0x367cd507UL;
     ctx->state[2] = 0x3070dd17UL;
@@ -83,59 +78,46 @@ sha224_init_ctx (struct sha256_ctx *ctx)
 /* Copy the value from v into the memory location pointed to by *CP,
    If your architecture allows unaligned access, this is equivalent to
    * (__typeof__ (v) *) cp = v  */
-static void
+static void set_uint32(char* cp, uint32_t v) {
-set_uint32 (char *cp, uint32_t v)
-{
     memcpy(cp, &v, sizeof v);
 }
 
 /* Put result from CTX in first 32 bytes following RESBUF.
    The result must be in little endian byte order.  */
-void *
+void* sha256_read_ctx(const struct sha256_ctx* ctx, void* resbuf) {
-sha256_read_ctx (const struct sha256_ctx *ctx, void *resbuf)
-{
     int i;
     char* r = resbuf;
 
-  for (i = 0; i < 8; i++)
+    for(i = 0; i < 8; i++) set_uint32(r + i * sizeof ctx->state[0], SWAP(ctx->state[i]));
-    set_uint32 (r + i * sizeof ctx->state[0], SWAP (ctx->state[i]));
 
     return resbuf;
 }
 
-void *
+void* sha224_read_ctx(const struct sha256_ctx* ctx, void* resbuf) {
-sha224_read_ctx (const struct sha256_ctx *ctx, void *resbuf)
-{
     int i;
     char* r = resbuf;
 
-  for (i = 0; i < 7; i++)
+    for(i = 0; i < 7; i++) set_uint32(r + i * sizeof ctx->state[0], SWAP(ctx->state[i]));
-    set_uint32 (r + i * sizeof ctx->state[0], SWAP (ctx->state[i]));
 
     return resbuf;
 }
 
 /* Process the remaining bytes in the internal buffer and the usual
    prolog according to the standard and write the result to RESBUF.  */
-static void
+static void sha256_conclude_ctx(struct sha256_ctx* ctx) {
-sha256_conclude_ctx (struct sha256_ctx *ctx)
-{
     /* Take yet unprocessed bytes into account.  */
     size_t bytes = ctx->buflen;
     size_t size = (bytes < 56) ? 64 / 4 : 64 * 2 / 4;
 
     /* Now count remaining bytes.  */
     ctx->total[0] += bytes;
-  if (ctx->total[0] < bytes)
+    if(ctx->total[0] < bytes) ++ctx->total[1];
-    ++ctx->total[1];
 
     /* Put the 64-bit file length in *bits* at the end of the buffer.
      Use set_uint32 rather than a simple assignment, to avoid risk of
      unaligned access.  */
-  set_uint32 ((char *) &ctx->buffer[size - 2],
+    set_uint32((char*)&ctx->buffer[size - 2], SWAP((ctx->total[1] << 3) | (ctx->total[0] >> 29)));
-              SWAP ((ctx->total[1] << 3) | (ctx->total[0] >> 29)));
+    set_uint32((char*)&ctx->buffer[size - 1], SWAP(ctx->total[0] << 3));
-  set_uint32 ((char *) &ctx->buffer[size - 1],
-              SWAP (ctx->total[0] << 3));
 
     memcpy(&((char*)ctx->buffer)[bytes], fillbuf, (size - 2) * 4 - bytes);
 
@@ -143,16 +125,12 @@ sha256_conclude_ctx (struct sha256_ctx *ctx)
     sha256_process_block(ctx->buffer, size * 4, ctx);
 }
 
-void *
+void* sha256_finish_ctx(struct sha256_ctx* ctx, void* resbuf) {
-sha256_finish_ctx (struct sha256_ctx *ctx, void *resbuf)
-{
     sha256_conclude_ctx(ctx);
     return sha256_read_ctx(ctx, resbuf);
 }
 
-void *
+void* sha224_finish_ctx(struct sha256_ctx* ctx, void* resbuf) {
-sha224_finish_ctx (struct sha256_ctx *ctx, void *resbuf)
-{
     sha256_conclude_ctx(ctx);
     return sha224_read_ctx(ctx, resbuf);
 }
@@ -161,9 +139,7 @@ sha224_finish_ctx (struct sha256_ctx *ctx, void *resbuf)
    result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-void *
+void* sha256_buffer(const char* buffer, size_t len, void* resblock) {
-sha256_buffer (const char *buffer, size_t len, void *resblock)
-{
     struct sha256_ctx ctx;
 
     /* Initialize the computation context.  */
@@ -176,9 +152,7 @@ sha256_buffer (const char *buffer, size_t len, void *resblock)
     return sha256_finish_ctx(&ctx, resblock);
 }
 
-void *
+void* sha224_buffer(const char* buffer, size_t len, void* resblock) {
-sha224_buffer (const char *buffer, size_t len, void *resblock)
-{
     struct sha256_ctx ctx;
 
     /* Initialize the computation context.  */
@@ -191,29 +165,23 @@ sha224_buffer (const char *buffer, size_t len, void *resblock)
     return sha224_finish_ctx(&ctx, resblock);
 }
 
-void
+void sha256_process_bytes(const void* buffer, size_t len, struct sha256_ctx* ctx) {
-sha256_process_bytes (const void *buffer, size_t len, struct sha256_ctx *ctx)
-{
     /* When we already have some bits in our internal buffer concatenate
      both inputs first.  */
-  if (ctx->buflen != 0)
+    if(ctx->buflen != 0) {
-    {
         size_t left_over = ctx->buflen;
         size_t add = 128 - left_over > len ? len : 128 - left_over;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, add);
         ctx->buflen += add;
 
-      if (ctx->buflen > 64)
+        if(ctx->buflen > 64) {
-        {
             sha256_process_block(ctx->buffer, ctx->buflen & ~63, ctx);
 
             ctx->buflen &= 63;
             /* The regions in the following copy operation cannot overlap,
              because ctx->buflen < 64 ≤ (left_over + add) & ~63.  */
-          memcpy (ctx->buffer,
+            memcpy(ctx->buffer, &((char*)ctx->buffer)[(left_over + add) & ~63], ctx->buflen);
-                  &((char *) ctx->buffer)[(left_over + add) & ~63],
-                  ctx->buflen);
         }
 
         buffer = (const char*)buffer + add;
@@ -221,13 +189,11 @@ sha256_process_bytes (const void *buffer, size_t len, struct sha256_ctx *ctx)
     }
 
     /* Process available complete blocks.  */
-  if (len >= 64)
+    if(len >= 64) {
-    {
 #if !(_STRING_ARCH_unaligned || _STRING_INLINE_unaligned)
 #define UNALIGNED_P(p) ((uintptr_t)(p) % sizeof(uint32_t) != 0)
         if(UNALIGNED_P(buffer))
-        while (len > 64)
+            while(len > 64) {
-          {
                 sha256_process_block(memcpy(ctx->buffer, buffer, 64), 64, ctx);
                 buffer = (const char*)buffer + 64;
                 len -= 64;
@@ -242,14 +208,12 @@ sha256_process_bytes (const void *buffer, size_t len, struct sha256_ctx *ctx)
     }
 
     /* Move remaining bytes in internal buffer.  */
-  if (len > 0)
+    if(len > 0) {
-    {
         size_t left_over = ctx->buflen;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, len);
         left_over += len;
-      if (left_over >= 64)
+        if(left_over >= 64) {
-        {
             sha256_process_block(ctx->buffer, 64, ctx);
             left_over -= 64;
             /* The regions in the following copy operation cannot overlap,
@@ -265,21 +229,16 @@ sha256_process_bytes (const void *buffer, size_t len, struct sha256_ctx *ctx)
 /* SHA256 round constants */
 #define K(I) sha256_round_constants[I]
 static const uint32_t sha256_round_constants[64] = {
-  0x428a2f98UL, 0x71374491UL, 0xb5c0fbcfUL, 0xe9b5dba5UL,
+    0x428a2f98UL, 0x71374491UL, 0xb5c0fbcfUL, 0xe9b5dba5UL, 0x3956c25bUL, 0x59f111f1UL,
-  0x3956c25bUL, 0x59f111f1UL, 0x923f82a4UL, 0xab1c5ed5UL,
+    0x923f82a4UL, 0xab1c5ed5UL, 0xd807aa98UL, 0x12835b01UL, 0x243185beUL, 0x550c7dc3UL,
-  0xd807aa98UL, 0x12835b01UL, 0x243185beUL, 0x550c7dc3UL,
+    0x72be5d74UL, 0x80deb1feUL, 0x9bdc06a7UL, 0xc19bf174UL, 0xe49b69c1UL, 0xefbe4786UL,
-  0x72be5d74UL, 0x80deb1feUL, 0x9bdc06a7UL, 0xc19bf174UL,
+    0x0fc19dc6UL, 0x240ca1ccUL, 0x2de92c6fUL, 0x4a7484aaUL, 0x5cb0a9dcUL, 0x76f988daUL,
-  0xe49b69c1UL, 0xefbe4786UL, 0x0fc19dc6UL, 0x240ca1ccUL,
+    0x983e5152UL, 0xa831c66dUL, 0xb00327c8UL, 0xbf597fc7UL, 0xc6e00bf3UL, 0xd5a79147UL,
-  0x2de92c6fUL, 0x4a7484aaUL, 0x5cb0a9dcUL, 0x76f988daUL,
+    0x06ca6351UL, 0x14292967UL, 0x27b70a85UL, 0x2e1b2138UL, 0x4d2c6dfcUL, 0x53380d13UL,
-  0x983e5152UL, 0xa831c66dUL, 0xb00327c8UL, 0xbf597fc7UL,
+    0x650a7354UL, 0x766a0abbUL, 0x81c2c92eUL, 0x92722c85UL, 0xa2bfe8a1UL, 0xa81a664bUL,
-  0xc6e00bf3UL, 0xd5a79147UL, 0x06ca6351UL, 0x14292967UL,
+    0xc24b8b70UL, 0xc76c51a3UL, 0xd192e819UL, 0xd6990624UL, 0xf40e3585UL, 0x106aa070UL,
-  0x27b70a85UL, 0x2e1b2138UL, 0x4d2c6dfcUL, 0x53380d13UL,
+    0x19a4c116UL, 0x1e376c08UL, 0x2748774cUL, 0x34b0bcb5UL, 0x391c0cb3UL, 0x4ed8aa4aUL,
-  0x650a7354UL, 0x766a0abbUL, 0x81c2c92eUL, 0x92722c85UL,
+    0x5b9cca4fUL, 0x682e6ff3UL, 0x748f82eeUL, 0x78a5636fUL, 0x84c87814UL, 0x8cc70208UL,
-  0xa2bfe8a1UL, 0xa81a664bUL, 0xc24b8b70UL, 0xc76c51a3UL,
-  0xd192e819UL, 0xd6990624UL, 0xf40e3585UL, 0x106aa070UL,
-  0x19a4c116UL, 0x1e376c08UL, 0x2748774cUL, 0x34b0bcb5UL,
-  0x391c0cb3UL, 0x4ed8aa4aUL, 0x5b9cca4fUL, 0x682e6ff3UL,
-  0x748f82eeUL, 0x78a5636fUL, 0x84c87814UL, 0x8cc70208UL,
     0x90befffaUL, 0xa4506cebUL, 0xbef9a3f7UL, 0xc67178f2UL,
 };
 
@@ -291,9 +250,7 @@ static const uint32_t sha256_round_constants[64] = {
    It is assumed that LEN % 64 == 0.
    Most of this code comes from GnuPG's cipher/sha1.c.  */
 
-void
+void sha256_process_block(const void* buffer, size_t len, struct sha256_ctx* ctx) {
-sha256_process_block (const void *buffer, size_t len, struct sha256_ctx *ctx)
-{
     const uint32_t* words = buffer;
     size_t nwords = len / sizeof(uint32_t);
     const uint32_t* endp = words + nwords;
@@ -320,26 +277,24 @@ sha256_process_block (const void *buffer, size_t len, struct sha256_ctx *ctx)
 #define SS0(x) (rol(x, 30) ^ rol(x, 19) ^ rol(x, 10))
 #define SS1(x) (rol(x, 26) ^ rol(x, 21) ^ rol(x, 7))
 
-#define M(I) ( tm =   S1(x[(I-2)&0x0f]) + x[(I-7)&0x0f] \
+#define M(I)                                                                                \
-                    + S0(x[(I-15)&0x0f]) + x[I&0x0f]    \
+    (tm = S1(x[(I - 2) & 0x0f]) + x[(I - 7) & 0x0f] + S0(x[(I - 15) & 0x0f]) + x[I & 0x0f], \
-               , x[I&0x0f] = tm )
+     x[I & 0x0f] = tm)
 
-#define R(A,B,C,D,E,F,G,H,K,M)  do { t0 = SS0(A) + F2(A,B,C); \
+#define R(A, B, C, D, E, F, G, H, K, M)        \
-                                     t1 = H + SS1(E)  \
+    do {                                       \
-                                      + F1(E,F,G)     \
+        t0 = SS0(A) + F2(A, B, C);             \
-                                      + K             \
+        t1 = H + SS1(E) + F1(E, F, G) + K + M; \
-                                      + M;            \
+        D += t1;                               \
-                                     D += t1;  H = t0 + t1; \
+        H = t0 + t1;                           \
     } while(0)
 
-  while (words < endp)
+    while(words < endp) {
-    {
         uint32_t tm;
         uint32_t t0, t1;
         int t;
         /* FIXME: see sha1.c for a better implementation.  */
-      for (t = 0; t < 16; t++)
+        for(t = 0; t < 16; t++) {
-        {
             x[t] = SWAP(*words);
             words++;
         }

applications/plugins/totp/services/hmac/sha256.h

@@ -41,8 +41,7 @@ enum { SHA256_DIGEST_SIZE = 256 / 8 };
 #include "gl_openssl.h"
 #else
 /* Structure to save state of computation between the single steps.  */
-struct sha256_ctx
+struct sha256_ctx {
-{
     uint32_t state[8];
 
     uint32_t total[2];
@@ -58,15 +57,13 @@ extern void sha224_init_ctx (struct sha256_ctx *ctx);
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is necessary that LEN is a multiple of 64!!! */
-extern void sha256_process_block (const void *buffer, size_t len,
+extern void sha256_process_block(const void* buffer, size_t len, struct sha256_ctx* ctx);
-                                  struct sha256_ctx *ctx);
 
 /* Starting with the result of former calls of this function (or the
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is NOT required that LEN is a multiple of 64.  */
-extern void sha256_process_bytes (const void *buffer, size_t len,
+extern void sha256_process_bytes(const void* buffer, size_t len, struct sha256_ctx* ctx);
-                                  struct sha256_ctx *ctx);
 
 /* Process the remaining bytes in the buffer and put result from CTX
    in first 32 (28) bytes following RESBUF.  The result is always in little
@@ -75,24 +72,18 @@ extern void sha256_process_bytes (const void *buffer, size_t len,
 extern void* sha256_finish_ctx(struct sha256_ctx* ctx, void* restrict resbuf);
 extern void* sha224_finish_ctx(struct sha256_ctx* ctx, void* restrict resbuf);
 
-
 /* Put result from CTX in first 32 (28) bytes following RESBUF.  The result is
    always in little endian byte order, so that a byte-wise output yields
    to the wanted ASCII representation of the message digest.  */
-extern void *sha256_read_ctx (const struct sha256_ctx *ctx,
+extern void* sha256_read_ctx(const struct sha256_ctx* ctx, void* restrict resbuf);
-                              void *restrict resbuf);
+extern void* sha224_read_ctx(const struct sha256_ctx* ctx, void* restrict resbuf);
-extern void *sha224_read_ctx (const struct sha256_ctx *ctx,
-                              void *restrict resbuf);
-
 
 /* Compute SHA256 (SHA224) message digest for LEN bytes beginning at BUFFER.
    The result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-extern void *sha256_buffer (const char *buffer, size_t len,
+extern void* sha256_buffer(const char* buffer, size_t len, void* restrict resblock);
-                            void *restrict resblock);
+extern void* sha224_buffer(const char* buffer, size_t len, void* restrict resblock);
-extern void *sha224_buffer (const char *buffer, size_t len,
-                            void *restrict resblock);
 
 #endif
 
@@ -105,7 +96,6 @@ extern void *sha224_buffer (const char *buffer, size_t len,
 extern int sha256_stream(FILE* stream, void* resblock);
 extern int sha224_stream(FILE* stream, void* resblock);
 
-
 #ifdef __cplusplus
 }
 #endif

applications/plugins/totp/services/hmac/sha512.c

@@ -42,15 +42,12 @@
    128-byte boundary.  */
 static const unsigned char fillbuf[128] = {0x80, 0 /* , 0, 0, ...  */};
 
-
 /*
   Takes a pointer to a 512 bit block of data (eight 64 bit ints) and
   initializes it to the start constants of the SHA512 algorithm.  This
   must be called before using hash in the call to sha512_hash
 */
-void
+void sha512_init_ctx(struct sha512_ctx* ctx) {
-sha512_init_ctx (struct sha512_ctx *ctx)
-{
     ctx->state[0] = u64hilo(0x6a09e667, 0xf3bcc908);
     ctx->state[1] = u64hilo(0xbb67ae85, 0x84caa73b);
     ctx->state[2] = u64hilo(0x3c6ef372, 0xfe94f82b);
@@ -64,9 +61,7 @@ sha512_init_ctx (struct sha512_ctx *ctx)
     ctx->buflen = 0;
 }
 
-void
+void sha384_init_ctx(struct sha512_ctx* ctx) {
-sha384_init_ctx (struct sha512_ctx *ctx)
-{
     ctx->state[0] = u64hilo(0xcbbb9d5d, 0xc1059ed8);
     ctx->state[1] = u64hilo(0x629a292a, 0x367cd507);
     ctx->state[2] = u64hilo(0x9159015a, 0x3070dd17);
@@ -83,60 +78,48 @@ sha384_init_ctx (struct sha512_ctx *ctx)
 /* Copy the value from V into the memory location pointed to by *CP,
    If your architecture allows unaligned access, this is equivalent to
    * (__typeof__ (v) *) cp = v  */
-static void
+static void set_uint64(char* cp, u64 v) {
-set_uint64 (char *cp, u64 v)
-{
     memcpy(cp, &v, sizeof v);
 }
 
 /* Put result from CTX in first 64 bytes following RESBUF.
    The result must be in little endian byte order.  */
-void *
+void* sha512_read_ctx(const struct sha512_ctx* ctx, void* resbuf) {
-sha512_read_ctx (const struct sha512_ctx *ctx, void *resbuf)
-{
     int i;
     char* r = resbuf;
 
-  for (i = 0; i < 8; i++)
+    for(i = 0; i < 8; i++) set_uint64(r + i * sizeof ctx->state[0], SWAP(ctx->state[i]));
-    set_uint64 (r + i * sizeof ctx->state[0], SWAP (ctx->state[i]));
 
     return resbuf;
 }
 
-void *
+void* sha384_read_ctx(const struct sha512_ctx* ctx, void* resbuf) {
-sha384_read_ctx (const struct sha512_ctx *ctx, void *resbuf)
-{
     int i;
     char* r = resbuf;
 
-  for (i = 0; i < 6; i++)
+    for(i = 0; i < 6; i++) set_uint64(r + i * sizeof ctx->state[0], SWAP(ctx->state[i]));
-    set_uint64 (r + i * sizeof ctx->state[0], SWAP (ctx->state[i]));
 
     return resbuf;
 }
 
 /* Process the remaining bytes in the internal buffer and the usual
    prolog according to the standard and write the result to RESBUF.  */
-static void
+static void sha512_conclude_ctx(struct sha512_ctx* ctx) {
-sha512_conclude_ctx (struct sha512_ctx *ctx)
-{
     /* Take yet unprocessed bytes into account.  */
     size_t bytes = ctx->buflen;
     size_t size = (bytes < 112) ? 128 / 8 : 128 * 2 / 8;
 
     /* Now count remaining bytes.  */
     ctx->total[0] = u64plus(ctx->total[0], u64lo(bytes));
-  if (u64lt (ctx->total[0], u64lo (bytes)))
+    if(u64lt(ctx->total[0], u64lo(bytes))) ctx->total[1] = u64plus(ctx->total[1], u64lo(1));
-    ctx->total[1] = u64plus (ctx->total[1], u64lo (1));
 
     /* Put the 128-bit file length in *bits* at the end of the buffer.
      Use set_uint64 rather than a simple assignment, to avoid risk of
      unaligned access.  */
-  set_uint64 ((char *) &ctx->buffer[size - 2],
+    set_uint64(
-              SWAP (u64or (u64shl (ctx->total[1], 3),
+        (char*)&ctx->buffer[size - 2],
-                           u64shr (ctx->total[0], 61))));
+        SWAP(u64or(u64shl(ctx->total[1], 3), u64shr(ctx->total[0], 61))));
-  set_uint64 ((char *) &ctx->buffer[size - 1],
+    set_uint64((char*)&ctx->buffer[size - 1], SWAP(u64shl(ctx->total[0], 3)));
-              SWAP (u64shl (ctx->total[0], 3)));
 
     memcpy(&((char*)ctx->buffer)[bytes], fillbuf, (size - 2) * 8 - bytes);
 
@@ -144,16 +127,12 @@ sha512_conclude_ctx (struct sha512_ctx *ctx)
     sha512_process_block(ctx->buffer, size * 8, ctx);
 }
 
-void *
+void* sha512_finish_ctx(struct sha512_ctx* ctx, void* resbuf) {
-sha512_finish_ctx (struct sha512_ctx *ctx, void *resbuf)
-{
     sha512_conclude_ctx(ctx);
     return sha512_read_ctx(ctx, resbuf);
 }
 
-void *
+void* sha384_finish_ctx(struct sha512_ctx* ctx, void* resbuf) {
-sha384_finish_ctx (struct sha512_ctx *ctx, void *resbuf)
-{
     sha512_conclude_ctx(ctx);
     return sha384_read_ctx(ctx, resbuf);
 }
@@ -162,9 +141,7 @@ sha384_finish_ctx (struct sha512_ctx *ctx, void *resbuf)
    result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-void *
+void* sha512_buffer(const char* buffer, size_t len, void* resblock) {
-sha512_buffer (const char *buffer, size_t len, void *resblock)
-{
     struct sha512_ctx ctx;
 
     /* Initialize the computation context.  */
@@ -177,9 +154,7 @@ sha512_buffer (const char *buffer, size_t len, void *resblock)
     return sha512_finish_ctx(&ctx, resblock);
 }
 
-void *
+void* sha384_buffer(const char* buffer, size_t len, void* resblock) {
-sha384_buffer (const char *buffer, size_t len, void *resblock)
-{
     struct sha512_ctx ctx;
 
     /* Initialize the computation context.  */
@@ -192,29 +167,23 @@ sha384_buffer (const char *buffer, size_t len, void *resblock)
     return sha384_finish_ctx(&ctx, resblock);
 }
 
-void
+void sha512_process_bytes(const void* buffer, size_t len, struct sha512_ctx* ctx) {
-sha512_process_bytes (const void *buffer, size_t len, struct sha512_ctx *ctx)
-{
     /* When we already have some bits in our internal buffer concatenate
      both inputs first.  */
-  if (ctx->buflen != 0)
+    if(ctx->buflen != 0) {
-    {
         size_t left_over = ctx->buflen;
         size_t add = 256 - left_over > len ? len : 256 - left_over;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, add);
         ctx->buflen += add;
 
-      if (ctx->buflen > 128)
+        if(ctx->buflen > 128) {
-        {
             sha512_process_block(ctx->buffer, ctx->buflen & ~127, ctx);
 
             ctx->buflen &= 127;
             /* The regions in the following copy operation cannot overlap,
              because ctx->buflen < 128 ≤ (left_over + add) & ~127.  */
-          memcpy (ctx->buffer,
+            memcpy(ctx->buffer, &((char*)ctx->buffer)[(left_over + add) & ~127], ctx->buflen);
-                  &((char *) ctx->buffer)[(left_over + add) & ~127],
-                  ctx->buflen);
         }
 
         buffer = (const char*)buffer + add;
@@ -222,13 +191,11 @@ sha512_process_bytes (const void *buffer, size_t len, struct sha512_ctx *ctx)
     }
 
     /* Process available complete blocks.  */
-  if (len >= 128)
+    if(len >= 128) {
-    {
 #if !(_STRING_ARCH_unaligned || _STRING_INLINE_unaligned)
 #define UNALIGNED_P(p) ((uintptr_t)(p) % sizeof(u64) != 0)
         if(UNALIGNED_P(buffer))
-        while (len > 128)
+            while(len > 128) {
-          {
                 sha512_process_block(memcpy(ctx->buffer, buffer, 128), 128, ctx);
                 buffer = (const char*)buffer + 128;
                 len -= 128;
@@ -243,14 +210,12 @@ sha512_process_bytes (const void *buffer, size_t len, struct sha512_ctx *ctx)
     }
 
     /* Move remaining bytes in internal buffer.  */
-  if (len > 0)
+    if(len > 0) {
-    {
         size_t left_over = ctx->buflen;
 
         memcpy(&((char*)ctx->buffer)[left_over], buffer, len);
         left_over += len;
-      if (left_over >= 128)
+        if(left_over >= 128) {
-        {
             sha512_process_block(ctx->buffer, 128, ctx);
             left_over -= 128;
             /* The regions in the following copy operation cannot overlap,
@@ -316,9 +281,7 @@ static u64 const sha512_round_constants[80] = {
    It is assumed that LEN % 128 == 0.
    Most of this code comes from GnuPG's cipher/sha1.c.  */
 
-void
+void sha512_process_block(const void* buffer, size_t len, struct sha512_ctx* ctx) {
-sha512_process_block (const void *buffer, size_t len, struct sha512_ctx *ctx)
-{
     u64 const* words = buffer;
     u64 const* endp = words + len / sizeof(u64);
     u64 x[16];
@@ -336,39 +299,31 @@ sha512_process_block (const void *buffer, size_t len, struct sha512_ctx *ctx)
      length of the file up to 2^128 bits.  Here we only compute the
      number of bytes.  Do a double word increment.  */
     ctx->total[0] = u64plus(ctx->total[0], lolen);
-  ctx->total[1] = u64plus (ctx->total[1],
+    ctx->total[1] = u64plus(
-                           u64plus (u64size (len >> 31 >> 31 >> 2),
+        ctx->total[1], u64plus(u64size(len >> 31 >> 31 >> 2), u64lo(u64lt(ctx->total[0], lolen))));
-                                    u64lo (u64lt (ctx->total[0], lolen))));
 
 #define S0(x) u64xor(u64rol(x, 63), u64xor(u64rol(x, 56), u64shr(x, 7)))
 #define S1(x) u64xor(u64rol(x, 45), u64xor(u64rol(x, 3), u64shr(x, 6)))
 #define SS0(x) u64xor(u64rol(x, 36), u64xor(u64rol(x, 30), u64rol(x, 25)))
 #define SS1(x) u64xor(u64rol(x, 50), u64xor(u64rol(x, 46), u64rol(x, 23)))
 
-#define M(I) (x[(I) & 15]                                                 \
+#define M(I)              \
-              = u64plus (x[(I) & 15],                                     \
+    (x[(I)&15] = u64plus( \
-                         u64plus (S1 (x[((I) - 2) & 15]),                 \
+         x[(I)&15],       \
-                                  u64plus (x[((I) - 7) & 15],             \
+         u64plus(S1(x[((I)-2) & 15]), u64plus(x[((I)-7) & 15], S0(x[((I)-15) & 15])))))
-                                           S0 (x[((I) - 15) & 15])))))
 
 #define R(A, B, C, D, E, F, G, H, K, M)                                            \
-  do                                                                      \
+    do {                                                                           \
-    {                                                                     \
         u64 t0 = u64plus(SS0(A), F2(A, B, C));                                     \
-      u64 t1 =                                                            \
+        u64 t1 = u64plus(H, u64plus(SS1(E), u64plus(F1(E, F, G), u64plus(K, M)))); \
-        u64plus (H, u64plus (SS1 (E),                                     \
-                             u64plus (F1 (E, F, G), u64plus (K, M))));    \
         D = u64plus(D, t1);                                                        \
         H = u64plus(t0, t1);                                                       \
-    }                                                                     \
+    } while(0)
-  while (0)
 
-  while (words < endp)
+    while(words < endp) {
-    {
         int t;
         /* FIXME: see sha1.c for a better implementation.  */
-      for (t = 0; t < 16; t++)
+        for(t = 0; t < 16; t++) {
-        {
             x[t] = SWAP(*words);
             words++;
         }

applications/plugins/totp/services/hmac/sha512.h

@@ -41,8 +41,7 @@ enum { SHA512_DIGEST_SIZE = 512 / 8 };
 #include "gl_openssl.h"
 #else
 /* Structure to save state of computation between the single steps.  */
-struct sha512_ctx
+struct sha512_ctx {
-{
     u64 state[8];
 
     u64 total[2];
@@ -58,15 +57,13 @@ extern void sha384_init_ctx (struct sha512_ctx *ctx);
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is necessary that LEN is a multiple of 128!!! */
-extern void sha512_process_block (const void *buffer, size_t len,
+extern void sha512_process_block(const void* buffer, size_t len, struct sha512_ctx* ctx);
-                                  struct sha512_ctx *ctx);
 
 /* Starting with the result of former calls of this function (or the
    initialization function update the context for the next LEN bytes
    starting at BUFFER.
    It is NOT required that LEN is a multiple of 128.  */
-extern void sha512_process_bytes (const void *buffer, size_t len,
+extern void sha512_process_bytes(const void* buffer, size_t len, struct sha512_ctx* ctx);
-                                  struct sha512_ctx *ctx);
 
 /* Process the remaining bytes in the buffer and put result from CTX
    in first 64 (48) bytes following RESBUF.  The result is always in little
@@ -75,27 +72,21 @@ extern void sha512_process_bytes (const void *buffer, size_t len,
 extern void* sha512_finish_ctx(struct sha512_ctx* ctx, void* restrict resbuf);
 extern void* sha384_finish_ctx(struct sha512_ctx* ctx, void* restrict resbuf);
 
-
 /* Put result from CTX in first 64 (48) bytes following RESBUF.  The result is
    always in little endian byte order, so that a byte-wise output yields
    to the wanted ASCII representation of the message digest.
 
    IMPORTANT: On some systems it is required that RESBUF is correctly
    aligned for a 32 bits value.  */
-extern void *sha512_read_ctx (const struct sha512_ctx *ctx,
+extern void* sha512_read_ctx(const struct sha512_ctx* ctx, void* restrict resbuf);
-                              void *restrict resbuf);
+extern void* sha384_read_ctx(const struct sha512_ctx* ctx, void* restrict resbuf);
-extern void *sha384_read_ctx (const struct sha512_ctx *ctx,
-                              void *restrict resbuf);
-
 
 /* Compute SHA512 (SHA384) message digest for LEN bytes beginning at BUFFER.
    The result is always in little endian byte order, so that a byte-wise
    output yields to the wanted ASCII representation of the message
    digest.  */
-extern void *sha512_buffer (const char *buffer, size_t len,
+extern void* sha512_buffer(const char* buffer, size_t len, void* restrict resblock);
-                            void *restrict resblock);
+extern void* sha384_buffer(const char* buffer, size_t len, void* restrict resblock);
-extern void *sha384_buffer (const char *buffer, size_t len,
-                            void *restrict resblock);
 
 #endif
 
@@ -108,7 +99,6 @@ extern void *sha384_buffer (const char *buffer, size_t len,
 extern int sha512_stream(FILE* stream, void* resblock);
 extern int sha384_stream(FILE* stream, void* resblock);
 
-
 #ifdef __cplusplus
 }
 #endif

applications/plugins/totp/services/list/list.c

@@ -30,8 +30,7 @@ ListNode *list_find(ListNode *head, void* data) {
     ListNode* it;
 
     for(it = head; it != NULL; it = it->next)
-        if (it->data == data)
+        if(it->data == data) break;
-            break;
 
     return it;
 }
@@ -39,7 +38,8 @@ ListNode *list_find(ListNode *head, void* data) {
 ListNode* list_element_at(ListNode* head, uint16_t index) {
     ListNode* it;
     uint16_t i;
-    for (it = head, i = 0; it != NULL && i < index; it = it->next, i++);
+    for(it = head, i = 0; it != NULL && i < index; it = it->next, i++)
+        ;
     return it;
 }
 

applications/plugins/totp/services/list/list.h

@@ -9,8 +9,16 @@ typedef struct ListNode {
 } ListNode;
 
 ListNode* list_init_head(void* data);
-ListNode *list_add(ListNode *head, void* data); /* adds element with specified data to the end of the list and returns new head node. */
+ListNode* list_add(
-ListNode *list_find(ListNode *head, void* data); /* returns pointer of element with specified data in list. */
+    ListNode* head,
-ListNode *list_element_at(ListNode *head, uint16_t index); /* returns pointer of element with specified index in list. */
+    void* data); /* adds element with specified data to the end of the list and returns new head node. */
-ListNode *list_remove(ListNode *head, ListNode *ep); /* removes element from the list and returns new head node. */
+ListNode* list_find(
+    ListNode* head,
+    void* data); /* returns pointer of element with specified data in list. */
+ListNode* list_element_at(
+    ListNode* head,
+    uint16_t index); /* returns pointer of element with specified index in list. */
+ListNode* list_remove(
+    ListNode* head,
+    ListNode* ep); /* removes element from the list and returns new head node. */
 void list_free(ListNode* head); /* deletes all elements of the list. */

applications/plugins/totp/services/totp/totp.c

@@ -5,9 +5,9 @@
 #include <stdint.h>
 #include <string.h>
 #include <math.h>
-#include "../hmac/hmac-sha1.h"
+#include "../hmac/hmac_sha1.h"
-#include "../hmac/hmac-sha256.h"
+#include "../hmac/hmac_sha256.h"
-#include "../hmac/hmac-sha512.h"
+#include "../hmac/hmac_sha512.h"
 #include "../timezone_utils/timezone_utils.h"
 
 #define UINT64_GET_BYTE(integer, index) ((integer >> (8 * index)) & 0xFF)
@@ -25,8 +25,7 @@
 			timeblock given for_time, using data->interval
 		error, 0
 */
-uint64_t totp_timecode(uint8_t interval, uint64_t for_time)
+uint64_t totp_timecode(uint8_t interval, uint64_t for_time) {
-{
     return for_time / interval;
 }
 
@@ -35,8 +34,7 @@ uint64_t totp_timecode(uint8_t interval, uint64_t for_time)
 	
 	out_bytes is the null-terminated output string already allocated
 */
-void otp_num_to_bytes(uint64_t integer, uint8_t* out_bytes)
+void otp_num_to_bytes(uint64_t integer, uint8_t* out_bytes) {
-{   
     out_bytes[7] = UINT64_GET_BYTE(integer, 0);
     out_bytes[6] = UINT64_GET_BYTE(integer, 1);
     out_bytes[5] = UINT64_GET_BYTE(integer, 2);
@@ -57,8 +55,12 @@ void otp_num_to_bytes(uint64_t integer, uint8_t* out_bytes)
 			OTP code if otp code was successfully generated
 		0 otherwise
 */
-uint32_t otp_generate(TOTP_ALGO algo, uint8_t digits, const uint8_t* plain_secret, uint8_t plain_secret_length, uint64_t input)
+uint32_t otp_generate(
-{
+    TOTP_ALGO algo,
+    uint8_t digits,
+    const uint8_t* plain_secret,
+    uint8_t plain_secret_length,
+    uint64_t input) {
     uint8_t* bytes = malloc(8);
     memset(bytes, 0, 8);
     uint8_t* hmac = malloc(64);
@@ -75,10 +77,8 @@ uint32_t otp_generate(TOTP_ALGO algo, uint8_t digits, const uint8_t* plain_secre
 
     uint64_t offset = (hmac[hmac_len - 1] & 0xF);
     uint64_t i_code =
-		((hmac[offset] & 0x7F) << 24 |
+        ((hmac[offset] & 0x7F) << 24 | (hmac[offset + 1] & 0xFF) << 16 |
-		(hmac[offset + 1] & 0xFF) << 16 |
+         (hmac[offset + 2] & 0xFF) << 8 | (hmac[offset + 3] & 0xFF));
-		(hmac[offset + 2] & 0xFF) << 8 |
-		(hmac[offset + 3] & 0xFF));
     i_code %= (uint64_t)pow(10, digits);
 
     free(hmac);
@@ -97,23 +97,50 @@ uint32_t otp_generate(TOTP_ALGO algo, uint8_t digits, const uint8_t* plain_secre
 			TOTP code if otp code was successfully generated
 		0 otherwise
 */
-uint32_t totp_at(TOTP_ALGO algo, uint8_t digits, const uint8_t* plain_secret, uint8_t plain_secret_length, uint64_t for_time, float timezone, uint8_t interval)
+uint32_t totp_at(
-{
+    TOTP_ALGO algo,
-    uint64_t for_time_adjusted = timezone_offset_apply(for_time, timezone_offset_from_hours(timezone));
+    uint8_t digits,
-	return otp_generate(algo, digits, plain_secret, plain_secret_length, totp_timecode(interval, for_time_adjusted));
+    const uint8_t* plain_secret,
+    uint8_t plain_secret_length,
+    uint64_t for_time,
+    float timezone,
+    uint8_t interval) {
+    uint64_t for_time_adjusted =
+        timezone_offset_apply(for_time, timezone_offset_from_hours(timezone));
+    return otp_generate(
+        algo,
+        digits,
+        plain_secret,
+        plain_secret_length,
+        totp_timecode(interval, for_time_adjusted));
 }
 
-static int totp_algo_sha1(const uint8_t* key, uint8_t key_length, const uint8_t* input, uint8_t input_length, uint8_t* output) { 
+static int totp_algo_sha1(
+    const uint8_t* key,
+    uint8_t key_length,
+    const uint8_t* input,
+    uint8_t input_length,
+    uint8_t* output) {
     hmac_sha1(key, key_length, input, input_length, output);
     return HMAC_SHA1_RESULT_SIZE;
 }
 
-static int totp_algo_sha256(const uint8_t* key, uint8_t key_length, const uint8_t* input, uint8_t input_length, uint8_t* output) { 
+static int totp_algo_sha256(
+    const uint8_t* key,
+    uint8_t key_length,
+    const uint8_t* input,
+    uint8_t input_length,
+    uint8_t* output) {
     hmac_sha256(key, key_length, input, input_length, output);
     return HMAC_SHA256_RESULT_SIZE;
 }
 
-static int totp_algo_sha512(const uint8_t* key, uint8_t key_length, const uint8_t* input, uint8_t input_length, uint8_t* output) { 
+static int totp_algo_sha512(
+    const uint8_t* key,
+    uint8_t key_length,
+    const uint8_t* input,
+    uint8_t input_length,
+    uint8_t* output) {
     hmac_sha512(key, key_length, input, input_length, output);
     return HMAC_SHA512_RESULT_SIZE;
 }

applications/plugins/totp/services/totp/totp.h

@@ -15,7 +15,12 @@
 	
 	Must return 0 if error, or the length in bytes of the HMAC operation.
 */
-typedef int (*TOTP_ALGO)(const uint8_t* key, uint8_t key_length, const uint8_t* input, uint8_t input_length, uint8_t* output);
+typedef int (*TOTP_ALGO)(
+    const uint8_t* key,
+    uint8_t key_length,
+    const uint8_t* input,
+    uint8_t input_length,
+    uint8_t* output);
 
 /*
     Computes HMAC using SHA1
@@ -38,4 +43,11 @@ extern const TOTP_ALGO TOTP_ALGO_SHA512;
         TOTP token on success
         0 otherwise
 */
-uint32_t totp_at(TOTP_ALGO algo, uint8_t digits, const uint8_t* plain_secret, uint8_t plain_secret_length, uint64_t for_time, float timezone, uint8_t interval);
+uint32_t totp_at(
+    TOTP_ALGO algo,
+    uint8_t digits,
+    const uint8_t* plain_secret,
+    uint8_t plain_secret_length,
+    uint64_t for_time,
+    float timezone,
+    uint8_t interval);

applications/plugins/totp/services/ui/icons.h

@@ -8,4 +8,5 @@ static const uint8_t ICON_ARROW_LEFT_8x9[] = { 0x80,0xe0,0xf8,0xfe,0xff,0xfe,0xf
 
 #define ICON_ARROW_RIGHT_8x9_WIDTH 8
 #define ICON_ARROW_RIGHT_8x9_HEIGHT 9
-static const uint8_t ICON_ARROW_RIGHT_8x9[] = { 0x01,0x07,0x1f,0x7f,0xff,0x7f,0x1f,0x07,0x01 };
+static const uint8_t ICON_ARROW_RIGHT_8x9[] =
+    {0x01, 0x07, 0x1f, 0x7f, 0xff, 0x7f, 0x1f, 0x07, 0x01};

applications/plugins/totp/services/ui/ui_controls.c

@@ -11,33 +11,96 @@ void ui_control_text_box_render(Canvas* const canvas, int8_t y, char* text, bool
     }
 
     if(is_selected) {
-        canvas_draw_rframe(canvas, TEXT_BOX_MARGIN, TEXT_BOX_MARGIN + y, SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN, TEXT_BOX_HEIGHT, 0);
+        canvas_draw_rframe(
-        canvas_draw_rframe(canvas, TEXT_BOX_MARGIN - 1, TEXT_BOX_MARGIN + y - 1, SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN + 2, TEXT_BOX_HEIGHT + 2, 1);
+            canvas,
+            TEXT_BOX_MARGIN,
+            TEXT_BOX_MARGIN + y,
+            SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN,
+            TEXT_BOX_HEIGHT,
+            0);
+        canvas_draw_rframe(
+            canvas,
+            TEXT_BOX_MARGIN - 1,
+            TEXT_BOX_MARGIN + y - 1,
+            SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN + 2,
+            TEXT_BOX_HEIGHT + 2,
+            1);
     } else {
-        canvas_draw_rframe(canvas, TEXT_BOX_MARGIN, TEXT_BOX_MARGIN + y, SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN, TEXT_BOX_HEIGHT, 1);
+        canvas_draw_rframe(
+            canvas,
+            TEXT_BOX_MARGIN,
+            TEXT_BOX_MARGIN + y,
+            SCREEN_WIDTH - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN,
+            TEXT_BOX_HEIGHT,
+            1);
     }
 
-    canvas_draw_str_aligned(canvas, TEXT_BOX_MARGIN + 2, TEXT_BOX_MARGIN + 3 + y, AlignLeft, AlignTop, text);
+    canvas_draw_str_aligned(
+        canvas, TEXT_BOX_MARGIN + 2, TEXT_BOX_MARGIN + 3 + y, AlignLeft, AlignTop, text);
 }
 
-void ui_control_select_render(Canvas* const canvas, int16_t x, int16_t y, uint8_t width, char* text, bool is_selected) {
+void ui_control_select_render(
+    Canvas* const canvas,
+    int16_t x,
+    int16_t y,
+    uint8_t width,
+    char* text,
+    bool is_selected) {
     if(y < -TEXT_BOX_HEIGHT) {
         return;
     }
 
     if(is_selected) {
-        canvas_draw_rframe(canvas, x + TEXT_BOX_MARGIN, TEXT_BOX_MARGIN + y, width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN, TEXT_BOX_HEIGHT, 0);
+        canvas_draw_rframe(
-        canvas_draw_rframe(canvas, x + TEXT_BOX_MARGIN - 1, TEXT_BOX_MARGIN + y - 1, width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN + 2, TEXT_BOX_HEIGHT + 2, 1);
+            canvas,
+            x + TEXT_BOX_MARGIN,
+            TEXT_BOX_MARGIN + y,
+            width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN,
+            TEXT_BOX_HEIGHT,
+            0);
+        canvas_draw_rframe(
+            canvas,
+            x + TEXT_BOX_MARGIN - 1,
+            TEXT_BOX_MARGIN + y - 1,
+            width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN + 2,
+            TEXT_BOX_HEIGHT + 2,
+            1);
     } else {
-        canvas_draw_rframe(canvas, x + TEXT_BOX_MARGIN, TEXT_BOX_MARGIN + y, width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN, TEXT_BOX_HEIGHT, 1);
+        canvas_draw_rframe(
+            canvas,
+            x + TEXT_BOX_MARGIN,
+            TEXT_BOX_MARGIN + y,
+            width - TEXT_BOX_MARGIN - TEXT_BOX_MARGIN,
+            TEXT_BOX_HEIGHT,
+            1);
     }
 
-    canvas_draw_str_aligned(canvas, x + (width >> 1), TEXT_BOX_MARGIN + 3 + y, AlignCenter, AlignTop, text);
+    canvas_draw_str_aligned(
-    canvas_draw_xbm(canvas, x + TEXT_BOX_MARGIN + 2, TEXT_BOX_MARGIN + 2 + y, ICON_ARROW_LEFT_8x9_WIDTH, ICON_ARROW_LEFT_8x9_HEIGHT, &ICON_ARROW_LEFT_8x9[0]);
+        canvas, x + (width >> 1), TEXT_BOX_MARGIN + 3 + y, AlignCenter, AlignTop, text);
-    canvas_draw_xbm(canvas, x + width - TEXT_BOX_MARGIN - 10, TEXT_BOX_MARGIN + 2 + y, ICON_ARROW_RIGHT_8x9_WIDTH, ICON_ARROW_RIGHT_8x9_HEIGHT, &ICON_ARROW_RIGHT_8x9[0]);
+    canvas_draw_xbm(
+        canvas,
+        x + TEXT_BOX_MARGIN + 2,
+        TEXT_BOX_MARGIN + 2 + y,
+        ICON_ARROW_LEFT_8x9_WIDTH,
+        ICON_ARROW_LEFT_8x9_HEIGHT,
+        &ICON_ARROW_LEFT_8x9[0]);
+    canvas_draw_xbm(
+        canvas,
+        x + width - TEXT_BOX_MARGIN - 10,
+        TEXT_BOX_MARGIN + 2 + y,
+        ICON_ARROW_RIGHT_8x9_WIDTH,
+        ICON_ARROW_RIGHT_8x9_HEIGHT,
+        &ICON_ARROW_RIGHT_8x9[0]);
 }
 
-void ui_control_button_render(Canvas* const canvas, int16_t x, int16_t y, uint8_t width, uint8_t height, char* text, bool is_selected) {
+void ui_control_button_render(
+    Canvas* const canvas,
+    int16_t x,
+    int16_t y,
+    uint8_t width,
+    uint8_t height,
+    char* text,
+    bool is_selected) {
     if(y < -height) {
         return;
     }
@@ -49,7 +112,8 @@ void ui_control_button_render(Canvas* const canvas, int16_t x, int16_t y, uint8_
         canvas_draw_rframe(canvas, x, y, width, height, 1);
     }
 
-    canvas_draw_str_aligned(canvas, x + (width >> 1), y + (height >> 1) + 1, AlignCenter, AlignCenter, text);
+    canvas_draw_str_aligned(
+        canvas, x + (width >> 1), y + (height >> 1) + 1, AlignCenter, AlignCenter, text);
     if(is_selected) {
         canvas_set_color(canvas, ColorBlack);
     }

applications/plugins/totp/services/ui/ui_controls.h

@@ -4,5 +4,18 @@
 #include <gui/gui.h>
 
 void ui_control_text_box_render(Canvas* const canvas, int8_t y, char* text, bool is_selected);
-void ui_control_button_render(Canvas* const canvas, int16_t x, int16_t y, uint8_t width, uint8_t height, char* text, bool is_selected);
+void ui_control_button_render(
-void ui_control_select_render(Canvas* const canvas, int16_t x, int16_t y, uint8_t width, char* text, bool is_selected);
+    Canvas* const canvas,
+    int16_t x,
+    int16_t y,
+    uint8_t width,
+    uint8_t height,
+    char* text,
+    bool is_selected);
+void ui_control_select_render(
+    Canvas* const canvas,
+    int16_t x,
+    int16_t y,
+    uint8_t width,
+    char* text,
+    bool is_selected);

applications/plugins/totp/totp_app.c

@@ -48,7 +48,13 @@ static bool totp_state_init(PluginState* const plugin_state) {
     if(plugin_state->crypto_verify_data == NULL) {
         DialogMessage* message = dialog_message_alloc();
         dialog_message_set_buttons(message, "No", NULL, "Yes");
-        dialog_message_set_text(message, "Would you like to setup PIN?", SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER, AlignCenter, AlignCenter);
+        dialog_message_set_text(
+            message,
+            "Would you like to setup PIN?",
+            SCREEN_WIDTH_CENTER,
+            SCREEN_HEIGHT_CENTER,
+            AlignCenter,
+            AlignCenter);
         DialogMessageButton dialog_result = dialog_message_show(plugin_state->dialogs, message);
         dialog_message_free(message);
         if(dialog_result == DialogMessageButtonRight) {
@@ -64,10 +70,18 @@ static bool totp_state_init(PluginState* const plugin_state) {
         if(totp_crypto_verify_key(plugin_state)) {
             totp_scene_director_activate_scene(plugin_state, TotpSceneGenerateToken, NULL);
         } else {
-            FURI_LOG_E(LOGGING_TAG, "Digital signature verification failed. Looks like conf file was created on another flipper and can't be used on any other");
+            FURI_LOG_E(
+                LOGGING_TAG,
+                "Digital signature verification failed. Looks like conf file was created on another flipper and can't be used on any other");
             DialogMessage* message = dialog_message_alloc();
             dialog_message_set_buttons(message, "Exit", NULL, NULL);
-            dialog_message_set_text(message, "Digital signature verification failed", SCREEN_WIDTH_CENTER, SCREEN_HEIGHT_CENTER, AlignCenter, AlignCenter);
+            dialog_message_set_text(
+                message,
+                "Digital signature verification failed",
+                SCREEN_WIDTH_CENTER,
+                SCREEN_HEIGHT_CENTER,
+                AlignCenter,
+                AlignCenter);
             dialog_message_show(plugin_state->dialogs, message);
             dialog_message_free(message);
             return false;
@@ -142,7 +156,9 @@ int32_t totp_app() {
             }
 
             processing = totp_scene_director_handle_event(&event, plugin_state);
-        } else if (plugin_state->pin_set && plugin_state->current_scene != TotpSceneAuthentication && furi_get_tick() - last_user_interaction_time > IDLE_TIMEOUT) {
+        } else if(
+            plugin_state->pin_set && plugin_state->current_scene != TotpSceneAuthentication &&
+            furi_get_tick() - last_user_interaction_time > IDLE_TIMEOUT) {
             totp_scene_director_activate_scene(plugin_state, TotpSceneAuthentication, NULL);
         }
 

applications/plugins/totp/types/token_info.c

@@ -20,11 +20,17 @@ void token_info_free(TokenInfo* token_info) {
     free(token_info);
 }
 
-void token_info_set_secret(TokenInfo* token_info, const char* base32_token_secret, uint8_t token_secret_length, uint8_t* iv) {
+void token_info_set_secret(
+    TokenInfo* token_info,
+    const char* base32_token_secret,
+    uint8_t token_secret_length,
+    uint8_t* iv) {
     uint8_t* plain_secret = malloc(token_secret_length);
-    int plain_secret_length = base32_decode((uint8_t *)base32_token_secret, plain_secret, token_secret_length);
+    int plain_secret_length =
+        base32_decode((uint8_t*)base32_token_secret, plain_secret, token_secret_length);
 
-    token_info->token = totp_crypto_encrypt(plain_secret, plain_secret_length, iv, &token_info->token_length);
+    token_info->token =
+        totp_crypto_encrypt(plain_secret, plain_secret_length, iv, &token_info->token_length);
 
     memset(plain_secret, 0, token_secret_length);
     free(plain_secret);
@@ -32,8 +38,10 @@ void token_info_set_secret(TokenInfo* token_info, const char* base32_token_secre
 
 uint8_t token_info_get_digits_count(TokenInfo* token_info) {
     switch(token_info->digits) {
-        case TOTP_6_DIGITS: return 6;
+    case TOTP_6_DIGITS:
-        case TOTP_8_DIGITS: return 8;
+        return 6;
+    case TOTP_8_DIGITS:
+        return 8;
     }
 
     return 6;

applications/plugins/totp/types/token_info.h

@@ -2,16 +2,9 @@
 
 #include <inttypes.h>
 
-typedef enum {
+typedef enum { SHA1, SHA256, SHA512 } TokenHashAlgo;
-    SHA1,
-    SHA256,
-    SHA512
-} TokenHashAlgo;
 
-typedef enum {
+typedef enum { TOTP_6_DIGITS, TOTP_8_DIGITS } TokenDigitsCount;
-    TOTP_6_DIGITS,
-    TOTP_8_DIGITS
-} TokenDigitsCount;
 
 typedef struct {
     uint8_t* token;
@@ -23,5 +16,9 @@ typedef struct {
 
 TokenInfo* token_info_alloc();
 void token_info_free(TokenInfo* token_info);
-void token_info_set_secret(TokenInfo* token_info, const char* base32_token_secret, uint8_t token_secret_length, uint8_t* iv);
+void token_info_set_secret(
+    TokenInfo* token_info,
+    const char* base32_token_secret,
+    uint8_t token_secret_length,
+    uint8_t* iv);
 uint8_t token_info_get_digits_count(TokenInfo* token_info);