Api Symbols: replace asserts with checks (#3507)

* Api Symbols: replace asserts with checks
* Api Symbols: replace asserts with checks part 2
* Update no args function signatures with void, to help compiler to track incorrect usage
* More unavoidable void
* Update PVS config and code to make it happy
* Format sources
* nfc: fix checks
* dead code cleanup & include fixes

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>
Co-authored-by: hedger <hedger@nanode.su>

applications/examples/example_ble_beacon/ble_beacon_app.c

@@ -57,7 +57,7 @@ static void ble_beacon_app_restore_beacon_state(BleBeaconApp* app) {
     app->beacon_data_len = furi_hal_bt_extra_beacon_get_data(app->beacon_data);
 }
 
-static BleBeaconApp* ble_beacon_app_alloc() {
+static BleBeaconApp* ble_beacon_app_alloc(void) {
     BleBeaconApp* app = malloc(sizeof(BleBeaconApp));
 
     app->gui = furi_record_open(RECORD_GUI);

applications/examples/example_plugins/plugin1.c

@@ -9,7 +9,7 @@
 
 #include <flipper_application/flipper_application.h>
 
-static int example_plugin1_method1() {
+static int example_plugin1_method1(void) {
     return 42;
 }
 
@@ -32,6 +32,6 @@ static const FlipperAppPluginDescriptor example_plugin1_descriptor = {
 };
 
 /* Plugin entry point - must return a pointer to const descriptor  */
-const FlipperAppPluginDescriptor* example_plugin1_ep() {
+const FlipperAppPluginDescriptor* example_plugin1_ep(void) {
     return &example_plugin1_descriptor;
 }

applications/examples/example_plugins/plugin2.c

@@ -9,7 +9,7 @@
 
 #include <flipper_application/flipper_application.h>
 
-static int example_plugin2_method1() {
+static int example_plugin2_method1(void) {
     return 1337;
 }
 
@@ -32,6 +32,6 @@ static const FlipperAppPluginDescriptor example_plugin2_descriptor = {
 };
 
 /* Plugin entry point - must return a pointer to const descriptor */
-const FlipperAppPluginDescriptor* example_plugin2_ep() {
+const FlipperAppPluginDescriptor* example_plugin2_ep(void) {
     return &example_plugin2_descriptor;
 }

applications/examples/example_plugins/plugin_interface.h

@@ -11,6 +11,6 @@
 
 typedef struct {
     const char* name;
-    int (*method1)();
+    int (*method1)(void);
     int (*method2)(int, int);
 } ExamplePlugin;

applications/examples/example_plugins_advanced/app_api.c

@@ -8,7 +8,7 @@ void app_api_accumulator_set(uint32_t value) {
     accumulator = value;
 }
 
-uint32_t app_api_accumulator_get() {
+uint32_t app_api_accumulator_get(void) {
     return accumulator;
 }
 

applications/examples/example_plugins_advanced/app_api.h

@@ -15,7 +15,7 @@ extern "C" {
 
 void app_api_accumulator_set(uint32_t value);
 
-uint32_t app_api_accumulator_get();
+uint32_t app_api_accumulator_get(void);
 
 void app_api_accumulator_add(uint32_t value);
 

applications/examples/example_plugins_advanced/plugin1.c

@@ -18,7 +18,7 @@ static void advanced_plugin1_method1(int arg1) {
     app_api_accumulator_add(arg1);
 }
 
-static void advanced_plugin1_method2() {
+static void advanced_plugin1_method2(void) {
     /* Accumulator value is stored inside host application */
     FURI_LOG_I("TEST", "Plugin 1, accumulator: %lu", app_api_accumulator_get());
 }
@@ -38,6 +38,6 @@ static const FlipperAppPluginDescriptor advanced_plugin1_descriptor = {
 };
 
 /* Plugin entry point - must return a pointer to const descriptor */
-const FlipperAppPluginDescriptor* advanced_plugin1_ep() {
+const FlipperAppPluginDescriptor* advanced_plugin1_ep(void) {
     return &advanced_plugin1_descriptor;
 }

applications/examples/example_plugins_advanced/plugin2.c

@@ -18,7 +18,7 @@ static void advanced_plugin2_method1(int arg1) {
     app_api_accumulator_mul(arg1);
 }
 
-static void advanced_plugin2_method2() {
+static void advanced_plugin2_method2(void) {
     /* Accumulator value is stored inside host application */
     FURI_LOG_I("TEST", "Plugin 2, accumulator: %lu", app_api_accumulator_get());
 }
@@ -38,6 +38,6 @@ static const FlipperAppPluginDescriptor advanced_plugin2_descriptor = {
 };
 
 /* Plugin entry point - must return a pointer to const descriptor */
-const FlipperAppPluginDescriptor* advanced_plugin2_ep() {
+const FlipperAppPluginDescriptor* advanced_plugin2_ep(void) {
     return &advanced_plugin2_descriptor;
 }

applications/examples/example_plugins_advanced/plugin_interface.h

@@ -12,5 +12,5 @@
 typedef struct {
     const char* name;
     void (*method1)(int);
-    void (*method2)();
+    void (*method2)(void);
 } AdvancedPlugin;

applications/examples/example_thermo/example_thermo.c

@@ -315,7 +315,7 @@ static void example_thermo_run(ExampleThermoContext* context) {
 /******************** Initialisation & startup *****************************/
 
 /* Allocate the memory and initialise the variables */
-static ExampleThermoContext* example_thermo_context_alloc() {
+static ExampleThermoContext* example_thermo_context_alloc(void) {
     ExampleThermoContext* context = malloc(sizeof(ExampleThermoContext));
 
     context->view_port = view_port_alloc();