Mirror/Momentum-Firmware
1
0
Fork 0
mirror of https://github.com/Next-Flip/Momentum-Firmware.git synced 2026-07-28 01:58:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

Api Symbols: replace asserts with checks (#3507)

Browse Source 
* Api Symbols: replace asserts with checks
* Api Symbols: replace asserts with checks part 2
* Update no args function signatures with void, to help compiler to track incorrect usage
* More unavoidable void
* Update PVS config and code to make it happy
* Format sources
* nfc: fix checks
* dead code cleanup & include fixes

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>
Co-authored-by: hedger <hedger@nanode.su>
This commit is contained in:
あく
2024-03-19 23:43:52 +09:00
committed by GitHub
parent a09ec4d976
commit acc39a4bc0
571 changed files with 3565 additions and 2704 deletions
Download Patch File Download Diff File Expand all files Collapse all files
applications/services/cli/cli.c
+16 -14
View File
@@ -8,7 +8,7 @@
#define CLI_INPUT_LEN_LIMIT 256
Cli* cli_alloc() {
Cli* cli_alloc(void) {
Cli* cli = malloc(sizeof(Cli));
CliCommandTree_init(cli->commands);
@@ -27,14 +27,14 @@ Cli* cli_alloc() {
}
void cli_putc(Cli* cli, char c) {
furi_assert(cli);
furi_check(cli);
if(cli->session != NULL) {
cli->session->tx((uint8_t*)&c, 1);
}
}
char cli_getc(Cli* cli) {
furi_assert(cli);
furi_check(cli);
char c = 0;
if(cli->session != NULL) {
if(cli->session->rx((uint8_t*)&c, 1, FuriWaitForever) == 0) {
@@ -49,14 +49,14 @@ char cli_getc(Cli* cli) {
}
void cli_write(Cli* cli, const uint8_t* buffer, size_t size) {
furi_assert(cli);
furi_check(cli);
if(cli->session != NULL) {
cli->session->tx(buffer, size);
}
}
size_t cli_read(Cli* cli, uint8_t* buffer, size_t size) {
furi_assert(cli);
furi_check(cli);
if(cli->session != NULL) {
return cli->session->rx(buffer, size, FuriWaitForever);
} else {
@@ -65,7 +65,7 @@ size_t cli_read(Cli* cli, uint8_t* buffer, size_t size) {
}
size_t cli_read_timeout(Cli* cli, uint8_t* buffer, size_t size, uint32_t timeout) {
furi_assert(cli);
furi_check(cli);
if(cli->session != NULL) {
return cli->session->rx(buffer, size, timeout);
} else {
@@ -74,7 +74,7 @@ size_t cli_read_timeout(Cli* cli, uint8_t* buffer, size_t size, uint32_t timeout
}
bool cli_is_connected(Cli* cli) {
furi_assert(cli);
furi_check(cli);
if(cli->session != NULL) {
return (cli->session->is_connected());
}
@@ -82,7 +82,7 @@ bool cli_is_connected(Cli* cli) {
}
bool cli_cmd_interrupt_received(Cli* cli) {
furi_assert(cli);
furi_check(cli);
char c = '\0';
if(cli_is_connected(cli)) {
if(cli->session->rx((uint8_t*)&c, 1, 0) == 1) {
@@ -95,14 +95,14 @@ bool cli_cmd_interrupt_received(Cli* cli) {
}
void cli_print_usage(const char* cmd, const char* usage, const char* arg) {
furi_assert(cmd);
furi_assert(arg);
furi_assert(usage);
furi_check(cmd);
furi_check(arg);
furi_check(usage);
printf("%s: illegal option -- %s\r\nusage: %s %s", cmd, arg, cmd, usage);
}
void cli_motd() {
void cli_motd(void) {
printf("\r\n"
" _.-------.._ -,\r\n"
" .-\"```\"--..,,_/ /`-, -, \\ \r\n"
@@ -385,6 +385,7 @@ void cli_add_command(
CliCommandFlag flags,
CliCallback callback,
void* context) {
furi_check(cli);
FuriString* name_str;
name_str = furi_string_alloc_set(name);
furi_string_trim(name_str);
@@ -407,6 +408,7 @@ void cli_add_command(
}
void cli_delete_command(Cli* cli, const char* name) {
furi_check(cli);
FuriString* name_str;
name_str = furi_string_alloc_set(name);
furi_string_trim(name_str);
@@ -424,7 +426,7 @@ void cli_delete_command(Cli* cli, const char* name) {
}
void cli_session_open(Cli* cli, void* session) {
furi_assert(cli);
furi_check(cli);
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
cli->session = session;
@@ -439,7 +441,7 @@ void cli_session_open(Cli* cli, void* session) {
}
void cli_session_close(Cli* cli) {
furi_assert(cli);
furi_check(cli);
furi_check(furi_mutex_acquire(cli->mutex, FuriWaitForever) == FuriStatusOk);
if(cli->session != NULL) {
applications/services/cli/cli.h
+1 -1
View File
@@ -121,7 +121,7 @@ char cli_getc(Cli* cli);
/** New line Send new ine sequence
*/
void cli_nl();
void cli_nl(Cli* cli);
void cli_session_open(Cli* cli, void* session);
applications/services/cli/cli_command_gpio.c
+1 -1
View File
@@ -4,7 +4,7 @@
#include <furi_hal.h>
#include <lib/toolbox/args.h>
void cli_command_gpio_print_usage() {
void cli_command_gpio_print_usage(void) {
printf("Usage:\r\n");
printf("gpio <cmd> <args>\r\n");
printf("Cmd list:\r\n");
applications/services/cli/cli_commands.c
+2 -2
View File
@@ -83,7 +83,7 @@ void cli_command_help(Cli* cli, FuriString* args, void* context) {
};
if(furi_string_size(args) > 0) {
cli_nl();
cli_nl(cli);
printf("`");
printf("%s", furi_string_get_cstr(args));
printf("` command not found");
@@ -272,7 +272,7 @@ void cli_command_sysctl_heap_track(Cli* cli, FuriString* args, void* context) {
}
}
void cli_command_sysctl_print_usage() {
void cli_command_sysctl_print_usage(void) {
printf("Usage:\r\n");
printf("sysctl <cmd> <args>\r\n");
printf("Cmd list:\r\n");
applications/services/cli/cli_i.h
+1 -1
View File
@@ -54,7 +54,7 @@ struct Cli {
size_t cursor_position;
};
Cli* cli_alloc();
Cli* cli_alloc(void);
void cli_reset(Cli* cli);
applications/services/cli/cli_vcp.c
+2 -2
View File
@@ -64,7 +64,7 @@ static CliVcp* vcp = NULL;
static const uint8_t ascii_soh = 0x01;
static const uint8_t ascii_eot = 0x04;
static void cli_vcp_init() {
static void cli_vcp_init(void) {
if(vcp == NULL) {
vcp = malloc(sizeof(CliVcp));
vcp->tx_stream = furi_stream_buffer_alloc(VCP_TX_BUF_SIZE, 1);
@@ -80,7 +80,7 @@ static void cli_vcp_init() {
FURI_LOG_I(TAG, "Init OK");
}
static void cli_vcp_deinit() {
static void cli_vcp_deinit(void) {
furi_thread_flags_set(furi_thread_get_id(vcp->thread), VcpEvtStop);
furi_thread_join(vcp->thread);
furi_thread_free(vcp->thread);