Api Symbols: replace asserts with checks (#3507)

* Api Symbols: replace asserts with checks
* Api Symbols: replace asserts with checks part 2
* Update no args function signatures with void, to help compiler to track incorrect usage
* More unavoidable void
* Update PVS config and code to make it happy
* Format sources
* nfc: fix checks
* dead code cleanup & include fixes

Co-authored-by: gornekich <n.gorbadey@gmail.com>
Co-authored-by: hedger <hedger@users.noreply.github.com>
Co-authored-by: hedger <hedger@nanode.su>
This commit is contained in:
あく
2024-03-19 23:43:52 +09:00
committed by GitHub
parent a09ec4d976
commit acc39a4bc0
571 changed files with 3565 additions and 2704 deletions

View File

@@ -179,7 +179,7 @@ void ble_svc_serial_set_callbacks(
uint16_t buff_size,
SerialServiceEventCallback callback,
void* context) {
furi_assert(serial_svc);
furi_check(serial_svc);
serial_svc->callback = callback;
serial_svc->context = context;
serial_svc->buff_size = buff_size;
@@ -193,8 +193,8 @@ void ble_svc_serial_set_callbacks(
}
void ble_svc_serial_notify_buffer_is_empty(BleServiceSerial* serial_svc) {
furi_assert(serial_svc);
furi_assert(serial_svc->buff_size_mtx);
furi_check(serial_svc);
furi_check(serial_svc->buff_size_mtx);
furi_check(furi_mutex_acquire(serial_svc->buff_size_mtx, FuriWaitForever) == FuriStatusOk);
if(serial_svc->bytes_ready_to_receive == 0) {
@@ -253,7 +253,7 @@ bool ble_svc_serial_update_tx(BleServiceSerial* serial_svc, uint8_t* data, uint1
}
void ble_svc_serial_set_rpc_active(BleServiceSerial* serial_svc, bool active) {
furi_assert(serial_svc);
furi_check(serial_svc);
ble_svc_serial_update_rpc_char(
serial_svc, active ? SerialServiceRpcStatusActive : SerialServiceRpcStatusNotActive);
}