Mirror/Momentum-Firmware
1
0
Fork 0
mirror of https://github.com/Next-Flip/Momentum-Firmware.git synced 2026-07-30 02:18:11 -07:00
Code Issues Packages Projects Releases Wiki Activity

[FL-3488] Assign tickets to all TODO items (#2988)

Browse Source 
Co-authored-by: あく <alleteam@gmail.com>
This commit is contained in:
Astra
2023-08-23 02:56:27 +09:00
committed by GitHub
parent 200c44bdca
commit e353433cd8
66 changed files with 85 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/flipper_application/application_manifest.h
+1 -1
View File
@@ -16,7 +16,7 @@ extern "C" {
#define FAP_MANIFEST_SUPPORTED_VERSION 1
#define FAP_MANIFEST_MAX_APP_NAME_LENGTH 32
#define FAP_MANIFEST_MAX_ICON_SIZE 32 // TODO: reduce size?
#define FAP_MANIFEST_MAX_ICON_SIZE 32 // TODO FL-3524: reduce size?
#pragma pack(push, 1)
lib/flipper_application/elf/elf_file.c
+3 -3
View File
@@ -507,7 +507,7 @@ static SectionType elf_preload_section(
#endif
// ignore .ARM and .rel.ARM sections
// TODO: how to do it not by name?
// TODO FL-3525: how to do it not by name?
// .ARM: type 0x70000001, flags SHF_ALLOC | SHF_LINK_ORDER
// .rel.ARM: type 0x9, flags SHT_REL
if(str_prefix(name, ".ARM.") || str_prefix(name, ".rel.ARM.") ||
@@ -792,7 +792,7 @@ bool elf_file_load_section_table(ELFFile* elf) {
FuriString* name = furi_string_alloc();
FURI_LOG_D(TAG, "Scan ELF indexs...");
// TODO: why we start from 1?
// TODO FL-3526: why we start from 1?
for(size_t section_idx = 1; section_idx < elf->sections_count; section_idx++) {
Elf32_Shdr section_header;
@@ -828,7 +828,7 @@ ElfProcessSectionResult elf_process_section(
Elf32_Shdr section_header;
// find section
// TODO: why we start from 1?
// TODO FL-3526: why we start from 1?
for(size_t section_idx = 1; section_idx < elf->sections_count; section_idx++) {
furi_string_reset(section_name);
if(!elf_read_section(elf, section_idx, &section_header, section_name)) {