Mirror/Momentum-Firmware
1
0
Fork 0
mirror of https://github.com/Next-Flip/Momentum-Firmware.git synced 2026-04-24 03:29:57 -07:00
Code Issues Packages Projects Releases Wiki Activity

[FL-3488] Assign tickets to all TODO items (#2988)

Browse Source 
Co-authored-by: あく <alleteam@gmail.com>
This commit is contained in:
Astra
2023-08-23 02:56:27 +09:00
committed by GitHub
parent 200c44bdca
commit e353433cd8
66 changed files with 85 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/subghz/protocols/bin_raw.c
View File

@@ -744,7 +744,7 @@ static bool
bin_raw_debug("\r\n\r\n");
#endif
//todo can be optimized
//TODO FL-3557: can be optimized
BinRAW_Markup markup_temp[BIN_RAW_MAX_MARKUP_COUNT];
memcpy(
markup_temp,
@@ -770,7 +770,7 @@ static bool
}
}
}
//todo can be optimized
//TODO FL-3557: can be optimized
if(bin_raw_type == BinRAWTypeGap) {
if(data_temp != 0) { //there are sequences with the same number of bits

6
lib/subghz/protocols/keeloq.c
View File

@@ -122,7 +122,7 @@ static bool subghz_protocol_keeloq_gen_data(SubGhzProtocolEncoderKeeloq* instanc
uint32_t fix = (uint32_t)btn << 28 | instance->generic.serial;
uint32_t decrypt = (uint32_t)btn << 28 |
(instance->generic.serial & 0x3FF)
<< 16 | //ToDo in some protocols the discriminator is 0
<< 16 | //TODO FL-3558: in some protocols the discriminator is 0
instance->generic.cnt;
uint32_t hop = 0;
uint64_t man = 0;
@@ -149,7 +149,7 @@ static bool subghz_protocol_keeloq_gen_data(SubGhzProtocolEncoderKeeloq* instanc
hop = subghz_protocol_keeloq_common_encrypt(decrypt, man);
break;
case KEELOQ_LEARNING_UNKNOWN:
hop = 0; //todo
hop = 0; //TODO FL-3559
break;
}
break;
@@ -200,7 +200,7 @@ static bool
//gen new key
if(subghz_protocol_keeloq_gen_data(instance, btn)) {
//ToDo if you need to add a callback to automatically update the data on the display
//TODO FL-3560: if you need to add a callback to automatically update the data on the display
} else {
return false;
}

3
lib/subghz/protocols/raw.c
View File

@@ -265,7 +265,7 @@ SubGhzProtocolStatus
furi_assert(context);
UNUSED(context);
UNUSED(flipper_format);
//ToDo stub, for backwards compatibility
// stub, for backwards compatibility
return SubGhzProtocolStatusOk;
}
@@ -273,7 +273,6 @@ void subghz_protocol_decoder_raw_get_string(void* context, FuriString* output) {
furi_assert(context);
//SubGhzProtocolDecoderRAW* instance = context;
UNUSED(context);
//ToDo no use
furi_string_cat_printf(output, "RAW Date");
}

2
lib/subghz/protocols/secplus_v2.c
View File

@@ -380,7 +380,7 @@ static void subghz_protocol_secplus_v2_encode(SubGhzProtocolEncoderSecPlus_v2* i
uint8_t roll_2[9] = {0};
instance->generic.cnt++;
//ToDo it is not known what value the counter starts
//TODO Fl-3548: it is not known what value the counter starts
if(instance->generic.cnt > 0xFFFFFFF) instance->generic.cnt = 0xE500000;
uint32_t rolling = subghz_protocol_blocks_reverse_key(instance->generic.cnt, 28);