global: snapshot

crates/brk_computer/src/internal/multi/from_tx/value_dollars.rs

@@ -12,15 +12,14 @@ use brk_types::{
 };
 use derive_more::{Deref, DerefMut};
 use vecdb::{
-    AnyStoredVec, AnyVec, Database, EagerVec, Exit, GenericStoredVec, ImportableVec,
-    IterableBoxedVec, IterableCloneableVec, IterableVec, LazyVecFrom3,
+    Database, EagerVec, Exit, ImportableVec, IterableBoxedVec, IterableCloneableVec, LazyVecFrom3,
 };
 
 use crate::{
     ComputeIndexes, indexes,
     internal::{
         CumulativeVec, Full, LazyBinaryTransformFull, LazyDateDerivedFull, LazyFull,
-        SatsTimesClosePrice, Stats,
+        SatsTimesClosePrice, Stats, compute_cumulative,
     },
 };
 
@@ -137,7 +136,12 @@ impl ValueDollarsFromTxFull {
         exit: &Exit,
     ) -> Result<()> {
         // Compute height cumulative by summing lazy height.sum values
-        self.compute_height_cumulative(starting_indexes.height, exit)?;
+        compute_cumulative(
+            starting_indexes.height,
+            &self.height.sum,
+            &mut self.height_cumulative.0,
+            exit,
+        )?;
 
         // Compute dateindex stats by aggregating lazy height stats
         self.dateindex.compute(
@@ -150,30 +154,6 @@ impl ValueDollarsFromTxFull {
 
         Ok(())
     }
-
-    /// Compute cumulative USD by summing `sum_sats[h] * price[h]` for all heights.
-    fn compute_height_cumulative(&mut self, max_from: Height, exit: &Exit) -> Result<()> {
-        let starting_height = max_from.min(Height::from(self.height_cumulative.0.len()));
-
-        let mut cumulative = starting_height.decremented().map_or(Dollars::ZERO, |h| {
-            self.height_cumulative.0.iter().get_unwrap(h)
-        });
-
-        let mut sum_iter = self.height.sum.iter();
-        let start_idx = *starting_height as usize;
-        let end_idx = sum_iter.len();
-
-        for h in start_idx..end_idx {
-            let sum_usd = sum_iter.get_unwrap(Height::from(h));
-            cumulative += sum_usd;
-            self.height_cumulative.0.truncate_push_at(h, cumulative)?;
-        }
-
-        let _lock = exit.lock();
-        self.height_cumulative.0.write()?;
-
-        Ok(())
-    }
 }
 
 fn create_lazy_txindex(

crates/brk_computer/src/internal/multi/height_derived/full.rs

@@ -11,8 +11,8 @@ use vecdb::{Database, Exit, IterableBoxedVec, IterableCloneableVec, IterableVec}
 use crate::{
     ComputeIndexes, indexes,
     internal::{
-        ComputedVecValue, CumulativeVec, LazyDateDerivedFull, Full, LazyFull, NumericValue,
-        compute_cumulative_extend,
+        ComputedVecValue, CumulativeVec, Full, LazyDateDerivedFull, LazyFull, NumericValue,
+        compute_cumulative,
     },
 };
 
@@ -102,6 +102,6 @@ where
         height_source: &impl IterableVec<Height, T>,
         exit: &Exit,
     ) -> Result<()> {
-        compute_cumulative_extend(max_from, height_source, &mut self.height_cumulative.0, exit)
+        compute_cumulative(max_from, height_source, &mut self.height_cumulative.0, exit)
     }
 }

crates/brk_computer/src/internal/multi/height_derived/sum_cum.rs

@@ -15,7 +15,7 @@ use crate::{
     ComputeIndexes, indexes,
     internal::{
         ComputedVecValue, CumulativeVec, LazyDateDerivedSumCum, LazySumCum, NumericValue, SumCum,
-        compute_cumulative_extend,
+        compute_cumulative,
     },
 };
 
@@ -99,7 +99,7 @@ where
         source: &impl IterableVec<Height, T>,
         exit: &Exit,
     ) -> Result<()> {
-        compute_cumulative_extend(max_from, source, &mut self.height_cumulative.0, exit)
+        compute_cumulative(max_from, source, &mut self.height_cumulative.0, exit)
     }
 
     fn compute_dateindex_sum_cum(