Mirror/brk
1
0
Fork 0
mirror of https://github.com/bitcoinresearchkit/brk.git synced 2026-07-29 11:48:12 -07:00
Code Issues Packages Projects Releases Wiki Activity

refactor: reduce verbosity and use vecdb cumulative function

Browse Source 
- Remove verbose inline comments from compute.rs
- Update vecdb to 0.6.1
- Refactor HODL Bank to use compute_cumulative_transformed_binary
This commit is contained in:
Brandon Collins
2026-01-21 12:20:53 -05:00
parent 9dda513f84
commit 581a800612
3 changed files with 16 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
crates/brk_computer/src/cointime/reserve_risk/compute.rs
+9 -41
View File
@@ -1,6 +1,6 @@
use brk_error::Result;
use brk_types::{DateIndex, StoredF64};
use vecdb::{AnyStoredVec, AnyVec, Exit, GenericStoredVec, IterableVec, VecIndex};
use brk_types::{Close, Dollars, StoredF64};
use vecdb::Exit;
use super::{super::value, Vecs};
use crate::{price, ComputeIndexes};
@@ -13,11 +13,8 @@ impl Vecs {
value: &value::Vecs,
exit: &Exit,
) -> Result<()> {
// Get VOCDD dateindex sum data (from cointime/value module)
// The dateindex.sum.0 contains daily VOCDD values as EagerVec
let vocdd_dateindex_sum = &value.vocdd.dateindex.sum.0;
// Compute 365-day SMA of VOCDD
self.vocdd_365d_sma.compute_sma(
starting_indexes.dateindex,
vocdd_dateindex_sum,
@@ -27,43 +24,14 @@ impl Vecs {
let price_close = &price.usd.split.close.dateindex;
// Compute HODL Bank = cumulative sum of (price - vocdd_sma)
// Start from where we left off and maintain cumulative state
let starting_dateindex = starting_indexes
.dateindex
.to_usize()
.min(self.hodl_bank.len());
let target_len = price_close.len().min(self.vocdd_365d_sma.len());
self.hodl_bank.compute_cumulative_transformed_binary(
starting_indexes.dateindex,
price_close,
&self.vocdd_365d_sma,
|price: Close<Dollars>, sma: StoredF64| StoredF64::from(f64::from(price) - f64::from(sma)),
exit,
)?;
if target_len > starting_dateindex {
let mut price_iter = price_close.iter();
let mut vocdd_sma_iter = self.vocdd_365d_sma.iter();
// Get previous cumulative value, or start at 0
let mut cumulative: f64 = if starting_dateindex > 0 {
let prev_dateindex = DateIndex::from(starting_dateindex - 1);
f64::from(*self.hodl_bank.iter().get_unwrap(prev_dateindex))
} else {
0.0
};
for i in starting_dateindex..target_len {
let dateindex = DateIndex::from(i);
let price_val = f64::from(*price_iter.get_unwrap(dateindex));
let vocdd_sma = f64::from(*vocdd_sma_iter.get_unwrap(dateindex));
// HODL Bank contribution: price - smoothed VOCDD
// Accumulate over time
cumulative += price_val - vocdd_sma;
self.hodl_bank
.truncate_push_at(i, StoredF64::from(cumulative))?;
}
let _lock = exit.lock();
self.hodl_bank.write()?;
}
// Compute Reserve Risk = price / hodl_bank (if enabled)
if let Some(reserve_risk) = self.reserve_risk.as_mut() {
reserve_risk.compute_all(starting_indexes, exit, |v| {
v.compute_divide(