Address review feedback

This commit is contained in:
deadmanoz
2025-07-15 08:48:39 -07:00
parent 5de9757d46
commit 94d4b05c29
4 changed files with 8 additions and 7 deletions

5
.gitignore vendored
View File

@@ -21,3 +21,8 @@ _*
# Environment variables/configs
.env
# Profiling
profile.json.gz
flamegraph.svg
*.trace

View File

@@ -52,7 +52,6 @@ pub fn run() -> color_eyre::Result<()> {
.enable_all()
.build()?
.block_on(async {
// Always start the server
let served_indexer = indexer.clone();
let served_computer = computer.clone();
@@ -66,7 +65,6 @@ pub fn run() -> color_eyre::Result<()> {
sleep(Duration::from_secs(1));
// Always run the processor
loop {
wait_for_synced_node(rpc)?;

View File

@@ -43,10 +43,10 @@ pub struct Parser {
}
impl Parser {
pub fn new(blocks_dir: PathBuf, brk_dir: PathBuf, rpc: &'static bitcoincore_rpc::Client) -> Self {
pub fn new(blocks_dir: PathBuf, outputs_dir: PathBuf, rpc: &'static bitcoincore_rpc::Client) -> Self {
Self {
blocks_dir,
outputs_dir: brk_dir,
outputs_dir: outputs_dir,
rpc
}
}

View File

@@ -39,8 +39,6 @@ BRK runs as a single container that includes both the blockchain processor and A
- Simplifies deployment and monitoring
- Uses a single shared data directory
The container runs the BRK binary which provides both processor and server functionality.
```bash
# Start BRK
docker compose -f docker/docker-compose.yml up
@@ -210,7 +208,7 @@ docker compose -f docker/docker-compose.yml logs -f
### Performance Issues
#### Slow indexing
- Ensure adequate disk space for indexed data
- Ensure adequate disk space for indexed data - a minimum of 3GB/s is recommended
- Monitor memory usage during initial indexing
- Use `BRK_COMPUTATION=lazy` to reduce memory usage