From baa7c9cc2210c539b84870c2f39c26b67b1f3b80 Mon Sep 17 00:00:00 2001
From: nym21 <expat-epochs0i@icloud.com>
Date: Mon, 20 Oct 2025 12:18:48 +0200
Subject: [PATCH] store: fix hang ?

---
 crates/brk_indexer/src/stores_v2.rs |  4 ++--
 crates/brk_store/src/v2/meta.rs     |  8 +++----
 crates/brk_store/src/v2/mod.rs      | 33 +++++++++++++++++------------
 3 files changed, 25 insertions(+), 20 deletions(-)

diff --git a/crates/brk_indexer/src/stores_v2.rs b/crates/brk_indexer/src/stores_v2.rs
index c0c589a39..8e3829312 100644
--- a/crates/brk_indexer/src/stores_v2.rs
+++ b/crates/brk_indexer/src/stores_v2.rs
@@ -7,7 +7,7 @@ use brk_structs::{
     AddressBytes, AddressBytesHash, BlockHashPrefix, Height, StoredString, TxIndex, TxOutIndex,
     TxidPrefix, TypeIndex, TypeIndexAndOutPoint, TypeIndexAndTxIndex, Unit, Version,
 };
-use fjall2::{Keyspace, PersistMode};
+use fjall2::{Keyspace, PersistMode, TransactionalKeyspace};
 use rayon::prelude::*;
 use vecdb::{AnyVec, StoredIndex, VecIterator};
 
@@ -17,7 +17,7 @@ use super::Vecs;
 
 #[derive(Clone)]
 pub struct Stores {
-    pub keyspace: Keyspace,
+    pub keyspace: TransactionalKeyspace,
 
     pub addressbyteshash_to_typeindex: Store<AddressBytesHash, TypeIndex>,
     pub blockhashprefix_to_height: Store<BlockHashPrefix, Height>,
diff --git a/crates/brk_store/src/v2/meta.rs b/crates/brk_store/src/v2/meta.rs
index e0e0b483b..9276bb035 100644
--- a/crates/brk_store/src/v2/meta.rs
+++ b/crates/brk_store/src/v2/meta.rs
@@ -5,7 +5,7 @@ use std::{
 
 use brk_error::Result;
 use brk_structs::Version;
-use fjall2::{Keyspace, PartitionHandle, PersistMode};
+use fjall2::{PersistMode, TransactionalKeyspace, TransactionalPartitionHandle};
 
 use super::Height;
 
@@ -18,13 +18,13 @@ pub struct StoreMeta {
 
 impl StoreMeta {
     pub fn checked_open<F>(
-        keyspace: &Keyspace,
+        keyspace: &TransactionalKeyspace,
         path: &Path,
         version: Version,
         open_partition_handle: F,
-    ) -> Result<(Self, PartitionHandle)>
+    ) -> Result<(Self, TransactionalPartitionHandle)>
     where
-        F: Fn() -> Result<PartitionHandle>,
+        F: Fn() -> Result<TransactionalPartitionHandle>,
     {
         fs::create_dir_all(path)?;
 
diff --git a/crates/brk_store/src/v2/mod.rs b/crates/brk_store/src/v2/mod.rs
index ea49c04f7..9671b15d0 100644
--- a/crates/brk_store/src/v2/mod.rs
+++ b/crates/brk_store/src/v2/mod.rs
@@ -3,7 +3,10 @@ use std::{borrow::Cow, fmt::Debug, fs, hash::Hash, path::Path};
 use brk_error::Result;
 use brk_structs::{Height, Version};
 use byteview6::ByteView;
-use fjall2::{InnerItem, Keyspace, PartitionCreateOptions, PartitionHandle, PersistMode};
+use fjall2::{
+    InnerItem, PartitionCreateOptions, PersistMode, TransactionalKeyspace,
+    TransactionalPartitionHandle,
+};
 use rustc_hash::{FxHashMap, FxHashSet};
 
 use crate::any::AnyStore;
@@ -16,20 +19,18 @@ use meta::*;
 pub struct StoreV2<Key, Value> {
     meta: StoreMeta,
     name: &'static str,
-    keyspace: Keyspace,
-    // no, make this faster
-    // no ! remove it altogether, reset too
-    partition: PartitionHandle,
+    keyspace: TransactionalKeyspace,
+    partition: TransactionalPartitionHandle,
     puts: FxHashMap<Key, Value>,
     dels: FxHashSet<Key>,
 }
 
 const MAJOR_FJALL_VERSION: Version = Version::TWO;
 
-pub fn open_keyspace(path: &Path) -> fjall2::Result<Keyspace> {
+pub fn open_keyspace(path: &Path) -> fjall2::Result<TransactionalKeyspace> {
     fjall2::Config::new(path.join("fjall"))
         .max_write_buffer_size(32 * 1024 * 1024)
-        .open()
+        .open_transactional()
 }
 
 impl<K, V> StoreV2<K, V>
@@ -39,10 +40,10 @@ where
     ByteView: From<K> + From<V>,
 {
     fn open_partition_handle(
-        keyspace: &Keyspace,
+        keyspace: &TransactionalKeyspace,
         name: &str,
         bloom_filters: Option<bool>,
-    ) -> Result<PartitionHandle> {
+    ) -> Result<TransactionalPartitionHandle> {
         let mut options = PartitionCreateOptions::default()
             .max_memtable_size(8 * 1024 * 1024)
             .manual_journal_persist(true);
@@ -55,7 +56,7 @@ where
     }
 
     pub fn import(
-        keyspace: &Keyspace,
+        keyspace: &TransactionalKeyspace,
         path: &Path,
         name: &str,
         version: Version,
@@ -100,12 +101,16 @@ where
     }
 
     pub fn is_empty(&self) -> Result<bool> {
-        self.partition.is_empty().map_err(|e| e.into())
+        self.keyspace
+            .read_tx()
+            .is_empty(&self.partition)
+            .map_err(|e| e.into())
     }
 
     pub fn iter(&self) -> impl Iterator<Item = (K, V)> {
-        self.partition
-            .iter()
+        self.keyspace
+            .read_tx()
+            .iter(&self.partition)
             .map(|res| res.unwrap())
             .map(|(k, v)| (K::from(ByteView::from(&*k)), V::from(ByteView::from(&*v))))
     }
@@ -174,7 +179,7 @@ where
 
         self.keyspace
             .batch()
-            .commit_single_partition(&self.partition, items)?;
+            .commit_single_partition(self.partition.inner(), items)?;
 
         Ok(())
     }