mirror of
https://github.com/jeremyd/ergo.git
synced 2026-06-06 05:01:54 -07:00
Merge pull request #1783 from slingamn/scram_mechanisms
remove SCRAM-SHA-256 from advertised SASL mechanisms
This commit is contained in:
+7
-1
@@ -303,6 +303,7 @@ func (t *ThrottleConfig) UnmarshalYAML(unmarshal func(interface{}) error) (err e
|
|||||||
type AccountConfig struct {
|
type AccountConfig struct {
|
||||||
Registration AccountRegistrationConfig
|
Registration AccountRegistrationConfig
|
||||||
AuthenticationEnabled bool `yaml:"authentication-enabled"`
|
AuthenticationEnabled bool `yaml:"authentication-enabled"`
|
||||||
|
AdvertiseSCRAM bool `yaml:"advertise-scram"` // undocumented, see #1782
|
||||||
RequireSasl struct {
|
RequireSasl struct {
|
||||||
Enabled bool
|
Enabled bool
|
||||||
Exempted []string
|
Exempted []string
|
||||||
@@ -1379,7 +1380,12 @@ func LoadConfig(filename string) (config *Config, err error) {
|
|||||||
config.Accounts.VHosts.validRegexp = defaultValidVhostRegex
|
config.Accounts.VHosts.validRegexp = defaultValidVhostRegex
|
||||||
}
|
}
|
||||||
|
|
||||||
config.Server.capValues[caps.SASL] = "PLAIN,EXTERNAL,SCRAM-SHA-256"
|
saslCapValue := "PLAIN,EXTERNAL,SCRAM-SHA-256"
|
||||||
|
// TODO(#1782) clean this up:
|
||||||
|
if !config.Accounts.AdvertiseSCRAM {
|
||||||
|
saslCapValue = "PLAIN,EXTERNAL"
|
||||||
|
}
|
||||||
|
config.Server.capValues[caps.SASL] = saslCapValue
|
||||||
if !config.Accounts.AuthenticationEnabled {
|
if !config.Accounts.AuthenticationEnabled {
|
||||||
config.Server.supportedCaps.Disable(caps.SASL)
|
config.Server.supportedCaps.Disable(caps.SASL)
|
||||||
}
|
}
|
||||||
|
|||||||
+1
-1
Submodule irctest updated: 9de76b6063...125a1cc106
Reference in New Issue
Block a user