From 86ad402203c6d3ebee97cad0ebdae370d8c2c820 Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Fri, 12 Jul 2019 09:58:14 -0400 Subject: [PATCH] review feedback --- irc/server.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/irc/server.go b/irc/server.go index a4bb1889..b3b9c351 100644 --- a/irc/server.go +++ b/irc/server.go @@ -884,9 +884,13 @@ func (server *Server) setupListeners(config *Config) (err error) { // create new listeners that were not previously configured numTlsListeners := 0 + hasStandardTlsListener := false for newAddr, newConfig := range config.Server.trueListeners { if newConfig.TLSConfig != nil { numTlsListeners += 1 + if strings.HasSuffix(newAddr, ":6697") { + hasStandardTlsListener = true + } } _, exists := server.listeners[newAddr] if !exists { @@ -906,7 +910,7 @@ func (server *Server) setupListeners(config *Config) (err error) { server.logger.Warning("server", "You are not exposing an SSL/TLS listening port. You should expose at least one port (typically 6697) to accept TLS connections") } - if config.Server.trueListeners[":6697"].TLSConfig == nil { + if !hasStandardTlsListener { server.logger.Warning("server", "Port 6697 is the standard TLS port for IRC. You should (also) expose port 6697 as a TLS port to ensure clients can connect securely") }