From ef35c587fc1528050ce306848127bb79a51ba7ba Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Tue, 24 Apr 2018 20:23:01 -0400 Subject: [PATCH] remove redundant friends computation --- irc/client.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/irc/client.go b/irc/client.go index d45598ce..0e1b15de 100644 --- a/irc/client.go +++ b/irc/client.go @@ -684,8 +684,6 @@ func (client *Client) destroy(beingResumed bool) { // send quit/error message to client if they haven't been sent already client.Quit("Connection closed") - friends := client.Friends() - friends.Remove(client) if !beingResumed { client.server.whoWas.Append(client) } @@ -703,6 +701,7 @@ func (client *Client) destroy(beingResumed bool) { client.server.monitorManager.RemoveAll(client) // clean up channels + friends := make(ClientSet) for _, channel := range client.Channels() { if !beingResumed { channel.Quit(client) @@ -711,6 +710,7 @@ func (client *Client) destroy(beingResumed bool) { friends.Add(member) } } + friends.Remove(client) // clean up server if !beingResumed {