From 6cbe94cf20b157006fc900aa5259843cb4076dd0 Mon Sep 17 00:00:00 2001
From: Smittix <jamessmith1@outlook.com>
Date: Sat, 28 Feb 2026 17:35:46 +0000
Subject: [PATCH] fix: restore flask-limiter as mandatory dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Rate limiting on login is a security requirement, not optional.
Reverts the no-op fallback — if flask-limiter is missing, the app
will fail fast with a clear import error rather than silently
running without rate limiting.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 app.py   | 29 ++++++++---------------------
 setup.sh |  6 +++---
 2 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/app.py b/app.py
index f1870be..10d1baa 100644
--- a/app.py
+++ b/app.py
@@ -42,12 +42,8 @@ from utils.constants import (
     QUEUE_MAX_SIZE,
 )
 import logging
-try:
-    from flask_limiter import Limiter
-    from flask_limiter.util import get_remote_address
-    _has_limiter = True
-except ImportError:
-    _has_limiter = False
+from flask_limiter import Limiter
+from flask_limiter.util import get_remote_address
 # Track application start time for uptime calculation
 import time as _time
 _app_start_time = _time.time()
@@ -57,21 +53,12 @@ logger = logging.getLogger('intercept.database')
 app = Flask(__name__)
 app.secret_key = "signals_intelligence_secret" # Required for flash messages
 
-# Set up rate limiting (optional — flask-limiter may not be installed)
-if _has_limiter:
-    limiter = Limiter(
-        key_func=get_remote_address,
-        app=app,
-        storage_uri="memory://",
-    )
-else:
-    class _NoopLimiter:
-        """Fallback when flask-limiter is not installed."""
-        def limit(self, *args, **kwargs):
-            def decorator(f):
-                return f
-            return decorator
-    limiter = _NoopLimiter()
+# Set up rate limiting
+limiter = Limiter(
+    key_func=get_remote_address,
+    app=app,
+    storage_uri="memory://",
+)
 
 # Disable Werkzeug debugger PIN (not needed for local development tool)
 os.environ['WERKZEUG_DEBUG_PIN'] = 'off'
diff --git a/setup.sh b/setup.sh
index cbd6135..67d6878 100755
--- a/setup.sh
+++ b/setup.sh
@@ -326,9 +326,9 @@ install_python_deps() {
     "Werkzeug>=3.1.5" "pyserial>=3.5" "flask-sock" "websocket-client>=1.6.0" 2>/dev/null || true
 
   # Verify critical packages
-  $PY -c "import flask; import requests" 2>/dev/null || {
-    fail "Critical Python packages (flask, requests) not installed"
-    echo "Try: venv/bin/pip install flask requests"
+  $PY -c "import flask; import requests; from flask_limiter import Limiter" 2>/dev/null || {
+    fail "Critical Python packages (flask, requests, flask-limiter) not installed"
+    echo "Try: venv/bin/pip install flask requests flask-limiter"
     exit 1
   }
   ok "Core Python packages installed"