From 7f13af3fcd9c601b999ee531b5d381943fc96b95 Mon Sep 17 00:00:00 2001
From: Smittix <jamessmith1@outlook.com>
Date: Wed, 18 Feb 2026 17:01:13 +0000
Subject: [PATCH] fix: Prevent apt librtlsdr-dev reinstalling librtlsdr0 after
 Blog install

When Blog drivers are installed, apt rtl-sdr/librtlsdr0/librtlsdr-dev
are removed to ensure the Blog library in /usr/local/lib is the only
one ldconfig sees.  But four source-build functions each called
`apt_install librtlsdr-dev`, which re-pulled librtlsdr0 from apt and
immediately re-shadowed the Blog library.

Fix: each function now checks `pkg-config --exists librtlsdr` first;
if the Blog drivers (or any other /usr/local install) already provide
the headers and .pc file the apt install is skipped entirely.

Also add a post-removal guard in install_rtlsdr_blog_drivers_debian:
after apt removes librtlsdr0 it may silently sweep out dump1090-mutability
as a reverse dep.  The guard detects this and rebuilds dump1090 from
source immediately, using the Blog drivers' headers via pkg-config.

Affected functions:
- install_dump1090_from_source_debian
- install_acarsdec_from_source_debian
- install_dumpvdl2_from_source_debian
- install_aiscatcher_from_source_debian

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 setup.sh | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/setup.sh b/setup.sh
index 340d846..d9e81ca 100755
--- a/setup.sh
+++ b/setup.sh
@@ -1088,8 +1088,11 @@ install_dump1090_from_source_debian() {
   info "dump1090 not available via APT. Building from source (required)..."
 
   apt_install build-essential git pkg-config \
-    librtlsdr-dev libusb-1.0-0-dev \
+    libusb-1.0-0-dev \
     libncurses-dev tcl-dev python3-dev
+  # If Blog drivers are installed they supply headers via pkg-config;
+  # installing apt librtlsdr-dev would pull librtlsdr0 back and shadow them.
+  pkg-config --exists librtlsdr 2>/dev/null || apt_install librtlsdr-dev
 
   local JOBS
   JOBS="$(nproc 2>/dev/null || echo 1)"
@@ -1153,7 +1156,8 @@ install_acarsdec_from_source_debian() {
   info "acarsdec not available via APT. Building from source..."
 
   apt_install build-essential git cmake \
-    librtlsdr-dev libusb-1.0-0-dev libsndfile1-dev
+    libusb-1.0-0-dev libsndfile1-dev
+  pkg-config --exists librtlsdr 2>/dev/null || apt_install librtlsdr-dev
 
   # Run in subshell to isolate EXIT trap
   (
@@ -1181,7 +1185,8 @@ install_dumpvdl2_from_source_debian() {
   info "Building dumpvdl2 from source (with libacars dependency)..."
 
   apt_install build-essential git cmake \
-    librtlsdr-dev libusb-1.0-0-dev libglib2.0-dev libxml2-dev
+    libusb-1.0-0-dev libglib2.0-dev libxml2-dev
+  pkg-config --exists librtlsdr 2>/dev/null || apt_install librtlsdr-dev
 
   (
     tmp_dir="$(mktemp -d)"
@@ -1227,7 +1232,8 @@ install_aiscatcher_from_source_debian() {
   info "AIS-catcher not available via APT. Building from source..."
 
   apt_install build-essential git cmake pkg-config \
-    librtlsdr-dev libusb-1.0-0-dev libcurl4-openssl-dev zlib1g-dev
+    libusb-1.0-0-dev libcurl4-openssl-dev zlib1g-dev
+  pkg-config --exists librtlsdr 2>/dev/null || apt_install librtlsdr-dev
 
   # Run in subshell to isolate EXIT trap
   (
@@ -1340,6 +1346,15 @@ install_rtlsdr_blog_drivers_debian() {
       warn "See: https://github.com/rtlsdrblog/rtl-sdr-blog"
     fi
   )
+
+  # apt may have removed dump1090-mutability (or similar) as a reverse
+  # dependency of librtlsdr0.  Rebuild from source now so the ADS-B
+  # decoder is available.  The source build functions above now guard
+  # against pulling apt librtlsdr-dev back in, so this is safe.
+  if ! cmd_exists dump1090 && ! cmd_exists dump1090-mutability; then
+    info "Rebuilding dump1090 from source (removed as reverse dep of librtlsdr0)..."
+    install_dump1090_from_source_debian
+  fi
 }
 
 setup_udev_rules_debian() {