fix(modes): deep-linked mode scripts fail when body not yet parsed

ensureModeScript() used document.body.appendChild() to load lazy mode scripts, but the preload for ?mode= query params runs in <head> before <body> exists, causing all deep-linked modes to silently fail. Also fix cross-mode handoffs (BT→BT Locate, WiFi→WiFi Locate, Spy Stations→Waterfall) that assumed target module was already loaded. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-07-01 06:19:00 -07:00 · 2026-03-12 20:49:08 +00:00
parent e687862043
commit 90281b1535
87 changed files with 9128 additions and 8368 deletions
@@ -1,5 +1,8 @@
 """Pytest configuration and fixtures."""

+import sqlite3
+from unittest.mock import MagicMock, patch
+
 import pytest
 from app import app as flask_app
 from routes import register_blueprints
@@ -9,6 +12,8 @@ from routes import register_blueprints
 def app():
    """Create application for testing."""
    flask_app.config['TESTING'] = True
+    # Disable CSRF for tests
+    flask_app.config['WTF_CSRF_ENABLED'] = False
    # Register blueprints only if not already registered
    if 'pager' not in flask_app.blueprints:
        register_blueprints(flask_app)
@@ -19,3 +24,110 @@ def app():
 def client(app):
    """Create test client."""
    return app.test_client()
+
+
+@pytest.fixture
+def mock_subprocess():
+    """Patch subprocess.Popen and subprocess.run with configurable returns.
+
+    Usage:
+        def test_example(mock_subprocess):
+            mock_subprocess['run'].return_value.stdout = 'output'
+            mock_subprocess['run'].return_value.returncode = 0
+    """
+    with patch('subprocess.Popen') as mock_popen, \
+         patch('subprocess.run') as mock_run:
+        mock_process = MagicMock()
+        mock_process.poll.return_value = None
+        mock_process.stdout = MagicMock()
+        mock_process.stderr = MagicMock()
+        mock_process.pid = 12345
+        mock_popen.return_value = mock_process
+
+        mock_run.return_value = MagicMock(
+            returncode=0, stdout='', stderr=''
+        )
+
+        yield {
+            'popen': mock_popen,
+            'process': mock_process,
+            'run': mock_run,
+        }
+
+
+@pytest.fixture
+def mock_sdr_device():
+    """Return a mock SDRDevice with configurable type and index.
+
+    Usage:
+        def test_example(mock_sdr_device):
+            device = mock_sdr_device(device_type='rtlsdr', index=0)
+    """
+    def _factory(device_type='rtlsdr', index=0):
+        device = MagicMock()
+        device.device_type = device_type
+        device.device_index = index
+        device.name = f'Mock {device_type} #{index}'
+        device.is_available.return_value = True
+        device.build_command.return_value = ['rtl_fm', '-f', '100M']
+        return device
+    return _factory
+
+
+@pytest.fixture
+def mock_app_state():
+    """Patch common app module attributes for route tests.
+
+    Provides mock process, queue, and lock objects on the app module.
+    """
+    import app as app_module
+    import queue
+
+    mock_process = MagicMock()
+    mock_process.poll.return_value = None
+    mock_queue = queue.Queue()
+    mock_lock = MagicMock()
+
+    patches = {
+        'current_process': mock_process,
+        'pager_queue': mock_queue,
+        'pager_lock': mock_lock,
+    }
+    originals = {}
+    for attr, value in patches.items():
+        originals[attr] = getattr(app_module, attr, None)
+        setattr(app_module, attr, value)
+
+    yield {
+        'process': mock_process,
+        'queue': mock_queue,
+        'lock': mock_lock,
+        'module': app_module,
+    }
+
+    for attr, orig in originals.items():
+        if orig is None:
+            try:
+                delattr(app_module, attr)
+            except AttributeError:
+                pass
+        else:
+            setattr(app_module, attr, orig)
+
+
+@pytest.fixture
+def mock_check_tool():
+    """Patch check_tool() to return True for all tools."""
+    with patch('utils.dependencies.check_tool', return_value=True) as mock:
+        yield mock
+
+
+@pytest.fixture
+def test_db(tmp_path):
+    """Provide an isolated in-memory SQLite database for tests."""
+    db_path = tmp_path / 'test.db'
+    conn = sqlite3.connect(str(db_path))
+    conn.row_factory = sqlite3.Row
+    conn.execute('PRAGMA journal_mode = WAL')
+    yield conn
+    conn.close()
@@ -29,8 +29,7 @@ def test_predict_passes_invalid_coords(client):
 def test_fetch_celestrak_invalid_category(client):
    """Verify that an unauthorized category is rejected."""
    response = client.get('/satellite/celestrak/category_fake')
-    # The code returns 200 but includes an error message in the JSON body
-    assert response.status_code == 200 
+    assert response.status_code == 400
    assert response.json['status'] == 'error'
    assert 'Invalid category' in response.json['message']

@@ -173,8 +173,8 @@ def test_capture_pmkid_path_traversal_prevention(client):
    """Ensure the status check rejects invalid paths."""
    payload = {'file': '/etc/passwd'} # Malicious path
    response = client.post('/wifi/pmkid/status', json=payload)
-    
-    assert response.status_code == 200
+
+    assert response.status_code == 400
    assert response.get_json()['status'] == 'error'
    assert 'Invalid capture file path' in response.get_json()['message']