mirror of
https://github.com/smittix/intercept.git
synced 2026-07-08 01:28:13 -07:00
style: apply ruff-format to entire codebase
First-time run of ruff-format via pre-commit hook normalises quote style, trailing commas, and whitespace across 188 Python files. No logic changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -187,3 +187,56 @@ Each signal type has its own Flask blueprint:
|
||||
## Testing Notes
|
||||
|
||||
Tests use pytest with extensive mocking of external tools. Key fixtures in `tests/conftest.py`. Mock subprocess calls when testing decoder integration.
|
||||
|
||||
### Think Before Coding
|
||||
|
||||
Don't assume. Don't hide confusion. Surface tradeoffs.
|
||||
|
||||
Before implementing:
|
||||
|
||||
State your assumptions explicitly. If uncertain, ask.
|
||||
If multiple interpretations exist, present them - don't pick silently.
|
||||
If a simpler approach exists, say so. Push back when warranted.
|
||||
If something is unclear, stop. Name what's confusing. Ask.
|
||||
2. Simplicity First
|
||||
|
||||
Minimum code that solves the problem. Nothing speculative.
|
||||
|
||||
No features beyond what was asked.
|
||||
No abstractions for single-use code.
|
||||
No "flexibility" or "configurability" that wasn't requested.
|
||||
No error handling for impossible scenarios.
|
||||
If you write 200 lines and it could be 50, rewrite it.
|
||||
Ask yourself: "Would a senior engineer say this is overcomplicated?" If yes, simplify.
|
||||
|
||||
### Surgical Changes
|
||||
|
||||
Touch only what you must. Clean up only your own mess.
|
||||
|
||||
When editing existing code:
|
||||
|
||||
Don't "improve" adjacent code, comments, or formatting.
|
||||
Don't refactor things that aren't broken.
|
||||
Match existing style, even if you'd do it differently.
|
||||
If you notice unrelated dead code, mention it - don't delete it.
|
||||
When your changes create orphans:
|
||||
|
||||
Remove imports/variables/functions that YOUR changes made unused.
|
||||
Don't remove pre-existing dead code unless asked.
|
||||
The test: Every changed line should trace directly to the user's request.
|
||||
|
||||
### Goal-Driven Execution
|
||||
|
||||
Define success criteria. Loop until verified.
|
||||
|
||||
Transform tasks into verifiable goals:
|
||||
|
||||
"Add validation" → "Write tests for invalid inputs, then make them pass"
|
||||
"Fix the bug" → "Write a test that reproduces it, then make it pass"
|
||||
"Refactor X" → "Ensure tests pass before and after"
|
||||
For multi-step tasks, state a brief plan:
|
||||
|
||||
1. [Step] → verify: [check]
|
||||
2. [Step] → verify: [check]
|
||||
3. [Step] → verify: [check]
|
||||
|
||||
|
||||
Reference in New Issue
Block a user