Major security and code quality improvements

Security:
- Add input validation for all API endpoints (frequency, lat/lon, device, gain, ppm)
- Add HTML escaping utility to prevent XSS attacks
- Add path traversal protection for log file configuration
- Add proper HTTP status codes for error responses (400, 409, 503)

Performance:
- Reduce SSE keepalive overhead (30s interval instead of 1s)
- Add centralized SSE stream utility with optimized keepalive
- Add DataStore class for thread-safe data with automatic cleanup

New Features:
- Add data export endpoints (/export/aircraft, /export/wifi, /export/bluetooth)
- Support for both JSON and CSV export formats
- Add process cleanup on application exit (atexit handlers)
- Label Iridium module as demo mode with clear warnings

Code Quality:
- Create utils/validation.py for centralized input validation
- Create utils/sse.py for SSE stream utilities
- Create utils/cleanup.py for memory management
- Add safe_terminate() and register_process() for process management
- Improve error handling with proper logging throughout routes

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
James Smith
2025-12-30 19:24:40 +00:00
parent 016ff0cad1
commit ee166bc5d1
13 changed files with 964 additions and 63 deletions
+71 -17
View File
@@ -1,4 +1,9 @@
"""Iridium monitoring routes."""
"""Iridium monitoring routes.
NOTE: This module is currently in DEMO MODE. The burst detection generates
simulated data for demonstration purposes. Real Iridium decoding requires
gr-iridium or iridium-toolkit which are not yet integrated.
"""
from __future__ import annotations
@@ -16,24 +21,42 @@ from flask import Blueprint, jsonify, request, Response
import app as app_module
from utils.logging import iridium_logger as logger
from utils.validation import validate_frequency, validate_device_index, validate_gain
from utils.sse import format_sse
iridium_bp = Blueprint('iridium', __name__, url_prefix='/iridium')
# Flag indicating this is demo mode (simulated data)
DEMO_MODE = True
def monitor_iridium(process):
"""Monitor Iridium capture and detect bursts."""
"""
Monitor Iridium capture and detect bursts.
NOTE: Currently generates SIMULATED data for demonstration.
Real Iridium decoding is not yet implemented.
"""
try:
burst_count = 0
# Send initial demo mode warning
app_module.satellite_queue.put({
'type': 'info',
'message': '⚠️ DEMO MODE: Generating simulated Iridium bursts for demonstration'
})
while process.poll() is None:
data = process.stdout.read(1024)
if data:
if len(data) > 0 and burst_count < 100:
# DEMO: Generate simulated bursts (1% chance per read)
if random.random() < 0.01:
burst = {
'type': 'burst',
'demo': True, # Flag as demo data
'time': datetime.now().strftime('%H:%M:%S.%f')[:-3],
'frequency': f"{1616 + random.random() * 10:.3f}",
'data': f"Frame data (simulated) - Burst #{burst_count + 1}"
'data': f"[SIMULATED] Frame data - Burst #{burst_count + 1}"
}
app_module.satellite_queue.put(burst)
app_module.iridium_bursts.append(burst)
@@ -47,28 +70,44 @@ def monitor_iridium(process):
@iridium_bp.route('/tools')
def check_iridium_tools():
"""Check for Iridium decoding tools."""
has_tool = shutil.which('iridium-extractor') is not None or shutil.which('iridium-parser') is not None
return jsonify({'available': has_tool})
has_iridium = shutil.which('iridium-extractor') is not None or shutil.which('iridium-parser') is not None
has_rtl = shutil.which('rtl_fm') is not None
return jsonify({
'available': has_iridium or has_rtl,
'demo_mode': DEMO_MODE,
'message': 'Demo mode active - generating simulated data' if DEMO_MODE else None
})
@iridium_bp.route('/start', methods=['POST'])
def start_iridium():
"""Start Iridium burst capture."""
"""Start Iridium burst capture (DEMO MODE - simulated data)."""
with app_module.satellite_lock:
if app_module.satellite_process and app_module.satellite_process.poll() is None:
return jsonify({'status': 'error', 'message': 'Iridium capture already running'})
return jsonify({'status': 'error', 'message': 'Iridium capture already running'}), 409
data = request.json or {}
# Validate inputs
try:
freq = validate_frequency(data.get('freq', '1626.0'), min_mhz=1610.0, max_mhz=1650.0)
gain = validate_gain(data.get('gain', '40'))
device = validate_device_index(data.get('device', '0'))
except ValueError as e:
return jsonify({'status': 'error', 'message': str(e)}), 400
data = request.json
freq = data.get('freq', '1626.0')
gain = data.get('gain', '40')
sample_rate = data.get('sampleRate', '2.048e6')
device = data.get('device', '0')
# Validate sample rate format
try:
float(sample_rate.replace('e', 'E'))
except (ValueError, AttributeError):
return jsonify({'status': 'error', 'message': 'Invalid sample rate format'}), 400
if not shutil.which('iridium-extractor') and not shutil.which('rtl_fm'):
return jsonify({
'status': 'error',
'message': 'Iridium tools not found.'
})
'message': 'Iridium tools not found. Requires rtl_fm or iridium-extractor.'
}), 503
try:
cmd = [
@@ -89,9 +128,17 @@ def start_iridium():
thread = threading.Thread(target=monitor_iridium, args=(app_module.satellite_process,), daemon=True)
thread.start()
return jsonify({'status': 'started'})
return jsonify({
'status': 'started',
'demo_mode': DEMO_MODE,
'message': 'Demo mode active - data is simulated' if DEMO_MODE else None
})
except FileNotFoundError as e:
logger.error(f"Tool not found: {e}")
return jsonify({'status': 'error', 'message': f'Tool not found: {e.filename}'}), 503
except Exception as e:
return jsonify({'status': 'error', 'message': str(e)})
logger.error(f"Start error: {e}")
return jsonify({'status': 'error', 'message': str(e)}), 500
@iridium_bp.route('/stop', methods=['POST'])
@@ -113,12 +160,19 @@ def stop_iridium():
def stream_iridium():
"""SSE stream for Iridium bursts."""
def generate():
last_keepalive = time.time()
keepalive_interval = 30.0
while True:
try:
msg = app_module.satellite_queue.get(timeout=1)
yield f"data: {json.dumps(msg)}\n\n"
last_keepalive = time.time()
yield format_sse(msg)
except queue.Empty:
yield f"data: {json.dumps({'type': 'keepalive'})}\n\n"
now = time.time()
if now - last_keepalive >= keepalive_interval:
yield format_sse({'type': 'keepalive'})
last_keepalive = now
response = Response(generate(), mimetype='text/event-stream')
response.headers['Cache-Control'] = 'no-cache'