pool: fixed synchronization/stopping of the pool

server/http/server.go

@@ -79,6 +79,8 @@ func (s *httpServer) Start() {
 			return
 		}
 	}
+
+	log.Println("HTTP server shut down cleanly")
 }
 
 func (s *httpServer) Stop() {

server/pool.go

@@ -20,8 +20,7 @@ type Pool struct {
 // StartPool creates a new pool of servers specified by the provided config and
 // runs them.
 func StartPool(cfgs []config.ServerConfig, tkr *tracker.Tracker) (*Pool, error) {
-	var servers []Server
+	var toReturn Pool
-	var wg sync.WaitGroup
 
 	for _, cfg := range cfgs {
 		srv, err := New(&cfg, tkr)
@@ -29,19 +28,16 @@ func StartPool(cfgs []config.ServerConfig, tkr *tracker.Tracker) (*Pool, error)
 			return nil, err
 		}
 
-		wg.Add(1)
+		toReturn.wg.Add(1)
 		go func(srv Server) {
-			defer wg.Done()
+			defer toReturn.wg.Done()
 			srv.Start()
 		}(srv)
 
-		servers = append(servers, srv)
+		toReturn.servers = append(toReturn.servers, srv)
 	}
 
-	return &Pool{
+	return &toReturn, nil
-		servers: servers,
-		wg:      wg,
-	}, nil
 }
 
 // Stop safely shuts down a pool of servers.

server/store/store.go

@@ -48,6 +48,7 @@ func constructor(srvcfg *config.ServerConfig, tkr *tracker.Tracker) (server.Serv
 		theStore = &Store{
 			cfg:         cfg,
 			tkr:         tkr,
+			shutdown:    make(chan struct{}),
 			ClientStore: cs,
 			PeerStore:   ps,
 			IPStore:     ips,