Mirror/mochi
1
0
Fork 0
mirror of https://github.com/sot-tech/mochi.git synced 2026-05-13 20:18:35 -07:00
Code Issues Packages Projects Releases Wiki Activity

Always log errors

Browse Source
This commit is contained in:
Justin Li
2014-07-23 01:31:22 -04:00
parent 84195deb58
commit 856568f1a8
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
http/http.go
View File

@@ -17,7 +17,6 @@ import (
"github.com/chihaya/chihaya/config" "github.com/chihaya/chihaya/config"
"github.com/chihaya/chihaya/stats" "github.com/chihaya/chihaya/stats"
"github.com/chihaya/chihaya/tracker" "github.com/chihaya/chihaya/tracker"
"github.com/chihaya/chihaya/tracker/models"
) )
type ResponseHandler func(http.ResponseWriter, *http.Request, httprouter.Params) (int, error) type ResponseHandler func(http.ResponseWriter, *http.Request, httprouter.Params) (int, error)
@@ -31,23 +30,20 @@ func makeHandler(handler ResponseHandler) httprouter.Handle {
return func(w http.ResponseWriter, r *http.Request, p httprouter.Params) { return func(w http.ResponseWriter, r *http.Request, p httprouter.Params) {
start := time.Now() start := time.Now()
httpCode, err := handler(w, r, p) httpCode, err := handler(w, r, p)
stats.RecordEvent(stats.HandledRequest)
duration := time.Since(start) duration := time.Since(start)
stats.RecordTiming(stats.ResponseTime, duration)
if err != nil { if err != nil {
stats.RecordEvent(stats.ErroredRequest) stats.RecordEvent(stats.ErroredRequest)
http.Error(w, err.Error(), httpCode) http.Error(w, err.Error(), httpCode)
if glog.V(2) {
glog.Infof( glog.Errorf(
"Failed (%v:%s) %s with %s in %s", "Failed (%v:%s) %s with %s in %s",
httpCode, httpCode,
http.StatusText(httpCode), http.StatusText(httpCode),
r.URL.Path, r.URL.Path,
err.Error(), err.Error(),
duration, duration,
) )
}
} else if glog.V(2) { } else if glog.V(2) {
glog.Infof( glog.Infof(
"Completed (%v:%s) %s in %v", "Completed (%v:%s) %s in %v",
@@ -57,6 +53,9 @@ func makeHandler(handler ResponseHandler) httprouter.Handle {
duration, duration,
) )
} }
stats.RecordEvent(stats.HandledRequest)
stats.RecordTiming(stats.ResponseTime, duration)
} }
} }