From 9366e601cd4f58458f8fb1932bcb1c4a3250cb1f Mon Sep 17 00:00:00 2001 From: Jimmy Zelinskie Date: Thu, 4 Aug 2016 16:26:44 -0400 Subject: [PATCH] http: fail when numwant missing --- bittorrent/http/parser.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bittorrent/http/parser.go b/bittorrent/http/parser.go index cbf6ba9..9c8d8d9 100644 --- a/bittorrent/http/parser.go +++ b/bittorrent/http/parser.go @@ -81,7 +81,10 @@ func ParseAnnounce(r *http.Request, realIPHeader string, allowIPSpoofing bool) ( return nil, bittorrent.ClientError("failed to parse parameter: uploaded") } - numwant, _ := qp.Uint64("numwant") + numwant, err := qp.Uint64("numwant") + if err != nil { + return nil, bittorrent.ClientError("failed to parse parameter: numwant") + } request.NumWant = int32(numwant) port, err := qp.Uint64("port")