From 1702184a102e491e9e0a8d010cce61736f2e1c66 Mon Sep 17 00:00:00 2001 From: Will Greenberg Date: Wed, 15 Jul 2026 15:06:14 -0700 Subject: [PATCH] rm is_gsmtap_type Instead of tracking which types are gsmtap-friendly, just rely on the parser result. --- lib/src/diag/mod.rs | 15 --------------- lib/src/gsmtap/parser.rs | 3 --- 2 files changed, 18 deletions(-) diff --git a/lib/src/diag/mod.rs b/lib/src/diag/mod.rs index 67d2395..6a1ca3b 100644 --- a/lib/src/diag/mod.rs +++ b/lib/src/diag/mod.rs @@ -156,21 +156,6 @@ impl Message { Err(err) => Err(DiagParsingError::HdlcDecapsulationError(err, data.to_vec())), } } - - /// Returns whether this message should be parsed into a GSMTAP packet for - /// display in pcap files - pub fn is_gsmtap_message(&self) -> bool { - let Message::Log { body, .. } = self else { - return false; - }; - matches!( - body, - LogBody::LteRrcOtaMessage { .. } - | LogBody::LteMacRachResponse { .. } - | LogBody::LteMl1NeighborCellsMeasurements { .. } - | LogBody::Nas4GMessage { .. } - ) - } } #[derive(Debug, Clone, PartialEq, DekuRead, DekuWrite)] diff --git a/lib/src/gsmtap/parser.rs b/lib/src/gsmtap/parser.rs index e33f91c..3b1ce01 100644 --- a/lib/src/gsmtap/parser.rs +++ b/lib/src/gsmtap/parser.rs @@ -17,9 +17,6 @@ pub enum GsmtapParserError { } pub fn parse(msg: Message) -> Result, GsmtapParserError> { - if !msg.is_gsmtap_message() { - return Ok(None); - } if let Message::Log { timestamp, body, .. } = msg