From 8d8099f66b19900841d2edbbdfbfd4c70f9eed83 Mon Sep 17 00:00:00 2001 From: Will Greenberg Date: Thu, 25 Jun 2026 07:38:37 -0700 Subject: [PATCH] Remove Mac UL/DL message support These weren't parsing correctly despite the parser seemingly matching SCATs, so disable these for now. They weren't being used for anything yet, anyway. --- lib/src/diag/diaglog/mod.rs | 4 ---- lib/src/diag_device.rs | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/src/diag/diaglog/mod.rs b/lib/src/diag/diaglog/mod.rs index d4ff8ed..50351eb 100644 --- a/lib/src/diag/diaglog/mod.rs +++ b/lib/src/diag/diaglog/mod.rs @@ -87,10 +87,6 @@ pub enum LogBody { }, #[deku(id = "0xb062")] LteMacRachResponse { packet: mac::Packet }, - #[deku(id = "0xb063")] - LteMacDl { packet: mac::Packet }, - #[deku(id = "0xb064")] - LteMacUl { packet: mac::Packet }, } #[derive(Debug, Clone, PartialEq, DekuRead, DekuWrite)] diff --git a/lib/src/diag_device.rs b/lib/src/diag_device.rs index 53b8ef4..2cd4900 100644 --- a/lib/src/diag_device.rs +++ b/lib/src/diag_device.rs @@ -40,7 +40,7 @@ pub enum DiagDeviceError { ParseMessagesContainerError(deku::DekuError), } -pub const LOG_CODES_FOR_RAW_PACKET_LOGGING: [u32; 16] = [ +pub const LOG_CODES_FOR_RAW_PACKET_LOGGING: [u32; 14] = [ // Layer 2: log_codes::LOG_GPRS_MAC_SIGNALLING_MESSAGE_C, // 0x5226 // Layer 3: @@ -61,8 +61,6 @@ pub const LOG_CODES_FOR_RAW_PACKET_LOGGING: [u32; 16] = [ log_codes::LOG_LTE_ML1_NEIGHBOR_MEAS, // 0xb180 // LTE MAC Random Access Channel response: contains Timing Advance log_codes::LOG_LTE_MAC_RACH_RESPONSE_C, // 0xb062 - log_codes::LOG_LTE_MAC_DL, // 0xb063 - log_codes::LOG_LTE_MAC_UL, // 0xb064 ]; const BUFFER_LEN: usize = 1024 * 1024 * 10;