From 9823fd32059a362c8aa2b4ea3ce349df92ab1547 Mon Sep 17 00:00:00 2001
From: Markus Unterwaditzer <markus-tarpit+git@unterwaditzer.net>
Date: Fri, 15 May 2026 22:00:02 +0200
Subject: [PATCH] fix bad color in configform, move some docs into api docs

---
 daemon/src/gps.rs                             | 27 +++++++++++++++++++
 daemon/src/lib.rs                             |  4 ++-
 .../web/src/lib/components/ConfigForm.svelte  |  2 +-
 doc/configuration.md                          |  9 ++++---
 4 files changed, 36 insertions(+), 6 deletions(-)

diff --git a/daemon/src/gps.rs b/daemon/src/gps.rs
index 303e3e9..2be8c67 100644
--- a/daemon/src/gps.rs
+++ b/daemon/src/gps.rs
@@ -60,6 +60,7 @@ where
 }
 
 #[derive(Clone, Debug, Serialize, Deserialize)]
+#[cfg_attr(feature = "apidocs", derive(utoipa::ToSchema))]
 pub struct GpsData {
     #[serde(deserialize_with = "deserialize_latitude")]
     pub latitude: f64,
@@ -98,6 +99,20 @@ pub async fn load_gps_records(file: tokio::fs::File) -> Vec<GpsRecord> {
     records
 }
 
+/// Submit GPS coordinates
+#[cfg_attr(feature = "apidocs", utoipa::path(
+    post,
+    path = "/api/gps",
+    tag = "Configuration",
+    request_body = GpsData,
+    responses(
+        (status = StatusCode::OK, description = "GPS data accepted"),
+        (status = StatusCode::FORBIDDEN, description = "GPS API endpoint is disabled"),
+        (status = StatusCode::INTERNAL_SERVER_ERROR, description = "Failed to write GPS record")
+    ),
+    summary = "Submit GPS coordinates",
+    description = "Submit GPS coordinates from an external source (e.g. a phone app). Requires gps_mode to be set to 'Api' in configuration. latitude is in decimal degrees from -90 to 90, longitude is in decimal degrees from -180 to 180, timestamp is a Unix timestamp in seconds."
+))]
 pub async fn post_gps(
     State(state): State<Arc<ServerState>>,
     Json(gps_data): Json<GpsData>,
@@ -155,6 +170,18 @@ pub async fn post_gps(
     Ok(StatusCode::OK)
 }
 
+/// Get the current GPS coordinates
+#[cfg_attr(feature = "apidocs", utoipa::path(
+    get,
+    path = "/api/gps",
+    tag = "Configuration",
+    responses(
+        (status = StatusCode::OK, description = "Current GPS data", body = GpsData),
+        (status = StatusCode::NOT_FOUND, description = "No GPS data available")
+    ),
+    summary = "Get current GPS coordinates",
+    description = "Returns the most recently submitted GPS coordinates. Returns 404 if no coordinates have been submitted yet this session."
+))]
 pub async fn get_gps(State(state): State<Arc<ServerState>>) -> Result<Json<GpsData>, StatusCode> {
     let gps = state.gps_state.read().await;
     match gps.as_ref() {
diff --git a/daemon/src/lib.rs b/daemon/src/lib.rs
index b347dca..69fdf5b 100644
--- a/daemon/src/lib.rs
+++ b/daemon/src/lib.rs
@@ -47,7 +47,9 @@ use utoipa::OpenApi;
         server::test_notification,
         server::get_time,
         server::set_time_offset,
-        server::debug_set_display_state
+        server::debug_set_display_state,
+        gps::post_gps,
+        gps::get_gps
     ),
     servers(
         (
diff --git a/daemon/web/src/lib/components/ConfigForm.svelte b/daemon/web/src/lib/components/ConfigForm.svelte
index 8bad35d..88a3669 100644
--- a/daemon/web/src/lib/components/ConfigForm.svelte
+++ b/daemon/web/src/lib/components/ConfigForm.svelte
@@ -781,7 +781,7 @@
                     </div>
                 </div>
 
-                <div class="border-t pt-4 mt-6 space-y-3">
+                <div class="border-t border-gray-200 pt-4 mt-6 space-y-3">
                     <h3 class="text-lg font-semibold text-gray-800 mb-4">GPS Settings</h3>
                     <div>
                         <label for="gps_mode" class="block text-sm font-medium text-gray-700 mb-1"
diff --git a/doc/configuration.md b/doc/configuration.md
index b21e1a1..28b5ac7 100644
--- a/doc/configuration.md
+++ b/doc/configuration.md
@@ -27,12 +27,13 @@ The **GPS Settings** allows you to attach GPS-based location history to every re
 
 The modes are:
 
-- *Disabled*, the default option, won't attach any comment to the packets or enable any program logic for the management of coordinates.
+- *Disabled*, the default option, disables this feature entirely.
 
-- *Fixed*, this is more suitable for measurements taken in the same geographic position for that session, it enables two input fields for latitude and longitude. They accept decimal degrees format (from -90 to 90 for latitude, and -180 to 180 for latitude). This mode adds a "fixed" value to the GPS timestamp in the PCAP packets to help during analysis to know the coordinates were set up manually.
-- *API Endpoint*, enables the /api/gps endpoint to send POST requests in json format with the values for latitude, longitude, and timestamp. The GPS timestamp should be provided as Unix timestamp, and can be passed as number or string without errors, but any other format won't pass the validation process.
+- *Fixed*, for hardcoding latitude (-90 to 90) and longitude (-180 to 180) for devices that don't move very often or at all. Every packet in the recording will have that location.
 
-The GPS data is stored as a separate JSON file next to QMDL captures, and contains its own timestamp for each packet. This timestamp is meant to be compared during analysis with the packet timestamp so we know the time difference between the packet capture from the GPS capture, if there is any, since GPS data and packet data may come from two entirely separate devices.
+- *API Endpoint*, enables the `POST /api/gps` endpoint so that third-party tools (i.e. your own scripts) can update location info continuously. Please refer to the [API documentation](api-docs.md) for more info.
+
+The GPS data is stored as a separate JSON file next to QMDL captures, and contains its own timestamps. These timestamps are meant to be compared during analysis with the packet timestamp so we know the time difference between the packet capture from the GPS capture, if there is any, since GPS data and packet data may come from two entirely separate devices.
 
 ## WiFi Client Mode