From e86d30a0c6477f83824725ff4583d46c30910104 Mon Sep 17 00:00:00 2001 From: recanman <29310982+recanman@users.noreply.github.com> Date: Fri, 22 May 2026 20:10:04 +0000 Subject: [PATCH] frontend bugfix: Handle `null` input in `ExpandableInput`, make `ntfy_url` nullable (#1055) * handle `null` input in `ExpandableInput` * correct `ntfy_url` config type * remove extra space --- daemon/web/src/lib/components/ExpandableInput.svelte | 10 +++++++--- daemon/web/src/lib/utils.svelte.ts | 2 +- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/daemon/web/src/lib/components/ExpandableInput.svelte b/daemon/web/src/lib/components/ExpandableInput.svelte index 1781c81..50434d1 100644 --- a/daemon/web/src/lib/components/ExpandableInput.svelte +++ b/daemon/web/src/lib/components/ExpandableInput.svelte @@ -11,7 +11,7 @@ inputHelp = '', children, }: { - value: string; + value: string | null; checkboxId: string; inputId: string; label: string; @@ -21,7 +21,11 @@ children?: Snippet; } = $props(); - let expanded = $state(value.trim() !== ''); + function has_value(text: string | null) { + return text !== null && text.trim() !== ''; + } + + let expanded = $state(has_value(value)); let inputElement = $state(null); function handle_checkbox_change(e: Event) { @@ -34,7 +38,7 @@ } function handle_input_blur() { - if (value.trim() === '') { + if (!has_value(value)) { expanded = false; } } diff --git a/daemon/web/src/lib/utils.svelte.ts b/daemon/web/src/lib/utils.svelte.ts index 1b5c576..2d0d38b 100644 --- a/daemon/web/src/lib/utils.svelte.ts +++ b/daemon/web/src/lib/utils.svelte.ts @@ -50,7 +50,7 @@ export interface Config { ui_level: number; colorblind_mode: boolean; key_input_mode: number; - ntfy_url: string; + ntfy_url: string | null; enabled_notifications: enabled_notifications[]; analyzers: AnalyzerConfig; min_space_to_start_recording_mb: number;