Remove NodeBuilder to ensure that Params and Callback are always provided.

features/space/impl/src/main/kotlin/io/element/android/features/space/impl/DefaultSpaceEntryPoint.kt

@@ -9,7 +9,6 @@ package io.element.android.features.space.impl
 
 import com.bumble.appyx.core.modality.BuildContext
 import com.bumble.appyx.core.node.Node
-import com.bumble.appyx.core.plugin.Plugin
 import dev.zacsweers.metro.ContributesBinding
 import io.element.android.features.space.api.SpaceEntryPoint
 import io.element.android.libraries.architecture.createNode
@@ -17,22 +16,10 @@ import io.element.android.libraries.di.SessionScope
 
 @ContributesBinding(SessionScope::class)
 class DefaultSpaceEntryPoint : SpaceEntryPoint {
-    override fun nodeBuilder(parentNode: Node, buildContext: BuildContext): SpaceEntryPoint.NodeBuilder {
-        val plugins = mutableSetOf<Plugin>()
-        return object : SpaceEntryPoint.NodeBuilder {
-            override fun inputs(inputs: SpaceEntryPoint.Inputs): SpaceEntryPoint.NodeBuilder {
-                plugins.add(inputs)
-                return this
-            }
-
-            override fun callback(callback: SpaceEntryPoint.Callback): SpaceEntryPoint.NodeBuilder {
-                plugins.add(callback)
-                return this
-            }
-
-            override fun build(): Node {
-                return parentNode.createNode<SpaceFlowNode>(buildContext, plugins = plugins.toList())
-            }
-        }
+    override fun createNode(parentNode: Node, buildContext: BuildContext, inputs: SpaceEntryPoint.Inputs, callback: SpaceEntryPoint.Callback): Node {
+        return parentNode.createNode<SpaceFlowNode>(
+            buildContext = buildContext,
+            plugins = listOf(inputs, callback),
+        )
     }
 }

features/space/impl/src/test/kotlin/io/element/android/features/space/impl/DefaultSpaceEntryPointTest.kt

@@ -48,10 +48,12 @@ class DefaultSpaceEntryPointTest {
             override fun navigateToRoomDetails() = lambdaError()
             override fun navigateToRoomMemberList() = lambdaError()
         }
-        val result = entryPoint.nodeBuilder(parentNode, BuildContext.root(null))
-            .inputs(nodeInputs)
-            .callback(callback)
-            .build()
+        val result = entryPoint.createNode(
+            parentNode = parentNode,
+            buildContext = BuildContext.root(null),
+            inputs = nodeInputs,
+            callback = callback,
+        )
         assertThat(result).isInstanceOf(SpaceFlowNode::class.java)
         assertThat(result.plugins).contains(nodeInputs)
         assertThat(result.plugins).contains(callback)