Split MatrixRoom into BaseRoom and JoinedRoom (#4561)

`JoinedRoom` will now contain both a mandatory live timeline reference and all the functionality associated to it.

`BaseRoom` on the other hand will contain only functionality that's shared for both joined and not joined rooms.

`NotJoinedRoom` is a wrapper around `RoomPreviewInfo` data and a possible local `BaseRoom`, if it exists.

The `RustRoomFactory` cache is now gone since the persistent event cache should have the same effect.

appnav/src/main/kotlin/io/element/android/appnav/di/RoomComponentFactory.kt

@@ -7,8 +7,8 @@
 
 package io.element.android.appnav.di
 
-import io.element.android.libraries.matrix.api.room.MatrixRoom
+import io.element.android.libraries.matrix.api.room.JoinedRoom
 
 interface RoomComponentFactory {
-    fun create(room: MatrixRoom): Any
+    fun create(room: JoinedRoom): Any
 }

appnav/src/main/kotlin/io/element/android/appnav/loggedin/SendQueues.kt

@@ -20,6 +20,7 @@ import kotlinx.coroutines.flow.combine
 import kotlinx.coroutines.flow.debounce
 import kotlinx.coroutines.flow.launchIn
 import kotlinx.coroutines.flow.onEach
+import timber.log.Timber
 import javax.inject.Inject
 
 @VisibleForTesting
@@ -42,7 +43,9 @@ class SendQueues @Inject constructor(
         ) { syncState, _ -> syncState }
             .debounce(SEND_QUEUES_RETRY_DELAY_MILLIS)
             .onEach { syncState ->
+                Timber.tag("SendQueues").d("Sync state changed: $syncState")
                 if (syncState == SyncState.Running) {
+                    Timber.tag("SendQueues").d("Enabling send queues again")
                     matrixClient.setAllSendQueuesEnabled(enabled = true)
                 }
             }

appnav/src/main/kotlin/io/element/android/appnav/room/joined/JoinedRoomLoadedFlowNode.kt

@@ -35,7 +35,7 @@ import io.element.android.libraries.matrix.api.core.EventId
 import io.element.android.libraries.matrix.api.core.RoomId
 import io.element.android.libraries.matrix.api.core.UserId
 import io.element.android.libraries.matrix.api.permalink.PermalinkData
-import io.element.android.libraries.matrix.api.room.MatrixRoom
+import io.element.android.libraries.matrix.api.room.JoinedRoom
 import io.element.android.services.appnavstate.api.AppNavigationStateService
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.launch
@@ -72,7 +72,7 @@ class JoinedRoomLoadedFlowNode @AssistedInject constructor(
     }
 
     data class Inputs(
-        val room: MatrixRoom,
+        val room: JoinedRoom,
         val initialElement: RoomNavigationTarget,
     ) : NodeInputs
 
@@ -95,6 +95,7 @@ class JoinedRoomLoadedFlowNode @AssistedInject constructor(
             },
             onDestroy = {
                 Timber.v("OnDestroy")
+                inputs.room.destroy()
                 appNavigationStateService.onLeavingRoom(id)
             }
         )

appnav/src/main/kotlin/io/element/android/appnav/room/joined/LoadingRoomState.kt

@@ -13,7 +13,7 @@ import io.element.android.libraries.di.SessionScope
 import io.element.android.libraries.di.SingleIn
 import io.element.android.libraries.matrix.api.MatrixClient
 import io.element.android.libraries.matrix.api.core.RoomId
-import io.element.android.libraries.matrix.api.room.MatrixRoom
+import io.element.android.libraries.matrix.api.room.JoinedRoom
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.SharingStarted
@@ -27,7 +27,7 @@ import javax.inject.Inject
 sealed interface LoadingRoomState {
     data object Loading : LoadingRoomState
     data object Error : LoadingRoomState
-    data class Loaded(val room: MatrixRoom) : LoadingRoomState
+    data class Loaded(val room: JoinedRoom) : LoadingRoomState
 }
 
 open class LoadingRoomStateProvider : PreviewParameterProvider<LoadingRoomState> {
@@ -41,7 +41,7 @@ open class LoadingRoomStateProvider : PreviewParameterProvider<LoadingRoomState>
 @SingleIn(SessionScope::class)
 class LoadingRoomStateFlowFactory @Inject constructor(private val matrixClient: MatrixClient) {
     fun create(lifecycleScope: CoroutineScope, roomId: RoomId): StateFlow<LoadingRoomState> =
-        getRoomFlow(roomId)
+        getJoinedRoomFlow(roomId)
             .map { room ->
                 if (room != null) {
                     LoadingRoomState.Loaded(room)
@@ -51,8 +51,8 @@ class LoadingRoomStateFlowFactory @Inject constructor(private val matrixClient:
             }
             .stateIn(lifecycleScope, SharingStarted.Eagerly, LoadingRoomState.Loading)
 
-    private fun getRoomFlow(roomId: RoomId): Flow<MatrixRoom?> = suspend {
-        matrixClient.getRoom(roomId = roomId)
+    private fun getJoinedRoomFlow(roomId: RoomId): Flow<JoinedRoom?> = suspend {
+        matrixClient.getJoinedRoom(roomId = roomId)
     }
         .asFlow()
 }