Commit Graph

338 Commits

Author SHA1 Message Date
Benoit Marty 55db8fb200 Only call setupKover() for the app, not for minimal.
minimal does not have the gplay variant.
2024-01-11 22:03:34 +01:00
Benoit Marty df9f6a9809 Cleanup 2024-01-11 21:42:04 +01:00
Benoit Marty 31fe516a49 Ensure that FDroid build will not include Firebase push provider.
`allLibrariesImpl()` is also used by the midule uitest, and in this case `gplayImplementation` cannot be found. Since the push provider modules do not contain any ui, it's fine to move the dependency declaration to the app module.
2024-01-11 21:42:04 +01:00
Benoit Marty db6b52f8bf Update gradle tasks and paths regarding the new gplay and fdroid flavor. 2024-01-11 21:42:04 +01:00
Benoit Marty fa05b18d32 Create gplay and fdroid variant 2024-01-11 21:42:04 +01:00
Jorge Martin Espinosa f281c6c365 Don't apply Kover to projects with AAR libraries (#2211)
* Don't apply Kover to projects with AAR libraries

* Move the Kover configuration to the `plugins` project
2024-01-11 21:16:31 +01:00
Benoit Marty 92d8e4f55b Merge branch 'develop' into feature/bma/sxcludePreviewFromCodeCoverage 2024-01-11 16:02:58 +01:00
Benoit Marty a831f05f6e Fix ktlint issues 2024-01-10 19:33:39 +01:00
renovate[bot] c8bd362397 Update plugin ktlint to v12.1.0 (#2200)
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-10 16:22:24 +01:00
Benoit Marty 371065bfdd Exclude ContentToPreview from coverage, either by using annotation @ExcludeFromCoverage, or by inlining it. 2024-01-09 17:56:01 +01:00
Benoit Marty 2bdf2c0bbd Merge pull request #1782 from element-hq/feature/bma/upgradeKover
Upgrade kover
2024-01-09 17:52:14 +01:00
Benoit Marty b4481dc2a8 Fix the wrong coverage report
It wasn't taking into account any test result from the debug runs or screenshot tests

Co-authored-by: Jorge Martin Espinosa <jorgem@element.io>
2024-01-09 17:07:26 +01:00
Benoit Marty 80c69e7cf7 Migrate "When running on the CI, run only debug test variants".
Following notice here: https://github.com/Kotlin/kotlinx-kover/blob/v0.7.0/docs/gradle-plugin/migrations/migration-to-0.7.0.md#using-isdisabled-boolean-is-an-error-kover-test-task-config-was-removed
2024-01-09 11:04:28 +01:00
Benoit Marty 3b06576d21 Upgrade Kover to 0.7.5 2024-01-09 10:51:30 +01:00
Jorge Martín e63eb3a7dc Fix crash when sending image with latest posthog 2024-01-08 16:12:22 +01:00
Jorge Martin Espinosa 5980eb2ad2 Upgrade to AGP 8.2.0 (#2142)
* Upgrade to AGP 8.2.0

Add proguard rule for the problematic TagSoup library. For some reason, adding this in the consumer proguard rules of the RTE library doesn't seem to work.

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2024-01-04 12:09:46 +01:00
Jorge Martin Espinosa 7fdba39d6d Disable vector XML rasterisation on API 23 (#2128)
* Disable vector XML rasterisation on API 23

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-12-29 11:41:08 +00:00
Benoit Marty 63d51c5cf5 Send the tracing configuration with the rageshake data. 2023-12-06 17:36:13 +01:00
Marco Romano f186a85ed0 Rename params in NodeFactories for clarity (#1916)
- `context` is now `buildContext` to reflect that it's of type `BuildContext` (and not an android `Context`).
- `NODE` generic type param is now `N` to stick with Java convention: https://docs.oracle.com/javase/tutorial/java/generics/types.html.
2023-11-29 10:01:07 +01:00
Jorge Martin Espinosa 087d2728d5 Extract compound tokens and theming to compound-android library (#1888)
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
2023-11-27 10:30:07 +01:00
Benoit Marty d55282a775 Add test for IntentProviderImpl 2023-11-24 09:56:45 +01:00
Benoit Marty 68f9c81628 Let the user choose theme (#1499) 2023-11-21 12:02:01 +01:00
Marco Romano 28f4ccdf9f Delete media caches on startup (#1807)
Clear media caches on app startup
2023-11-20 09:48:11 +00:00
Benoit Marty 6bfb3162f6 Merge pull request #1806 from vector-im/feature/fga/lock_screen_composition
LockScreen : rework LoggedInFlowNode and Back management
2023-11-14 23:15:44 +01:00
Benoit Marty 2aa92b655c Format comment 2023-11-14 23:15:27 +01:00
ganfra b4a19b91d9 #1806 fix compilation 2023-11-14 21:38:15 +01:00
ganfra 97bbc37f6c LockScreen : avoid removing from composition the LoggedInFlowNode.Children when LockScreen is displayed. 2023-11-14 20:59:17 +01:00
Marco Romano a5f76da204 Remove lateinit from Application class
Just stumbled in this lateinit and thought we could just get rid of it.
2023-11-14 15:32:18 +01:00
Benoit Marty 5850f5342d Move Knit to Gradle catalog and use alias(libs.plugins.kotlin.serialization). Fix issue with JNA 2023-11-13 09:58:00 +01:00
Benoit Marty 067734ecb9 Move appdistribution declarations to Gradle catalog 2023-11-10 16:39:05 +01:00
ganfra 5a417ba498 LockScreen : refact some code and add secureFlag 2023-11-07 15:55:53 +01:00
ganfra 6832b1f2db Feature/fga/biometric unlock (#1702)
* Biometric unlock : refactor a bit existing classes

* Biometric unlock : first implementation

* Biometric: add ui for biometric setup

* Biometric unlock : use localazy strings

* Biometric unlock setup : branch skip/allow events

* Biometric : fix tests

* Biometrics: add small test

* Biometric : clean up

* Update screenshots

* Biometric unlock : address some PR review

* Biometric : improve a bit edge cases

* Fix lint issues

---------

Co-authored-by: ganfra <francoisg@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
Co-authored-by: Jorge Martín <jorgem@element.io>
2023-10-31 19:22:43 +01:00
renovate[bot] 515dca86b6 Update plugin com.google.firebase.appdistribution to v4.0.1 (#1656)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-27 08:12:44 +02:00
ganfra fdd9396089 Pin: add tests and make LockScreenConfig an injectable data class 2023-10-25 18:39:39 +02:00
Marco Romano 33f5c8efb8 Add global context.cacheDir provider. (#1606)
## Type of change

- [ ] Feature
- [ ] Bugfix
- [x] Technical
- [ ] Other :

## Content

Dagger now provides the app's `cacheDir` when requesting a `@CacheDirectory File`  type.

## Motivation and context

To support some upcoming code that needs the `cacheDir` to be changed during tests.
2023-10-19 14:07:45 +02:00
Marco Romano 79d2941fe4 Include desugaring lib also in library modules (#1604)
## Type of change

- [ ] Feature
- [ ] Bugfix
- [x] Technical
- [ ] Other :

## Content

Includes the `coreLibraryDesugaring(libs.android.desugar)` dependency in all modules which use one of our gradle plugins.

## Motivation and context

Right now desugaring is enabled also in library modules but the desugar dependency is not included in those.
This causes some unwanted side effects such as being unable to run compose previews in an emu.

This change will also include the desugar dependency in those libraries.
2023-10-19 09:00:32 +00:00
Benoit Marty c0aa70f7f6 Move konsist test to their own module. 2023-10-12 18:41:38 +02:00
Benoit Marty 634095c43a Konsist: add test for Events 2023-10-12 15:03:50 +02:00
Benoit Marty 7389748f3e Konsist: add rule obout test class name, and fix existing issue 2023-10-12 15:03:50 +02:00
Benoit Marty 8f8a5746e5 Konsist: add test about PreviewParameterProvider class name and fix existing issues. 2023-10-12 15:03:50 +02:00
Benoit Marty 65b83bf266 Konsist: add test to check Node class name. 2023-10-12 15:03:50 +02:00
Benoit Marty c5fbb9d297 Split Konsist test into multiple files 2023-10-12 15:03:50 +02:00
Benoit Marty 7c5a41f03d Konsist: no field should have 'm' prefix, and fix new detected issues. 2023-10-10 22:09:57 +02:00
Benoit Marty 4338d821e5 Konsist: improve test about no default value for State classes, and fix new detected issues. 2023-10-10 21:42:18 +02:00
Benoit Marty 001bc219aa Rename some test 2023-10-10 17:31:04 +02:00
Benoit Marty 0bc2020411 Konsist: add test Function which creates Presenter in test MUST be named 'createPresenterName', and fix existing issues 2023-10-10 17:31:04 +02:00
Benoit Marty d55df22db2 Konsist: add test Data class state MUST not have default value, and fix existing issues 2023-10-10 17:31:04 +02:00
Benoit Marty 8929a90970 Konsist: add test to ensure filename match top level Composable View, and fix existing issue 2023-10-10 15:39:22 +02:00
Benoit Marty 6e5caebc60 Add some Konsist test. 2023-10-10 14:21:36 +02:00
Marco Romano 794ad4ab95 Switch off enableOnBackInvokedCallback due to androidx bug (#1517)
Switch off `enableOnBackInvokedCallback` until https://issuetracker.google.com/issues/271303558 is fixed.


Fixes https://github.com/vector-im/element-x-android/issues/1461
2023-10-09 08:39:56 +00:00