Commit Graph

1348 Commits

Author SHA1 Message Date
Benoit Marty e0255777c0 Enable detekt rules CascadingCallWrapping and fix existing issues. 2023-07-26 11:07:25 +02:00
Benoit Marty b5a5118160 Enable detekt rule ThrowingExceptionsWithoutMessageOrCause and fix existing issues. 2023-07-26 10:33:51 +02:00
Benoit Marty 73347deaaf Enable detekt rule UseCheckOrError and fix existing issues (and a potential crash on MapboxMap?). 2023-07-26 10:18:28 +02:00
Benoit Marty 6aa5239189 Enable detekt rule PreviewPublic and fix existing issues. 2023-07-26 10:08:39 +02:00
Benoit Marty caaa1923c7 Merge pull request #952 from vector-im/feature/bma/fixPushStoreCrash
Fix push store crash
2023-07-25 09:43:37 +02:00
Benoit Marty b2394b6adc alternateText can't be an empty string. #955 2023-07-24 17:15:04 +02:00
Benoit Marty 0599515708 Merge pull request #947 from vector-im/feature/bma/sentry
Sentry
2023-07-24 13:54:06 +02:00
Benoit Marty 4312a96851 Cleanup: there are no androidTest on those modules. 2023-07-24 12:41:02 +02:00
bmarty af2159e98f Sync Strings from Localazy 2023-07-24 00:10:09 +00:00
Benoit Marty 030afe56b3 Fix typo 2023-07-21 21:40:08 +02:00
Benoit Marty 32c8fdae99 Add a way to crash this app on demand. Useful to test Crash detection, and analytics report, etc. 2023-07-21 20:55:04 +02:00
Benoit Marty 82258f12ba Ensure the application react correctly if analytics is disabled at compilation time. 2023-07-21 19:19:17 +02:00
Benoit Marty d4156653fd No need to sort AnalyticsProvider (it was copied from PushProvider) 2023-07-21 18:12:17 +02:00
Benoit Marty 1a1d4c2957 Fix code quality check failures after new rules from #935 has been merged on develop. 2023-07-21 16:04:55 +02:00
Benoit Marty b20448bf08 Merge pull request #935 from vector-im/feature/bma/noWarnings
Code quality: warnings are errors and enable more Detekt rules.
2023-07-21 15:52:05 +02:00
Marco Romano 57d04e487c Static images improvements (#933)
1. On devices less than xhdpi request a 1x image from MapTiler (such devices are generally old, slower and with little memory so avoiding to get the 2x image only to have to shrink it later could help).
2. Coerce too big width/height combos within the API limits keeping the aspect ratio (this will allow requests on big horizontal displays to succeed).
3. Don't crash when given weird width/height combos (i.e. zero or negative).
4. Introduce interfaces to hide this whole logic and make it easier for forks to implement their own.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-21 13:37:08 +00:00
Benoit Marty 5e2e03f054 Merge branch 'develop' into feature/bma/noWarnings 2023-07-21 12:17:50 +02:00
David Langley d9be396a04 Merge pull request #912 from vector-im/feature/dla_custom_reactions_layout
Reactions layout improvements
2023-07-21 11:00:43 +01:00
Benoit Marty 6b9f676b12 Test new field canShareLocation 2023-07-20 23:18:18 +02:00
Benoit Marty 3376fe3688 Must skip 1 item due to the location feature flag value emitting 1 item. 2023-07-20 23:17:29 +02:00
Benoit Marty 2ab57f3fc8 canShareLocation must be a MutableState. 2023-07-20 22:23:54 +02:00
Benoit Marty 2c11f472ca Replace FeatureFlags.ShowMediaUploadingFlow by FeatureFlags.LocationSharing because it has more chance to be disabled.
I do not want to remove all our feature flags...
2023-07-20 22:20:38 +02:00
Benoit Marty c75eabbcb0 Enable detekt rules UnnecessaryParentheses and cleanup the code. 2023-07-20 18:08:08 +02:00
Benoit Marty 2928073e22 Enable detekt rules UnusedImports and cleanup the code. 2023-07-20 18:00:23 +02:00
Benoit Marty e918d6affd Enable detekt rules TopLevelPropertyNaming and cleanup the code. 2023-07-20 17:52:48 +02:00
Benoit Marty a8ed8b7a59 Enable detekt rules VariableNaming and cleanup the code. 2023-07-20 17:50:23 +02:00
Benoit Marty 86756dbc09 Enable detekt rules UnusedParameter and UnusedPrivateProperty and cleanup the code. 2023-07-20 17:48:56 +02:00
Benoit Marty 65ad642ffc Fix warning (bottom sheet still not previewable correctly in screenshot test) 2023-07-20 17:41:18 +02:00
Benoit Marty e23222591b Fix warning (there is a TODO) 2023-07-20 17:39:55 +02:00
Benoit Marty e67c7f32c3 Fix warning (keep the same format for all methods) 2023-07-20 17:39:55 +02:00
Benoit Marty f738864e88 Fix warning (we will handle error case later) 2023-07-20 17:39:55 +02:00
Benoit Marty 6a69207fb8 Fix warning (there is a TODO) 2023-07-20 17:39:55 +02:00
Marco Romano d964650804 Use correct share my location icon in button (#936)
As per newer design specs.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-20 13:59:06 +00:00
Benoit Marty e5d2e294ae Fix warning (suppress unused param for now) 2023-07-20 15:47:42 +02:00
Benoit Marty 518f690368 Fix warning (suppress unused param for now) 2023-07-20 15:47:14 +02:00
Benoit Marty 0a512cae0b Fix warning (suppress unused param for now, EAX does not support sticker right now.) 2023-07-20 15:46:41 +02:00
Benoit Marty a7f5324791 Fix warning (suppress unused param for now) 2023-07-20 15:46:09 +02:00
Benoit Marty 8d6e1a2327 Fix warning (suppress unused param for now) 2023-07-20 15:45:18 +02:00
Marco Romano c746981000 Add screenshots with ~1.5 lines long desc to expanded location view (#923)
This will help in catching alignment regressions.

Related to:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-20 13:42:35 +00:00
Marco Romano e8e4542a75 Extract maptiler's map ids (#926)
Maptiler custom map ids are only useable by the account that create them. So if we hardcode them forkers won't be able to use the maps even if the bring in their own api key (because they can't access our maps with their api key).

Requires to set our map ids in `local.properties` for local development:
```
services.maptiler.lightMapId=9bc819c8-e627-474a-a348-ec144fe3d810
services.maptiler.darkMapId=dea61faf-292b-4774-9660-58fcef89a7f3
```
2023-07-20 14:29:06 +02:00
Marco Romano f7e7339777 Correct location event body (#930)
- Now sending the correct body format as agreed with design. This won't be show in EX clients though.

Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-20 10:16:40 +00:00
Marco Romano e448bbb92d maplibre-compose allow customisation of location dot style (#929)
- And style it according to our designs.

Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-20 12:09:40 +02:00
renovate[bot] 156bf08b7a Update dependency app.cash.molecule:molecule-runtime to v1 (#925)
* Update dependency app.cash.molecule:molecule-runtime to v1

* Replace `RecompositionClock` with `RecompositionMode`

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Jorge Martín <jorgem@element.io>
2023-07-20 07:36:19 +02:00
Jorge Martín 69490b7465 Fix more lint issues 2023-07-20 07:35:27 +02:00
Jorge Martín 697b2052e8 Fix typo 2023-07-20 07:27:13 +02:00
Jorge Martín aad92d84ff Use ElementTheme as much as possible 2023-07-20 07:27:02 +02:00
Jorge Martín 4896b76e47 Try to fix lint issue 2023-07-20 07:21:28 +02:00
Marco Romano f614895ec1 Refactor a custom alignment to its own modifier for readability. (#924) 2023-07-19 16:58:04 +02:00
Marco Romano cec87ee6a8 Don't crash when sharing a location with no maptiler apikey (#919)
Related to:
- https://github.com/vector-im/element-meta/issues/1682
2023-07-19 16:33:50 +02:00
Marco Romano 4162d16f52 Location expanded view: show own location (#916)
If the location permission is granted:
- Shows the user's own location
- Shows a button to center the map on it

Part of:
- https://github.com/vector-im/element-meta/issues/1678
2023-07-19 13:26:06 +00:00