enki/blap-android
1
0
Fork 0
Code Issues Pull Requests Actions 4 Packages Projects Releases 4 Wiki Activity
5,849 Commits 1 Branch 4 Tags
e9d3bfda45b9be12393d5e9b5293cbf94491c4e2
Commit Graph

99 Commits

Author SHA1 Message Date
Benoit Marty b104dba845 Remove Modifier parameter in private function when only default value is used. 
This will improve the code coverage metrics, and this also fixes a few potential bug, where the Modifier was used several times.
 2024-02-08 11:06:06 +01:00
bmarty 03c95555e3 Sync Strings from Localazy 2024-02-05 00:09:59 +00:00
Benoit Marty 3ced570b3c Fix detekt issue: 
Lambda parameters in a @Composable that are referenced directly inside of restarting effects can cause issues or unpredictable behavior.

If restarting the effect is ok, you can add the reference to this parameter as a key in that effect, so when the parameter changes, a new effect is created.
However, if the effect is not to be restarted, you will need to use `rememberUpdatedState` on the parameter and use its result in the effect.

See https://mrmans0n.github.io/compose-rules/rules/#be-mindful-of-the-arguments-you-use-inside-of-a-restarting-effect for more information. [LambdaParameterInRestartableEffect]
 2024-01-23 18:13:33 +01:00
ElementBot 6bc080c279 Sync Strings (#2230) 
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
 2024-01-15 09:21:04 +01:00
Benoit Marty 5d086ad82d Fix moar ktlint issues 2024-01-11 10:02:10 +01:00
renovate[bot] c8bd362397 Update plugin ktlint to v12.1.0 (#2200) 
* Update plugin ktlint to v12.1.0

* Run `./gradlew ktlintFormat` and fix some issues manually.

* Fix other issues reproted by Ktlint

* Limit false positives, KtLint removes unnecessary curly brace in String templates.

* Remove useless Unit

* Minor improvements over ktlint changes

* Restore `AlertDialogContent` behaviour

* Update screenshots

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benoit Marty <benoit@matrix.org>
Co-authored-by: Jorge Martín <jorgem@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2024-01-10 16:22:24 +01:00
bmarty 9c6e511319 Sync Strings from Localazy 2024-01-08 00:10:36 +00:00
Benoit Marty 7b2341aec7 Rename Async to AsyncData 2024-01-04 16:30:56 +01:00
bmarty e6f4a7364f Sync Strings from Localazy 2023-12-26 09:39:48 +01:00
ganfra 921e9d2ca4 Merge pull request #2059 from element-hq/feature/fga/appyx_overlay 
Appyx Overlay
 2023-12-20 11:17:23 +01:00
ganfra c4dc024c63 Fix detekt 2023-12-19 12:59:13 +01:00
ganfra 78bd6915c7 BackstackParentNode now become BaseFlowNode and adds Overlay navModel into it. 2023-12-19 12:55:14 +01:00
bmarty e60508a631 Sync Strings from Localazy 2023-12-18 00:10:14 +00:00
Benoit Marty 39cca2ce09 Sync localazy using fixed script 2023-12-08 19:24:35 +01:00
Benoit Marty b98351ec36 Merge pull request #1952 from vector-im/sync-localazy 
Sync Strings
 2023-12-05 13:47:44 +01:00
Benoit Marty 24d3981261 Run the script again. 2023-12-05 12:25:59 +01:00
Benoit Marty ab8e4f1422 Add Konsist test to use isTrue() instead of isEqualTo(true), and fix existing issues. 2023-12-04 15:23:36 +01:00
Benoit Marty b2d9b41946 Add Konsist test to use isFalse() instead of isEqualTo(false), and fix existing issues. 2023-12-04 15:21:50 +01:00
bmarty fced91addb Sync Strings from Localazy 2023-12-04 00:09:56 +00:00
Jorge Martin Espinosa 087d2728d5 Extract compound tokens and theming to compound-android library (#1888) 
* Replace tokens & icons with the external Compound ones

---------

Co-authored-by: ElementBot <benoitm+elementbot@element.io>
 2023-11-27 10:30:07 +01:00
Benoit Marty 67ed385e45 Prevent usage of hard-coded string for contentDescription, and fix existing issues. 2023-11-21 15:38:21 +01:00
ganfra 97bbc37f6c LockScreen : avoid removing from composition the LoggedInFlowNode.Children when LockScreen is displayed. 2023-11-14 20:59:17 +01:00
ElementBot 3bf34eae01 Sync Strings (#1789) 
Co-authored-by: bmarty <bmarty@users.noreply.github.com>
 2023-11-13 12:31:34 +01:00
ganfra 1e244b2ffd Merge pull request #1757 from vector-im/feature/fga/lock_polish 
LockScreen polish
 2023-11-08 14:02:53 +01:00
ganfra 4f519a817a Lock screen : fix one more test. 2023-11-08 13:45:28 +01:00
ganfra f067163004 Lockscreen : should fix tests 2023-11-08 12:01:54 +01:00
ganfra dc0c33fa5a Lock screen : fix code quality 2023-11-07 21:08:02 +01:00
ganfra 05e99adfc4 Lock : fix race condition on setup pin 2023-11-07 21:06:26 +01:00
ganfra 04afa8c200 LockScreen : fix one more navigation issue 2023-11-07 18:22:40 +01:00
ganfra 67bdb78f98 LockScreen : reduce delay before validation step in setup 2023-11-07 16:30:25 +01:00
ganfra d524e7b4bd LockScreen : do not show the entire setup flow when changing the pin is settings 2023-11-07 16:23:41 +01:00
ganfra 5a417ba498 LockScreen : refact some code and add secureFlag 2023-11-07 15:55:53 +01:00
Benoit Marty 7e63f196d9 Use ButtonColumnMolecule 2023-11-07 10:53:21 +01:00
bmarty 2fca8412b2 Sync Strings from Localazy 2023-11-06 08:23:40 +00:00
Benoit Marty 21200df294 Konsist: check that if sealed interface is used in parameter of Composable, it has the @Stable or @Immutable annotation 2023-11-03 15:19:55 +01:00
ganfra 01f4175b79 Pin unlock : implement design for in-app unlock 2023-10-31 20:12:45 +01:00
ganfra 6832b1f2db Feature/fga/biometric unlock (#1702) 
* Biometric unlock : refactor a bit existing classes

* Biometric unlock : first implementation

* Biometric: add ui for biometric setup

* Biometric unlock : use localazy strings

* Biometric unlock setup : branch skip/allow events

* Biometric : fix tests

* Biometrics: add small test

* Biometric : clean up

* Update screenshots

* Biometric unlock : address some PR review

* Biometric : improve a bit edge cases

* Fix lint issues

---------

Co-authored-by: ganfra <francoisg@element.io>
Co-authored-by: ElementBot <benoitm+elementbot@element.io>
Co-authored-by: Jorge Martín <jorgem@element.io>
 2023-10-31 19:22:43 +01:00
bmarty ffd02b831e Sync Strings from Localazy 2023-10-30 14:50:36 +00:00
bmarty 8350382440 Sync Strings from Localazy 2023-10-30 00:10:04 +00:00
Benoit Marty 3a15b92eb6 SecureBackup: update matrix sdk module. 2023-10-26 18:02:34 +02:00
ganfra b355d9fb64 PIN: address PR review 2023-10-26 15:28:18 +02:00
ganfra ca6a30d6cc PIN : fix quality 2023-10-26 15:25:40 +02:00
ganfra a7c83a94d3 PIN : Fix SetupPinPresenterTest 2023-10-26 14:39:13 +02:00
ganfra e864871c0e PIN : Fix test compilation 2023-10-26 13:10:25 +02:00
ganfra fdd9396089 Pin: add tests and make LockScreenConfig an injectable data class 2023-10-25 18:39:39 +02:00
ganfra 3c5bff0927 Pin : clean remaining pin code attempts 2023-10-25 16:54:34 +02:00
ganfra 626a884e1f PIN: clean pin code storage 2023-10-25 16:45:42 +02:00
ganfra adf21e0e02 PIN: fix and add tests 2023-10-25 16:13:30 +02:00
ganfra 49e2060961 PIN unlock : makes sure to load the pin size from storage 2023-10-25 15:07:05 +02:00
ganfra 2cb0addd3e PIN: add callback on LockScreenEntryPoint 2023-10-25 11:27:19 +02:00