From 1f6d1dbc0d52d5ab18a16a00e4648a0853656600 Mon Sep 17 00:00:00 2001 From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Date: Tue, 21 Apr 2026 15:07:54 +0100 Subject: [PATCH] Avoid nx jest executor for running unit tests (#33220) * Avoid nx jest executor for running unit tests The jest executor mangles the "summary of failing tests" from jest. * Remove unneded dep on nx/jest --- apps/web/project.json | 8 +++---- package.json | 1 - pnpm-lock.yaml | 56 ------------------------------------------- 3 files changed, 3 insertions(+), 62 deletions(-) diff --git a/apps/web/project.json b/apps/web/project.json index 9e8aecd4c9..abb5fc4757 100644 --- a/apps/web/project.json +++ b/apps/web/project.json @@ -47,11 +47,9 @@ "dependsOn": ["^build", "^build:playwright"] }, "test:unit": { - "executor": "@nx/jest:jest", - "options": { - "jestConfig": "{projectRoot}/jest.config.ts", - "cwd": "apps/web" - }, + // We avoid the jest executor because it doesn't seem to give any benefit, and it mangles the summary of failing tests. + "command": "jest", + "options": { "cwd": "apps/web" }, "dependsOn": ["^build"] }, "test:playwright": { diff --git a/package.json b/package.json index 4b106e190b..3ea94d762d 100644 --- a/package.json +++ b/package.json @@ -28,7 +28,6 @@ "@action-validator/cli": "^0.6.0", "@action-validator/core": "^0.6.0", "@nx-tools/nx-container": "^7.2.1", - "@nx/jest": "^22.5.0", "@playwright/test": "catalog:", "@types/node": "22", "cronstrue": "^3.0.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 4551df167d..70221567ba 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -121,9 +121,6 @@ importers: '@nx-tools/nx-container': specifier: ^7.2.1 version: 7.2.1(@nx/devkit@22.6.5(nx@22.6.5))(@nx/js@22.6.5(@babel/traverse@7.29.0)(nx@22.6.5))(dotenv@17.4.0)(nx@22.6.5)(tslib@2.8.1) - '@nx/jest': - specifier: ^22.5.0 - version: 22.6.5(@babel/traverse@7.29.0)(@types/node@18.19.130)(babel-plugin-macros@3.1.0)(nx@22.6.5)(typescript@5.9.3) '@playwright/test': specifier: 'catalog:' version: 1.59.1 @@ -3272,9 +3269,6 @@ packages: peerDependencies: nx: '>= 21 <= 23 || ^22.0.0-0' - '@nx/jest@22.6.5': - resolution: {integrity: sha512-Px+ROXwl3s8tjS3OEVMtNY5krQ2zAWyK7s922zmtbXjNKGZ8bg6krnkq7n5XpQwyXTZNVxku8TXcN7jXZECGFQ==} - '@nx/js@22.6.5': resolution: {integrity: sha512-bmikz6qaBHfuAgsqPB/TfLIKfvI4g+EKIRAiU2FHnEtVWOKDAmSQXHFwE3rMS49jl2JLgxkdNjZHpg4g/OLy0g==} peerDependencies: @@ -3930,11 +3924,6 @@ packages: resolution: {integrity: sha512-C2Xj8FZ0uHWeCXXqX5B4/gVFQmtSkiuOolzAgutjTfseNOHT3pUjljDZsTSxXFGgio54bCzVFqmEOUrIVk8RDA==} engines: {node: '>=20.0.0'} - '@phenomnomnominal/tsquery@6.1.4': - resolution: {integrity: sha512-3tHlGy/fxjJCHqIV8nelAzbRTNkCUY+k7lqBGKNuQz99H2OKGRt6oU+U2SZs6LYrbOe8mxMFl6kq6gzHapFRkw==} - peerDependencies: - typescript: ^3 || ^4 || ^5 - '@pkgjs/parseargs@0.11.0': resolution: {integrity: sha512-+1VkjdD0QBLPodGrJUeqarH8VAIvQODIbwh9XpP5Syisf7YoQgsJKPNFoqqLQlu+VQ/tVSshMR6loPMn8U+dPg==} engines: {node: '>=14'} @@ -5294,9 +5283,6 @@ packages: '@types/eslint@9.6.1': resolution: {integrity: sha512-FXx2pKgId/WyYo2jXw63kk7/+TY7u7AziEJxJAnSFzHlqTAS3Ync6SvgYAN/k4/PQpnnVuzoMuVnByKK2qp0ag==} - '@types/esquery@1.5.4': - resolution: {integrity: sha512-yYO4Q8H+KJHKW1rEeSzHxcZi90durqYgWVfnh5K6ZADVBjBv2e1NEveYX5yT2bffgN7RqzH3k9930m+i2yBoMA==} - '@types/estree@1.0.8': resolution: {integrity: sha512-dWHzHa2WqEXI/O1E9OjrocMTKJl2mSrEolh1Iomrv6U+JuNwaHXsXx9bLu5gG7BUWFIN0skIQJQ/L1rIex4X6w==} @@ -15898,38 +15884,6 @@ snapshots: tslib: 2.8.1 yargs-parser: 21.1.1 - '@nx/jest@22.6.5(@babel/traverse@7.29.0)(@types/node@18.19.130)(babel-plugin-macros@3.1.0)(nx@22.6.5)(typescript@5.9.3)': - dependencies: - '@jest/reporters': 30.3.0 - '@jest/test-result': 30.3.0 - '@nx/devkit': 22.6.5(nx@22.6.5) - '@nx/js': 22.6.5(@babel/traverse@7.29.0)(nx@22.6.5) - '@phenomnomnominal/tsquery': 6.1.4(typescript@5.9.3) - identity-obj-proxy: 3.0.0 - jest-config: 30.3.0(@types/node@18.19.130)(babel-plugin-macros@3.1.0) - jest-resolve: 30.3.0 - jest-util: 30.3.0 - minimatch: 10.2.4 - picocolors: 1.1.1 - resolve.exports: 2.0.3 - semver: 7.7.4 - tslib: 2.8.1 - yargs-parser: 21.1.1 - transitivePeerDependencies: - - '@babel/traverse' - - '@swc-node/register' - - '@swc/core' - - '@types/node' - - babel-plugin-macros - - debug - - esbuild-register - - node-notifier - - nx - - supports-color - - ts-node - - typescript - - verdaccio - '@nx/js@22.6.5(@babel/traverse@7.29.0)(nx@22.6.5)': dependencies: '@babel/core': 7.29.0 @@ -16631,12 +16585,6 @@ snapshots: tslib: 2.8.1 tsyringe: 4.10.0 - '@phenomnomnominal/tsquery@6.1.4(typescript@5.9.3)': - dependencies: - '@types/esquery': 1.5.4 - esquery: 1.7.0 - typescript: 5.9.3 - '@pkgjs/parseargs@0.11.0': optional: true @@ -17986,10 +17934,6 @@ snapshots: '@types/estree': 1.0.8 '@types/json-schema': 7.0.15 - '@types/esquery@1.5.4': - dependencies: - '@types/estree': 1.0.8 - '@types/estree@1.0.8': {} '@types/events@3.0.3': {}