Show a 'grab' cursor on picture-in-picture view (#33079)

* Remove unused 'draggable' prop from PictureInPictureDragger

* Show a 'grab' cursor on picture-in-picture view

To give it a proper affordance for dragging.
This commit is contained in:
Robin
2026-04-09 14:25:14 +02:00
committed by GitHub
parent 70e40009a3
commit 253dcb44dd
7 changed files with 32 additions and 51 deletions
@@ -37,9 +37,7 @@ interface IChildrenOptions {
}
interface IProps {
className?: string;
children: Array<CreatePipChildren>;
draggable: boolean;
onDoubleClick?: () => void;
onMove?: () => void;
}
@@ -181,9 +179,6 @@ export default class PictureInPictureDragger extends React.Component<IProps> {
};
private onStartMoving = (event: React.MouseEvent | MouseEvent): void => {
event.preventDefault();
event.stopPropagation();
this.mouseHeld = true;
this.startingPositionX = event.clientX;
this.startingPositionY = event.clientY;
@@ -217,9 +212,6 @@ export default class PictureInPictureDragger extends React.Component<IProps> {
private onEndMoving = (event: MouseEvent): void => {
if (!this.mouseHeld) return;
event.preventDefault();
event.stopPropagation();
this.mouseHeld = false;
// Delaying this to the next event loop tick is necessary for click
// event cancellation to work
@@ -250,7 +242,7 @@ export default class PictureInPictureDragger extends React.Component<IProps> {
return (
<aside
className={this.props.className}
className="mx_PictureInPictureDragger"
style={style}
ref={this.callViewWrapper}
onClickCapture={this.onClickCapture}
@@ -266,12 +266,7 @@ class PipContainerInner extends React.Component<IProps, IState> {
if (pipContent.length) {
return (
<PictureInPictureDragger
className="mx_LegacyCallPreview"
draggable={pipMode}
onDoubleClick={this.onDoubleClick}
onMove={this.onMove}
>
<PictureInPictureDragger onDoubleClick={this.onDoubleClick} onMove={this.onMove}>
{pipContent}
</PictureInPictureDragger>
);