From 2d247782143608d5c0d5b7c1dc11fd781ab70991 Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Thu, 11 Jun 2026 11:37:47 +0100
Subject: [PATCH] Fix modules dir tsc not running in CI (#33811)

* Fix modules dir tsc not running in CI

* Switch to nx run-many for ci task

This has smarter scheduling logic for dependant tasks
---
 .github/workflows/static_analysis.yaml | 2 +-
 apps/desktop/package.json              | 5 ++++-
 modules/package.json                   | 2 +-
 modules/project.json                   | 5 +++++
 package.json                           | 3 ++-
 5 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/static_analysis.yaml b/.github/workflows/static_analysis.yaml
index bc806a9788..e2b7a3d352 100644
--- a/.github/workflows/static_analysis.yaml
+++ b/.github/workflows/static_analysis.yaml
@@ -68,7 +68,7 @@ jobs:
               run: "pnpm install --frozen-lockfile"
 
             - name: Run ${{ matrix.command }}
-              run: pnpm --if-present run "$CMD" && pnpm -r --workspace-concurrency=1 --if-present run "$CMD"
+              run: pnpm nx run-many -t "$CMD" -p
               env:
                   CMD: ${{ matrix.command }}
 
diff --git a/apps/desktop/package.json b/apps/desktop/package.json
index ebdf484b19..43b5eae3d4 100644
--- a/apps/desktop/package.json
+++ b/apps/desktop/package.json
@@ -112,6 +112,9 @@
         "matrix-seshat": "4.3.0"
     },
     "nx": {
-        "includedScripts": []
+        "includedScripts": [
+            "lint:types",
+            "lint:js"
+        ]
     }
 }
diff --git a/modules/package.json b/modules/package.json
index fc69d1e1fa..dc6ab6854a 100644
--- a/modules/package.json
+++ b/modules/package.json
@@ -4,7 +4,7 @@
     "type": "module",
     "scripts": {
         "lint:js": "eslint --max-warnings 0 playwright */src -c ./.eslintrc.cjs",
-        "lint:ts": "tsc --noEmit",
+        "lint:types": "nx lint:types --",
         "test:playwright": "nx test:playwright --",
         "test:playwright:open": "nx test:playwright -- --ui",
         "test:playwright:screenshots": "nx test:playwright:screenshots --"
diff --git a/modules/project.json b/modules/project.json
index 0d7a172ea8..4e6fda6f67 100644
--- a/modules/project.json
+++ b/modules/project.json
@@ -3,6 +3,11 @@
     "projectType": "library",
     "implicitDependencies": ["modules/*"],
     "targets": {
+        "lint:types": {
+            "command": "tsc --noEmit",
+            "options": { "cwd": "modules" },
+            "dependsOn": ["^build:playwright"]
+        },
         "test:playwright": {
             "command": "playwright test",
             "options": { "cwd": "modules" },
diff --git a/package.json b/package.json
index fe4aa7b4a3..3d482dbcd0 100644
--- a/package.json
+++ b/package.json
@@ -59,5 +59,6 @@
             "onFail": "error"
         }
     },
-    "private": true
+    "private": true,
+    "nx": {}
 }