enki/blap
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 6 Wiki Activity

Fix pinned message banner disappearing when a pinned message event is unkown (#33534)

Browse Source 
* fix: remove unknown event when fetching pinned message events

* test: update tsts
This commit is contained in:
Florian Duros
2026-05-20 11:40:09 +02:00
committed by GitHub
parent d41ff70057
commit 4b6e0b7ebf
4 changed files with 34 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/test/unit-tests/components/views/right_panel/PinnedMessagesCard-test.tsx
+17
View File
@@ -294,6 +294,23 @@ describe("<PinnedMessagesCard />", () => {
await initPinnedMessagesCard([], [pin]);
expect(screen.queryAllByRole("listitem")).toHaveLength(0);
});
it("should filter out null events returned by useFetchedPinnedEvents and only display valid events", async () => {
// RoomCreate is not a pinnable event type — useFetchedPinnedEvents returns null for it
const unpinnableEvent = mkEvent({
event: true,
type: EventType.RoomCreate,
content: {},
room: "!room:example.org",
user: "@alice:example.org",
});
// pin1 is a valid pinnable message, unpinnableEvent causes useFetchedPinnedEvents to return null
// useSortedFetchedPinnedEvents must filter out the null, leaving only pin1
await initPinnedMessagesCard([pin1], [unpinnableEvent]);
await waitFor(() => expect(screen.queryAllByRole("listitem")).toHaveLength(1));
expect(screen.getByText("First pinned message")).toBeInTheDocument();
});
});
describe("unpin all", () => {
apps/web/test/unit-tests/components/views/right_panel/__snapshots__/PinnedMessagesCard-test.tsx.snap
+9 -9
View File
@@ -329,7 +329,7 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
</p>
</div>
<button
aria-labelledby="_r_10f_"
aria-labelledby="_r_10u_"
class="_icon-button_1215g_8"
data-kind="secondary"
data-testid="base-card-close-button"
@@ -387,13 +387,13 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
class="mx_PinnedEventTile_top"
>
<span
aria-labelledby="_r_10m_"
aria-labelledby="_r_115_"
class="mx_PinnedEventTile_sender mx_Username_color3"
>
@alice:example.org
</span>
<button
aria-describedby="_r_10l_"
aria-describedby="_r_114_"
aria-disabled="false"
aria-expanded="false"
aria-haspopup="menu"
@@ -401,7 +401,7 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
class="_icon-button_1215g_8"
data-kind="primary"
data-state="closed"
id="radix-_r_10r_"
id="radix-_r_11a_"
role="button"
style="--cpd-icon-button-size: 24px;"
tabindex="0"
@@ -427,7 +427,7 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
</div>
<div
class="mx_MTextBody mx_EventTile_content _root_1hgc7_8 _text_1hgc7_13"
id="_r_10l_"
id="_r_114_"
>
<div
class="mx_EventTile_body translate"
@@ -468,13 +468,13 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
class="mx_PinnedEventTile_top"
>
<span
aria-labelledby="_r_10u_"
aria-labelledby="_r_11d_"
class="mx_PinnedEventTile_sender mx_Username_color3"
>
@alice:example.org
</span>
<button
aria-describedby="_r_10t_"
aria-describedby="_r_11c_"
aria-disabled="false"
aria-expanded="false"
aria-haspopup="menu"
@@ -482,7 +482,7 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
class="_icon-button_1215g_8"
data-kind="primary"
data-state="closed"
id="radix-_r_113_"
id="radix-_r_11i_"
role="button"
style="--cpd-icon-button-size: 24px;"
tabindex="0"
@@ -508,7 +508,7 @@ exports[`<PinnedMessagesCard /> unpin all should not allow to unpinall 1`] = `
</div>
<div
class="mx_MTextBody mx_EventTile_content _root_1hgc7_8 _text_1hgc7_13"
id="_r_10t_"
id="_r_11c_"
>
<div
class="mx_EventTile_body translate"