Fix OIDC login callback handling on Element Desktop (#33332)

* Fix OIDC login callback handling on Element Desktop

* Add unit tests

* Iterate

* Fix lcov reporter

* Fix coverage paths

* Fix coverage upload

* Ensure `.test.ts` files don't get included in the desktop package

* Fix coverage artifact name

* Delint

* Tidy coverage name

* Improve coverage

.github/workflows/tests.yml

@@ -93,7 +93,7 @@ jobs:
               if: env.ENABLE_COVERAGE == 'true'
               uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
               with:
-                  name: coverage-${{ matrix.runner }}
+                  name: coverage-jest-${{ matrix.runner }}
                   path: |
                       apps/web/coverage
                       !apps/web/coverage/lcov-report
@@ -124,9 +124,10 @@ jobs:
         name: Vitest
         strategy:
             matrix:
-                package:
-                    - shared-components
-                    - module-api
+                path:
+                    - apps/desktop
+                    - packages/shared-components
+                    - packages/module-api
         runs-on: ubuntu-24.04
         steps:
             - name: Checkout code
@@ -149,30 +150,39 @@ jobs:
               uses: actions/cache@27d5ce7f107fe9357f9df03efb73ab90386fccae # v5
               with:
                   path: |
-                      packages/${{ matrix.package }}/node_modules/.cache
-                      packages/${{ matrix.package }}/node_modules/.vite/vitest
-                  key: ${{ hashFiles('pnpm-lock.yaml') }}
+                      ${{ matrix.path }}/node_modules/.cache
+                      ${{ matrix.path }}/node_modules/.vite/vitest
+                  key: ${{ matrix.path }}-${{ hashFiles('pnpm-lock.yaml') }}
 
             - name: Setup playwright
               uses: ./.github/actions/setup-playwright
-              if: matrix.package == 'shared-components'
+              if: matrix.path == 'packages/shared-components'
               with:
                   write-cache: ${{ github.event_name != 'merge_group' }}
 
             - name: Run tests
-              working-directory: "packages/${{ matrix.package }}"
+              working-directory: ${{ matrix.path }}
               run: pnpm test:unit --coverage=$ENABLE_COVERAGE
 
             # Dump the disk usage on failure, because this job seems to fail with disk fills sometimes
             - name: df
-              run: df
+              run: df -h && df -i
               if: ${{ failure() }}
 
+            - name: Calculate artifact name
+              if: env.ENABLE_COVERAGE == 'true'
+              id: artifact
+              run: |
+                  NAME=$(basename "$MATRIX_PATH")
+                  echo "name=$NAME" >> $GITHUB_OUTPUT
+              env:
+                  MATRIX_PATH: ${{ matrix.path }}
+
             - name: Upload Artifact
               if: env.ENABLE_COVERAGE == 'true'
               uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7
               with:
-                  name: coverage-${{ matrix.package }}
+                  name: coverage-${{ steps.artifact.outputs.name }}
                   path: |
-                      packages/${{ matrix.package }}/coverage
-                      !packages/${{ matrix.package }}/coverage/lcov-report
+                      ${{ matrix.path }}/coverage
+                      !${{ matrix.path }}/coverage/lcov-report