a09f773edd
Tweak sticky header hiding to avoid pop
...
When transitioning between sublists, there can be a visibly observable jump in
the positioning of list items when the header container is restored to normal
size outside of sticky mode.
To avoid this problem, this leaves all headers at normal size. This creates a
new issue of a permanent gap at the top of the list for the first header, but
this can be solved by always hiding (since it can only ever appear stuck to
top).
Fixes https://github.com/vector-im/riot-web/issues/14429
2020-07-14 12:16:17 +01:00
f394190423
Merge pull request #4973 from matrix-org/t3chguy/room-list/14395
...
Fix show-all keyboard focus regression
2020-07-14 09:56:03 +01:00
03f94779f1
Fix show-all keyboard focus regression
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-14 09:38:31 +01:00
f16962bb41
Merge pull request #4970 from matrix-org/travis/room-list/prelaunch/1-cleanup
...
Clean up TODOs, comments, and imports in the new room list
2020-07-14 09:38:30 +01:00
bdb136e24e
Clean up TODOs, comments, and imports in the new room list
...
Fixes https://github.com/vector-im/riot-web/issues/14412
2020-07-13 20:25:02 -06:00
917c41dfa0
Update sticky headers when breadcrumbs pop in or out
...
Fixes https://github.com/vector-im/riot-web/issues/14455
2020-07-13 20:08:12 -06:00
a3a1e2e01f
Fix show less button occluding the last tile
...
Fixes https://github.com/vector-im/riot-web/issues/14450
People may have to click various combinations of 'show more' and 'show less' until it fixes itself, as their layout could be a bit weird now.
2020-07-13 16:38:13 -06:00
4b5faf8148
Update top vs. bottom sticky styles separately
...
If a sublist changes from sticky top to sticky bottom in a single run of the
logic (without passing through the default state), we were leaving the previous
top position set. This handles them independently to resolve this.
Fixes https://github.com/vector-im/riot-web/issues/14390
Maybe helps with https://github.com/vector-im/riot-web/issues/14443
For vector-im/riot-web#13635
2020-07-13 21:24:47 +01:00
8e982f52ff
Fix extra room tiles being rendered on smaller sublists
...
Fixes https://github.com/vector-im/riot-web/issues/14426
The issue only applies to lists which won't have a 'show less' button, as the lists with the button would have the button's height considered when determining visible tiles. For lists that were under that (1-4 rooms), the show more button wasn't being considered and thus leading to the padding being added rather than subtracted, causing an extra tile to render.
By ensuring we include the padding for both show more and show less, we ensure that no extra tiles get rendered and that the cutoff semantics are still present.
2020-07-13 12:59:09 -06:00
cc49e645b7
Merge pull request #4961 from matrix-org/t3chguy/room-list/14273
...
Fix room sub list header collapse/jump interactions on bottom-most sublist
2020-07-13 17:36:13 +01:00
fd8f43e245
Fix room sub list header collapse/jump interactions on bottom-most sublist
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-13 17:17:05 +01:00
3060cdf934
Iterate PR
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-13 17:01:50 +01:00
5bee948717
Fix room tile context menu for Historical rooms
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-13 16:35:03 +01:00
71e97177b0
Merge pull request #4957 from matrix-org/joriks/room-list-avatar-aspect-ratio
...
Stop classname from overwritting baseavatar's
2020-07-13 16:02:06 +01:00
1ce3ae0cf2
Merge pull request #4952 from matrix-org/t3chguy/room-list/14413
...
Remove redundant scroll-margins and fix RoomTile wrongly scrolling
2020-07-13 15:57:27 +01:00
3e2280a6f4
Stop classname from overwritting baseavatar's
2020-07-13 15:43:34 +01:00
3c096fdf23
Merge pull request #4953 from matrix-org/t3chguy/fix/14402
...
Fix RoomAvatar viewAvatarOnClick to work on actual avatars instead of default ones
2020-07-13 15:28:29 +01:00
72407a30d3
Merge pull request #4954 from matrix-org/t3chguy/room-list/14409
...
Room List v2 Enter in the filter field should select the first result
2020-07-13 15:27:16 +01:00
0908e813fb
Merge branch 'develop' into travis/room-list/enable
2020-07-12 22:50:27 -06:00
d253c58830
Room List v2 Enter in the filter field should select the first result
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-12 19:06:47 +01:00
71ecd5dc85
clean-up
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-12 18:40:24 +01:00
3f51bb84e1
Fix RoomAvatar viewAvatarOnClick to work on actual avatars instead of default ones
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-12 18:24:28 +01:00
213e2df9fc
Remove redundant scroll-margins and fix RoomTile wrongly scrolling
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-07-12 08:49:04 +01:00
cfc39dc4a9
Remove now-dead code from sublist resizing
2020-07-10 16:10:05 -06:00
bdb641279a
Merge branch 'develop' into travis/room-list/enable
2020-07-10 11:11:25 -06:00
1175eb001f
Fix bad merge
2020-07-10 11:01:11 -06:00
477472c178
Merge branch 'develop' into travis/room-list/showmore2
2020-07-10 10:57:17 -06:00
ae8d6f5523
make tsc happy
2020-07-10 18:48:54 +02:00
15ea3a5287
add types
2020-07-10 18:42:51 +02:00
85ac256231
cleanup
2020-07-10 18:40:09 +02:00
e2aa6ecf6b
fix show X more counter
2020-07-10 18:40:09 +02:00
86817430c5
update initially shown amount of tiles on component update
...
as rooms aren't all available at ctor time
2020-07-10 18:40:09 +02:00
96f2968854
make all height changes update component state
...
also set visibleTiles as side-effect
2020-07-10 18:40:09 +02:00
652fb9e613
track height in pixels in component state
2020-07-10 18:40:09 +02:00
49f7170d95
extract type
2020-07-10 18:31:53 +02:00
725b7f8950
make show more button a bit less tall
2020-07-10 18:30:52 +02:00
d5a3071518
put show more button inside resizer
...
this way we have a flexbox layout in the resizer with:
- the resize handle (fixed)
- the show more/less button, if any (fixed)
- the list of tiles (grabbing whatever is left)
2020-07-10 18:29:39 +02:00
bf0a503e44
[WITH CONFLICTS] Merge branch 'develop' into travis/room-list/enable
2020-07-10 10:18:12 -06:00
840a4127db
Merge pull request #4944 from matrix-org/travis/room-list/perf/log-disable
...
Add an option to disable room list logging, and improve logging
2020-07-10 07:16:56 -06:00
75dbd5f1d4
Merge branch 'develop' into travis/room-list/enable
2020-07-09 22:28:16 -06:00
ceff68476d
Remove useless dispatches
2020-07-10 02:25:47 +01:00
1983591cbf
Remove unused actions
2020-07-10 02:22:34 +01:00
cf154ec9cf
Add an option to disable room list logging, and improve logging
...
For https://github.com/vector-im/riot-web/issues/14035
**This option is not recommended as it completely obliterates all chances of being able to support someone with a broken room list. It is intended for specific testing scenarios only.**
2020-07-09 18:19:38 -06:00
859f65659c
Attempt to support a hard cutoff with the show more button
...
Known issues:
* Causes scroll jumps when the button gets added to DOM
* Resize handle is invisible when there's a show more button
TODO:
* Clean up comments
* Clean up useless code (all the padding stuff isn't needed)
2020-07-09 13:07:13 -06:00
ce68314de9
Revert "Merge pull request #4932 from matrix-org/travis/room-list/invisible-show-more"
...
This reverts commit f58a0a7538
2020-07-09 12:13:12 -06:00
8a7bebc6bf
lint
2020-07-09 18:37:18 +01:00
ade89ab4e9
Move sublist auto expand to out from layouts
...
Co-authored-by: Travis Ralston <travpc@gmail.com >
2020-07-09 18:32:28 +01:00
9b79de7fe7
Merge branch 'develop' of github.com:matrix-org/matrix-react-sdk into joriks/room-list-auto-expand-on-search
2020-07-09 17:14:52 +01:00
d94b6e2b36
Merge pull request #4937 from matrix-org/joriks/appearance-tab-irc-setting-in-advanced
...
Move irc layout option to advanced
2020-07-09 16:20:37 +01:00
1033eda7fb
Move irc layout option to advanced
2020-07-09 15:54:44 +01:00
J. Ryan Stinnett