02b6520f09
* Initial reword of upload to MVVM. * Update tests * More incremental improvements * Refactor tests to use helper method for composer uploads. * Add drag and drop tests * lint * Add commentary * fixup test * More precise selector * Retarget uploads * lint * fixup * one more type * update snap * Fixup composerUploadFiles * fix import * lint * Copy and paste fixes too * Add tests for pasting * Add tests for pasting files. * Remove redundant fn * rm comment * tidy up * Test cleanup * More clean up * another fix * Begin fleshing out * Park changes * More stuff * Use condensed version * Cleanup tests * more cleaning * last bity * Add a test for the composer * Park up changes * Rewrite Measured to be a functional component * Add tests to cover narrow viewports * lint * breakpoint is optional * Cleanup * Support narrow mode * fixup * begone * Provide default value * add label * fixup test * update copyright * cleanup * Be a bit more lazy with FileDropTarget * remove a debug statement * Fixup * fix two snaps * Update screenshot * and the other one * Update snaps * unfake CIDER * update screens again * remove extra test * Undo accidental snapshots * Bit of tidyup * fixup * even more tidyup * may drag and drop file * tidy up again * snap snap snap * Use load to make sonarQube happy * Bunch of refactors * More cleanup * cleanup debug code * tweaks * remove a test we no longer need * make it happy * fix import * fixup * Update snaps * typo * one off * Add tests * lint * remove only * Reduce screenshot scope * fix snapshot usage * cleanup
254 lines
9.4 KiB
TypeScript
254 lines
9.4 KiB
TypeScript
/*
|
|
* Copyright (c) 2026 Element Creations Ltd.
|
|
*
|
|
* SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
|
|
* Please see LICENSE files in the repository root for full details.
|
|
*/
|
|
import React from "react";
|
|
import { type IEventRelation, type MatrixClient, type Room, RoomEvent } from "matrix-js-sdk/src/matrix";
|
|
import { render } from "jest-matrix-react";
|
|
|
|
import type { MockedObject } from "jest-mock";
|
|
import { RoomUploadContextProvider, RoomUploadViewModel } from "../../../src/viewmodels/room/RoomUploadViewModel";
|
|
import { getRoomContext, mkEvent, mkStubRoom, stubClient } from "../../test-utils";
|
|
import { TimelineRenderingType } from "../../../src/contexts/RoomContext";
|
|
import defaultDispatcher, { MatrixDispatcher } from "../../../src/dispatcher/dispatcher";
|
|
import ContentMessages from "../../../src/ContentMessages";
|
|
import { ComposerApi } from "../../../src/modules/ComposerApi";
|
|
import type { ComposerInsertFilesPayload } from "../../../src/dispatcher/payloads/ComposerInsertFilePayload";
|
|
import { ScopedRoomContextProvider } from "../../../src/contexts/ScopedRoomContext";
|
|
import { Action } from "../../../src/dispatcher/actions";
|
|
import MatrixClientContext from "../../../src/contexts/MatrixClientContext";
|
|
const sendContentListToRoomSpy = jest.spyOn(ContentMessages.sharedInstance(), "sendContentListToRoom");
|
|
|
|
describe("RoomUploadViewModel", () => {
|
|
let client: MockedObject<MatrixClient>;
|
|
let room: MockedObject<Room>;
|
|
let dis: MockedObject<MatrixDispatcher>;
|
|
beforeEach(() => {
|
|
jest.clearAllMocks();
|
|
client = stubClient() as MockedObject<MatrixClient>;
|
|
room = mkStubRoom("!room", undefined, undefined) as MockedObject<Room>;
|
|
dis = {
|
|
dispatch: jest.fn(),
|
|
} as Partial<MatrixDispatcher> as MockedObject<MatrixDispatcher>;
|
|
});
|
|
afterAll(() => {
|
|
jest.restoreAllMocks();
|
|
});
|
|
|
|
it.each([true, false])("handles state when room.maySendMessage = %s", (maySendMessage) => {
|
|
room.maySendMessage.mockReturnValue(maySendMessage);
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
expect(vm.getSnapshot().options).toHaveLength(maySendMessage ? 1 : 0);
|
|
room.maySendMessage.mockReturnValue(!maySendMessage);
|
|
room.emit(RoomEvent.CurrentStateUpdated, room, null as any, null as any);
|
|
expect(vm.getSnapshot().options).toHaveLength(maySendMessage ? 0 : 1);
|
|
});
|
|
|
|
it("handles custom upload option", async () => {
|
|
const compApi = new ComposerApi(new MatrixDispatcher());
|
|
const replyEv = mkEvent({ type: "fake", content: {}, user: "any", event: true });
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
replyEv,
|
|
{
|
|
rel_type: "any_type",
|
|
},
|
|
() => {},
|
|
compApi,
|
|
);
|
|
const onSelected = jest.fn();
|
|
const icon = { myicon: 5 } as any;
|
|
compApi.addFileUploadOption({
|
|
type: "org.example.test",
|
|
label: "My uploader",
|
|
icon,
|
|
onSelected,
|
|
});
|
|
expect(vm.getSnapshot().options).toContainEqual({ type: "org.example.test", label: "My uploader", icon });
|
|
vm.onUploadOptionSelected("org.example.test");
|
|
expect(onSelected).toHaveBeenCalledWith(
|
|
room.roomId,
|
|
{ view: "room" },
|
|
{
|
|
inReplyToEventId: replyEv.getId(),
|
|
relType: "any_type",
|
|
},
|
|
);
|
|
});
|
|
|
|
describe("uploads via input", () => {
|
|
it("redirected if guest", async () => {
|
|
client.isGuest.mockReturnValue(true);
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
await vm.initiateViaInputFiles([] as unknown as FileList);
|
|
expect(dis.dispatch).toHaveBeenCalledWith({ action: "require_registration" });
|
|
});
|
|
it("skips empty files", async () => {
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
await vm.initiateViaInputFiles([] as unknown as FileList);
|
|
expect(dis.dispatch).not.toHaveBeenCalled();
|
|
});
|
|
it("uploads with correct context", async () => {
|
|
sendContentListToRoomSpy.mockResolvedValue(undefined);
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Thread,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
const replyEvent = mkEvent({ event: true, type: "anything", user: "anyone", content: {} });
|
|
vm.setReplyToEvent(replyEvent);
|
|
const threadRelation: IEventRelation = { key: "foo" };
|
|
vm.setThreadRelation(threadRelation);
|
|
const fileList = [
|
|
{
|
|
name: "fake.png",
|
|
size: 1024,
|
|
type: "image/png",
|
|
},
|
|
] as unknown as FileList;
|
|
await vm.initiateViaInputFiles(fileList);
|
|
expect(sendContentListToRoomSpy).toHaveBeenCalledWith(
|
|
fileList,
|
|
room.roomId,
|
|
threadRelation,
|
|
replyEvent,
|
|
client,
|
|
TimelineRenderingType.Thread,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("uploads via data transfer", () => {
|
|
it("redirected if guest", async () => {
|
|
client.isGuest.mockReturnValue(true);
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
await vm.initiateViaDataTransfer({} as DataTransfer);
|
|
expect(dis.dispatch).toHaveBeenCalledWith({ action: "require_registration" });
|
|
});
|
|
it("skips empty files", async () => {
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
await vm.initiateViaDataTransfer({ files: [] as unknown as FileList } as DataTransfer);
|
|
expect(dis.dispatch).not.toHaveBeenCalled();
|
|
});
|
|
it("uploads with correct context", async () => {
|
|
sendContentListToRoomSpy.mockResolvedValue(undefined);
|
|
const vm = new RoomUploadViewModel(
|
|
room,
|
|
client,
|
|
TimelineRenderingType.Thread,
|
|
dis,
|
|
undefined,
|
|
undefined,
|
|
() => {},
|
|
);
|
|
const replyEvent = mkEvent({ event: true, type: "anything", user: "anyone", content: {} });
|
|
vm.setReplyToEvent(replyEvent);
|
|
const threadRelation: IEventRelation = { key: "foo" };
|
|
vm.setThreadRelation(threadRelation);
|
|
const files = [
|
|
{
|
|
name: "fake.png",
|
|
size: 1024,
|
|
type: "image/png",
|
|
},
|
|
] as unknown as FileList;
|
|
await vm.initiateViaDataTransfer({ files } as DataTransfer);
|
|
expect(sendContentListToRoomSpy).toHaveBeenCalledWith(
|
|
files,
|
|
room.roomId,
|
|
threadRelation,
|
|
replyEvent,
|
|
client,
|
|
TimelineRenderingType.Thread,
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("RoomUploadContextProvider", () => {
|
|
it("uploads when called via module API", async () => {
|
|
sendContentListToRoomSpy.mockResolvedValue(undefined);
|
|
render(
|
|
<MatrixClientContext.Provider value={client}>
|
|
<ScopedRoomContextProvider {...getRoomContext(room, {})}>
|
|
<RoomUploadContextProvider>
|
|
<p>Any child</p>
|
|
</RoomUploadContextProvider>
|
|
</ScopedRoomContextProvider>
|
|
</MatrixClientContext.Provider>,
|
|
);
|
|
const files = [
|
|
{
|
|
name: "fake.png",
|
|
size: 1024,
|
|
type: "image/png",
|
|
},
|
|
] as File[];
|
|
defaultDispatcher.dispatch(
|
|
{
|
|
action: Action.ComposerFileInsert,
|
|
files,
|
|
timelineRenderingType: TimelineRenderingType.Room,
|
|
} satisfies ComposerInsertFilesPayload,
|
|
true,
|
|
);
|
|
expect(sendContentListToRoomSpy).toHaveBeenCalledWith(
|
|
files,
|
|
room.roomId,
|
|
undefined,
|
|
undefined,
|
|
client,
|
|
TimelineRenderingType.Room,
|
|
);
|
|
});
|
|
});
|
|
});
|