Mirror/ergo
1
0
Fork 0
mirror of https://github.com/jeremyd/ergo.git synced 2026-06-11 15:23:31 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #615 from slingamn/sessions_optimization

Browse Source 
optimize Sessions() at the expense of AddSession()
This commit is contained in:
Daniel Oaks
2019-08-25 09:57:51 +10:00
committed by GitHub
parent 8bca8a1752 65834c0729
commit 014a5fe63c
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
irc/getters.go
+5 -3
View File
@@ -43,8 +43,7 @@ func (server *Server) Languages() (lm *languages.Manager) {
func (client *Client) Sessions() (sessions []*Session) {
client.stateMutex.RLock()
sessions = make([]*Session, len(client.sessions))
copy(sessions, client.sessions)
sessions = client.sessions
client.stateMutex.RUnlock()
return
}
@@ -102,7 +101,10 @@ func (client *Client) AddSession(session *Session) (success bool) {
}
// success, attach the new session to the client
session.client = client
client.sessions = append(client.sessions, session)
newSessions := make([]*Session, len(client.sessions)+1)
copy(newSessions, client.sessions)
newSessions[len(newSessions)-1] = session
client.sessions = newSessions
return true
}