Mirror/ergo
1
0
Fork 0
mirror of https://github.com/jeremyd/ergo.git synced 2026-06-11 23:33:31 -07:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1857 from slingamn/dollarsign

Browse Source 
disallow initial $ in nicknames
This commit is contained in:
Shivaram Lingamneni
2021-12-09 04:17:57 -05:00
committed by GitHub
parent e5dff58647 f40d868cf5
commit ac17bf0e9d
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
irc/client_lookup_set.go
+8 -2
View File
@@ -97,8 +97,14 @@ func (clients *ClientManager) SetNick(client *Client, session *Session, newNick
realname := client.realname
client.stateMutex.RUnlock()
if newNick != accountName && strings.ContainsAny(newNick, disfavoredNameCharacters) {
return "", errNicknameInvalid, false
// these restrictions have grandfather exceptions for nicknames registered
// on previous versions of Ergo:
if newNick != accountName {
// can't contain "disfavored" characters like <, or start with a $ because
// it collides with the massmessage mask syntax:
if strings.ContainsAny(newNick, disfavoredNameCharacters) || strings.HasPrefix(newNick, "$") {
return "", errNicknameInvalid, false
}
}
// recompute always-on status, because client.alwaysOn is not set for unregistered clients