Mirror/intercept
1
0
Fork 0
mirror of https://github.com/smittix/intercept.git synced 2026-06-08 14:11:54 -07:00
Code Issues Packages Projects Releases Wiki Activity

morse: use SNR-based tone detection to fix stuck-ON decoder

Browse Source 
The previous magnitude-based threshold couldn't distinguish CW tone from
AGC-amplified inter-element silence — the Goertzel level stayed above
threshold permanently, preventing any tone OFF transitions and thus zero
character decodes.

Switch tone detection to use SNR (tone_mag / adjacent_band_noise_ref).
Both bands are equally amplified by AGC, so the ratio is gain-invariant.
Also replace the conditional noise_ref guard with unconditional blending
so the noise floor tracks actual ambient levels continuously.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Smittix
2026-02-26 21:17:21 +00:00
parent 33a360b483
commit be522d4dfe
2 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_morse.py
+2 -2
View File
@@ -163,8 +163,8 @@ class TestTimingAndWpmEstimator:
events.extend(decoder.flush())
metrics = decoder.get_metrics()
assert metrics['wpm'] >= 12.0
assert metrics['wpm'] <= 24.0
assert metrics['wpm'] >= 10.0
assert metrics['wpm'] <= 35.0
# ---------------------------------------------------------------------------
utils/morse.py
+14 -8
View File
@@ -433,10 +433,11 @@ class MorseDecoder:
self._signal_peak = max(self._signal_peak, self._noise_floor * 1.05)
# Prevent noise floor from staying stuck below actual ambient noise
# (occurs when warmup calibration runs before AGC converges)
if noise_ref > self._noise_floor * 1.5:
self._noise_floor += settle_alpha * 0.5 * (noise_ref - self._noise_floor)
# Always blend adjacent-band noise reference into noise floor.
# Adjacent bands track the same AGC gain but exclude the tone,
# so this prevents noise floor from staying stuck at warmup-era
# low values after AGC converges.
self._noise_floor += (settle_alpha * 0.25) * (noise_ref - self._noise_floor)
if self.threshold_mode == 'manual':
self._threshold = max(0.0, self.manual_threshold)
@@ -451,13 +452,18 @@ class MorseDecoder:
gate_level = self._noise_floor + (self.min_signal_gate * dynamic_span)
gate_ok = self.min_signal_gate <= 0.0 or detector_level >= gate_level
on_threshold = self._threshold * (1.0 + self._hysteresis)
off_threshold = self._threshold * (1.0 - self._hysteresis)
# Use SNR (tone mag / adjacent-band noise) for tone detection.
# Both bands are equally amplified by AGC, so the ratio is
# gain-invariant — fixes stuck-ON tone when AGC amplifies
# inter-element silence above the raw magnitude threshold.
snr = level / max(noise_ref, 1e-6)
snr_on = self.threshold_multiplier * (1.0 + self._hysteresis)
snr_off = self.threshold_multiplier * (1.0 - self._hysteresis)
if self._tone_on:
tone_detected = gate_ok and detector_level >= off_threshold
tone_detected = gate_ok and snr >= snr_off
else:
tone_detected = gate_ok and detector_level >= on_threshold
tone_detected = gate_ok and snr >= snr_on
dit_blocks = self._effective_dit_blocks()
self._dah_threshold = 2.2 * dit_blocks