improve basic logging

This commit is contained in:
Brad Warren
2026-06-18 14:01:42 -07:00
committed by Will Greenberg
parent 2702ee0828
commit f5a0cddc88
3 changed files with 16 additions and 6 deletions
Generated
+1
View File
@@ -2949,6 +2949,7 @@ dependencies = [
"anyhow",
"clap",
"installer",
"log",
"serde",
"serde_json",
"shlex",
+1
View File
@@ -24,3 +24,4 @@ serde_json = "1"
anyhow = "1.0.100"
shlex = "1"
installer = { path = "../../installer" }
log = "0.4.20"
+14 -6
View File
@@ -26,10 +26,15 @@ impl Command<'_> {
// by subcommand_modifiers()
subcommands: modifiers::subcommand_modifiers()
.iter()
.filter_map(|modifier| {
subcommand_map
.get(modifier.command)
.map(|subcommand| Subcommand::new(subcommand, modifier))
.filter_map(|modifier| match subcommand_map.get(modifier.command) {
Some(clap_command) => Some(Subcommand::new(clap_command, modifier)),
None => {
error!(
"failed to find clap command for subcommand {}",
modifier.command
);
None
}
})
.collect(),
}
@@ -90,13 +95,16 @@ impl Subcommand<'_> {
.iter()
.filter_map(|arg_modifier| {
let Some(arg) = argument_map.get(arg_modifier.clap_id) else {
error!("failed to get argument with id {arg_modifier.clap_id}");
error!(
"failed to find clap argument with id {}",
arg_modifier.clap_id
);
return None;
};
match Argument::try_new(arg, arg_modifier) {
Ok(modified_arg) => Some(modified_arg),
Err(err) => {
error!("failed to modify arg: {err:?}");
error!("failed to create modified argument: {:?}", err);
None
}
}