Mirror/stealth
1
0
Fork 0
mirror of https://github.com/LORDBABUINO/stealth.git synced 2026-06-09 06:11:52 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): reject empty descriptors/utxos arrays with bad_request

Browse Source
This commit is contained in:
LORDBABUINO
2026-05-26 14:06:46 -03:00
parent 34501db5fb
commit 2e6f6768bc
1 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/routes/wallet.rs
+42 -2
View File
@@ -41,8 +41,10 @@ impl ScanRequestBody {
fn into_scan_target(self) -> Result<ScanTarget, ApiError> {
match (self.descriptor, self.descriptors, self.utxos) {
(Some(d), None, None) => Ok(ScanTarget::Descriptor(d)),
(None, Some(ds), None) => Ok(ScanTarget::Descriptors(ds)),
(None, None, Some(utxos)) => Ok(ScanTarget::Utxos(utxos)),
(None, Some(ds), None) if !ds.is_empty() => Ok(ScanTarget::Descriptors(ds)),
(None, Some(_), None) => Err(ApiError::bad_request("`descriptors` must not be empty")),
(None, None, Some(utxos)) if !utxos.is_empty() => Ok(ScanTarget::Utxos(utxos)),
(None, None, Some(_)) => Err(ApiError::bad_request("`utxos` must not be empty")),
(None, None, None) => Err(ApiError::bad_request(
"one input source is required: descriptor, descriptors, or utxos",
)),
@@ -127,6 +129,44 @@ mod tests {
assert_eq!(body["error"]["code"], "bad_request");
}
#[tokio::test]
async fn post_scan_rejects_empty_descriptors_list() {
let response = app()
.oneshot(
Request::builder()
.uri("/api/wallet/scan")
.method("POST")
.header("content-type", "application/json")
.body(Body::from(json!({ "descriptors": [] }).to_string()))
.unwrap(),
)
.await
.unwrap();
assert_eq!(response.status(), StatusCode::BAD_REQUEST);
let body = read_json(response).await;
assert_eq!(body["error"]["code"], "bad_request");
}
#[tokio::test]
async fn post_scan_rejects_empty_utxos_list() {
let response = app()
.oneshot(
Request::builder()
.uri("/api/wallet/scan")
.method("POST")
.header("content-type", "application/json")
.body(Body::from(json!({ "utxos": [] }).to_string()))
.unwrap(),
)
.await
.unwrap();
assert_eq!(response.status(), StatusCode::BAD_REQUEST);
let body = read_json(response).await;
assert_eq!(body["error"]["code"], "bad_request");
}
#[tokio::test]
async fn post_scan_returns_503_without_rpc_config() {
let response = app()