Merge pull request #5826 from element-hq/feature/fga/hide_banned_members_name

change(room member): make sure we never display name/avatar when member is banned

libraries/matrix/api/src/main/kotlin/io/element/android/libraries/matrix/api/room/RoomMember.kt

@@ -99,6 +99,6 @@ fun RoomMember.getBestName(): String {
 
 fun RoomMember.toMatrixUser() = MatrixUser(
     userId = userId,
-    displayName = displayName,
-    avatarUrl = avatarUrl,
+    displayName = displayName.takeUnless { membership == RoomMembershipState.BAN },
+    avatarUrl = avatarUrl.takeUnless { membership == RoomMembershipState.BAN },
 )

tests/uitests/src/test/snapshots/images/features.roomdetails.impl.members_RoomMemberListView_Day_3_en.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bae192229d384047dcf5fb6744267a9e448d7f0a4f933a4984a0d1c3b9d07da2
-size 30789
+oid sha256:d5ff0c767c13a80f8305096982d1fb92800d3a25fb50115c631fd3916fd7f52c
+size 30180

tests/uitests/src/test/snapshots/images/features.roomdetails.impl.members_RoomMemberListView_Night_3_en.png

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:dc20039c1c5d456f318f22e524360d411d4a4980b6a2a9312c0707c0fe865340
-size 29867
+oid sha256:5fa0396ed5afbb31ef60cbc74c3369e3eb306f0b4eb168424165c6246ea7cdca
+size 29276