Create log messages from WebView just once (#6923)

We were creating the same message twice by mistake.

Also, check the retrieved message for passwords before formatting the log line instead of after: this way we don't create a new formatted log line to just discard it
This commit is contained in:
Jorge Martin Espinosa
2026-06-01 15:11:04 +02:00
committed by GitHub
parent 81ed41d580
commit 80de3e4c5d
@@ -33,6 +33,11 @@ class DefaultConsoleMessageLogger : ConsoleMessageLogger {
else -> Log.DEBUG
}
// Avoid logging any messages that contain "password" to prevent leaking sensitive information
if (consoleMessage.message().contains("password=")) {
return
}
val message = buildString {
append(consoleMessage.sourceId())
append(":")
@@ -41,20 +46,6 @@ class DefaultConsoleMessageLogger : ConsoleMessageLogger {
append(consoleMessage.message())
}
// Avoid logging any messages that contain "password" to prevent leaking sensitive information
if (message.contains("password=")) {
return
}
Timber.tag(tag).log(
priority = priority,
message = buildString {
append(consoleMessage.sourceId())
append(":")
append(consoleMessage.lineNumber())
append(" ")
append(consoleMessage.message())
},
)
Timber.tag(tag).log(priority = priority, message = message)
}
}