enki/blap-android
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases 4 Wiki Activity

Fix LiveLocationReceiver interface and update tests

Browse Source
This commit is contained in:
ganfra
2026-06-02 13:14:03 +02:00
parent 1a40e460ae
commit a9fe0a3560
2 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/location/impl/src/main/kotlin/io/element/android/features/location/impl/live/service/LiveLocationReceiver.kt
+1 -1
View File
@@ -11,5 +11,5 @@ import io.element.android.features.location.api.Location
interface LiveLocationReceiver {
suspend fun onLocationUpdate(location: Location)
suspend fun onUnrecoverableError() {}
suspend fun onUnrecoverableError()
}
features/location/impl/src/test/kotlin/io/element/android/features/location/impl/live/LiveLocationSharingCoordinatorTest.kt
+13 -6
View File
@@ -27,7 +27,7 @@ class LiveLocationSharingCoordinatorTest {
nowMillis = { 0L },
)
coordinator.register(A_SESSION_ID, LiveLocationReceiver { })
coordinator.register(A_SESSION_ID, liveLocationReceiver())
coordinator.unregister(A_SESSION_ID)
assertThat(startCount).isEqualTo(1)
@@ -43,8 +43,8 @@ class LiveLocationSharingCoordinatorTest {
nowMillis = { 4_000L },
)
coordinator.register(A_SESSION_ID) { error("boom") }
coordinator.register(A_SESSION_ID_2) { location -> delivered += location }
coordinator.register(A_SESSION_ID, liveLocationReceiver { error("boom") })
coordinator.register(A_SESSION_ID_2, liveLocationReceiver { delivered += it })
coordinator.dispatch(Location(lat = 1.0, lon = 2.0, accuracy = 3f))
assertThat(delivered).containsExactly(Location(lat = 1.0, lon = 2.0, accuracy = 3f))
@@ -60,7 +60,7 @@ class LiveLocationSharingCoordinatorTest {
nowMillis = { nowMillis },
)
coordinator.register(A_SESSION_ID) { location -> delivered += location }
coordinator.register(A_SESSION_ID, liveLocationReceiver { delivered += it })
val firstLocation = Location(lat = 1.0, lon = 2.0, accuracy = 3f)
@@ -79,7 +79,7 @@ class LiveLocationSharingCoordinatorTest {
nowMillis = { nowMillis },
)
coordinator.register(A_SESSION_ID) { location -> delivered += location }
coordinator.register(A_SESSION_ID, liveLocationReceiver { delivered += it })
val firstLocation = Location(lat = 1.0, lon = 2.0, accuracy = 3f)
val secondLocation = Location(lat = 4.0, lon = 5.0, accuracy = 6f)
@@ -101,7 +101,7 @@ class LiveLocationSharingCoordinatorTest {
nowMillis = { nowMillis },
)
coordinator.register(A_SESSION_ID) { location -> delivered += location }
coordinator.register(A_SESSION_ID, liveLocationReceiver { delivered += it })
val firstLocation = Location(lat = 1.0, lon = 2.0, accuracy = 3f)
val secondLocation = Location(lat = 4.0, lon = 5.0, accuracy = 6f)
@@ -113,3 +113,10 @@ class LiveLocationSharingCoordinatorTest {
assertThat(delivered).containsExactly(firstLocation, secondLocation).inOrder()
}
}
private fun liveLocationReceiver(
onLocation: suspend (Location) -> Unit = {},
) = object : LiveLocationReceiver {
override suspend fun onLocationUpdate(location: Location) = onLocation(location)
override suspend fun onUnrecoverableError() = Unit
}