Fix modules dir tsc not running in CI (#33811)

* Fix modules dir tsc not running in CI

* Switch to nx run-many for ci task

This has smarter scheduling logic for dependant tasks

.github/workflows/static_analysis.yaml

@@ -68,7 +68,7 @@ jobs:
               run: "pnpm install --frozen-lockfile"
 
             - name: Run ${{ matrix.command }}
-              run: pnpm --if-present run "$CMD" && pnpm -r --workspace-concurrency=1 --if-present run "$CMD"
+              run: pnpm nx run-many -t "$CMD" -p
               env:
                   CMD: ${{ matrix.command }}
 

apps/desktop/package.json

@@ -112,6 +112,9 @@
         "matrix-seshat": "4.3.0"
     },
     "nx": {
-        "includedScripts": []
+        "includedScripts": [
+            "lint:types",
+            "lint:js"
+        ]
     }
 }

modules/package.json

@@ -4,7 +4,7 @@
     "type": "module",
     "scripts": {
         "lint:js": "eslint --max-warnings 0 playwright */src -c ./.eslintrc.cjs",
-        "lint:ts": "tsc --noEmit",
+        "lint:types": "nx lint:types --",
         "test:playwright": "nx test:playwright --",
         "test:playwright:open": "nx test:playwright -- --ui",
         "test:playwright:screenshots": "nx test:playwright:screenshots --"

modules/project.json

@@ -3,6 +3,11 @@
     "projectType": "library",
     "implicitDependencies": ["modules/*"],
     "targets": {
+        "lint:types": {
+            "command": "tsc --noEmit",
+            "options": { "cwd": "modules" },
+            "dependsOn": ["^build:playwright"]
+        },
         "test:playwright": {
             "command": "playwright test",
             "options": { "cwd": "modules" },

package.json

@@ -59,5 +59,6 @@
             "onFail": "error"
         }
     },
-    "private": true
+    "private": true,
+    "nx": {}
 }